You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2021/02/01 09:36:07 UTC

[GitHub] [cordova] raphinesse commented on issue #266: Ignoring exec() from previous page load.

raphinesse commented on issue #266:
URL: https://github.com/apache/cordova/issues/266#issuecomment-770717119


   Thanks for your feedback. There is no progress on my side yet. I'll look into it when I find the time. Unfortunately spare time is scarce for me at the moment.
   
   If you or someone else wants to further help moving this forward, here's the next steps I would take:
   
   - Find out how the navigator replacement code actually does anything.
     As described in the linked PR where I removed it, the assignment should not do anything per spec, as `window.navigator` is a read-only property. Thus `replaceNavigator` is probably modifying the `origNavigator` object in some non-obvious way.
   
   - Understand how the missing changes in the navigator object break the JS/native bridge
   
   -  Figure out how we want to fix this issue.
      Adding the old code back should not be the first choice, as it is misleading and not strict-mode compliant and we are eventually trying to get there.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org