You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/08/17 19:36:23 UTC

[GitHub] [beam] yifanmai opened a new pull request #12605: Copy subtransforms to output of translations.pipeline_from_stages()

yifanmai opened a new pull request #12605:
URL: https://github.com/apache/beam/pull/12605


   `translations.pipeline_from_stages()` takes in a pipeline proto and a list of stages, and outputs a pipeline proto in which the transforms specified in the stages have been copied form the input pipeline proto. This change recursively finds all subtransforms that these transforms depend on, and copies them from the input pipeline proto to the output pipeline proto.
   
   Post-Commit Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   
   Lang | SDK | Dataflow | Flink | Samza | Spark | Twister2
   --- | --- | --- | --- | --- | --- | ---
   Go | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) | ---
   Java | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/badge/i
 con)](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[![Build Status](htt
 ps://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/)
   Python | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_
 Py_VR_Dataflow/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/) | --- | [![Build Status](https://ci-beam.apache.org/job/beam_P
 ostCommit_Python_VR_Spark/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/) | ---
   XLang | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/) | --- | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/) | ---
   
   Pre-Commit Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   
   --- |Java | Python | Go | Website
   --- | --- | --- | --- | ---
   Non-portable | [![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/lastCompletedBuild/) <br>[![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocs_Cron/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocs_Cron/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/be
 am_PreCommit_Go_Cron/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/)
   Portable | --- | [![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | ---
   
   See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
   
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   ![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] yifanmai commented on pull request #12605: Copy subtransforms to output of translations.pipeline_from_stages()

Posted by GitBox <gi...@apache.org>.
yifanmai commented on pull request #12605:
URL: https://github.com/apache/beam/pull/12605#issuecomment-681057445


   OK, yapf made a number of changes on unchanged lines; let me know if you'd like me to undo them.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] edited a comment on pull request #12605: Copy subtransforms to output of translations.pipeline_from_stages()

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12605:
URL: https://github.com/apache/beam/pull/12605#issuecomment-680234009


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12605?src=pr&el=h1) Report
   > :exclamation: No coverage uploaded for pull request base (`master@12004fd`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12605/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12605?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master   #12605   +/-   ##
   =========================================
     Coverage          ?   34.32%           
   =========================================
     Files             ?      694           
     Lines             ?    82235           
     Branches          ?     9297           
   =========================================
     Hits              ?    28226           
     Misses            ?    53586           
     Partials          ?      423           
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12605?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...cp/internal/clients/storage/storage\_v1\_messages.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-aW8vZ2NwL2ludGVybmFsL2NsaWVudHMvc3RvcmFnZS9zdG9yYWdlX3YxX21lc3NhZ2VzLnB5) | `100.00% <0.00%> (ø)` | |
   | [typehints/trivial\_inference\_test\_py3.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-dHlwZWhpbnRzL3RyaXZpYWxfaW5mZXJlbmNlX3Rlc3RfcHkzLnB5) | `75.00% <0.00%> (ø)` | |
   | [testing/extra\_assertions.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-dGVzdGluZy9leHRyYV9hc3NlcnRpb25zLnB5) | `20.00% <0.00%> (ø)` | |
   | [runners/interactive/interactive\_environment.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-cnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9lbnZpcm9ubWVudC5weQ==) | `40.99% <0.00%> (ø)` | |
   | [examples/wordcount\_minimal.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-ZXhhbXBsZXMvd29yZGNvdW50X21pbmltYWwucHk=) | `44.44% <0.00%> (ø)` | |
   | [testing/benchmarks/nexmark/queries/query11.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-dGVzdGluZy9iZW5jaG1hcmtzL25leG1hcmsvcXVlcmllcy9xdWVyeTExLnB5) | `0.00% <0.00%> (ø)` | |
   | [options/pipeline\_options\_validator.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-b3B0aW9ucy9waXBlbGluZV9vcHRpb25zX3ZhbGlkYXRvci5weQ==) | `46.09% <0.00%> (ø)` | |
   | [...ive/messaging/interactive\_environment\_inspector.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-cnVubmVycy9pbnRlcmFjdGl2ZS9tZXNzYWdpbmcvaW50ZXJhY3RpdmVfZW52aXJvbm1lbnRfaW5zcGVjdG9yLnB5) | `28.20% <0.00%> (ø)` | |
   | [ml/gcp/visionml.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-bWwvZ2NwL3Zpc2lvbm1sLnB5) | `47.61% <0.00%> (ø)` | |
   | [io/flink/flink\_streaming\_impulse\_source\_test.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-aW8vZmxpbmsvZmxpbmtfc3RyZWFtaW5nX2ltcHVsc2Vfc291cmNlX3Rlc3QucHk=) | `72.72% <0.00%> (ø)` | |
   | ... and [684 more](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12605?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12605?src=pr&el=footer). Last update [12004fd...04096c6](https://codecov.io/gh/apache/beam/pull/12605?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] yifanmai commented on pull request #12605: Copy subtransforms to output of translations.pipeline_from_stages()

Posted by GitBox <gi...@apache.org>.
yifanmai commented on pull request #12605:
URL: https://github.com/apache/beam/pull/12605#issuecomment-675072116


   R: @robertwb 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] robertwb merged pull request #12605: Copy subtransforms to output of translations.pipeline_from_stages()

Posted by GitBox <gi...@apache.org>.
robertwb merged pull request #12605:
URL: https://github.com/apache/beam/pull/12605


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] edited a comment on pull request #12605: Copy subtransforms to output of translations.pipeline_from_stages()

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12605:
URL: https://github.com/apache/beam/pull/12605#issuecomment-680234009


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12605?src=pr&el=h1) Report
   > Merging [#12605](https://codecov.io/gh/apache/beam/pull/12605?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/78d7636cac9234dbcc7145bb0330275c557c0010?el=desc) will **decrease** coverage by `5.93%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12605/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12605?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12605      +/-   ##
   ==========================================
   - Coverage   40.25%   34.32%   -5.94%     
   ==========================================
     Files         454      694     +240     
     Lines       53587    82248   +28661     
     Branches        0     9298    +9298     
   ==========================================
   + Hits        21570    28229    +6659     
   - Misses      32017    53596   +21579     
   - Partials        0      423     +423     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12605?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [sdks/python/apache\_beam/transforms/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9fX2luaXRfXy5weQ==) | | |
   | [sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=) | | |
   | [test\_config.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-dGVzdF9jb25maWcucHk=) | | |
   | [.../runners/interactive/testing/pipeline\_assertion.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS90ZXN0aW5nL3BpcGVsaW5lX2Fzc2VydGlvbi5weQ==) | | |
   | [...thon/apache\_beam/io/aws/clients/s3/boto3\_client.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vYXdzL2NsaWVudHMvczMvYm90bzNfY2xpZW50LnB5) | | |
   | [...python/apache\_beam/transforms/external\_test\_py3.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9leHRlcm5hbF90ZXN0X3B5My5weQ==) | | |
   | [sdks/python/apache\_beam/options/value\_provider.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vb3B0aW9ucy92YWx1ZV9wcm92aWRlci5weQ==) | | |
   | [...ython/apache\_beam/runners/direct/direct\_metrics.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvZGlyZWN0X21ldHJpY3MucHk=) | | |
   | [...\_beam/tools/distribution\_counter\_microbenchmark.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdG9vbHMvZGlzdHJpYnV0aW9uX2NvdW50ZXJfbWljcm9iZW5jaG1hcmsucHk=) | | |
   | [...amples/snippets/transforms/aggregation/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvc25pcHBldHMvdHJhbnNmb3Jtcy9hZ2dyZWdhdGlvbi9fX2luaXRfXy5weQ==) | | |
   | ... and [1137 more](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12605?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12605?src=pr&el=footer). Last update [2e77e46...d4e80b6](https://codecov.io/gh/apache/beam/pull/12605?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] commented on pull request #12605: Copy subtransforms to output of translations.pipeline_from_stages()

Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #12605:
URL: https://github.com/apache/beam/pull/12605#issuecomment-680234009


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12605?src=pr&el=h1) Report
   > :exclamation: No coverage uploaded for pull request base (`master@12004fd`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `n/a`.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] robertwb commented on a change in pull request #12605: Copy subtransforms to output of translations.pipeline_from_stages()

Posted by GitBox <gi...@apache.org>.
robertwb commented on a change in pull request #12605:
URL: https://github.com/apache/beam/pull/12605#discussion_r476694605



##########
File path: sdks/python/apache_beam/runners/portability/fn_api_runner/translations.py
##########
@@ -540,6 +549,8 @@ def add_parent(child, parent):
     transform_id = unique_name(components.transforms, stage.name)
     components.transforms[transform_id].CopyFrom(transform)
     add_parent(transform_id, stage.parent)
+    if partial:
+      copy_subtransforms(transform)

Review comment:
       Nit: You can move this up into the `if partial` block above. 

##########
File path: sdks/python/apache_beam/runners/portability/fn_api_runner/translations.py
##########
@@ -1475,6 +1482,12 @@ def only_element(iterable):
   return element
 
 
+def only_transform(stage):
+  # type: Stage -> beam_runner_api_pb2.PTransform

Review comment:
       14:14:31 apache_beam/runners/portability/fn_api_runner/translations.py:1485: error: syntax error in type comment 'Stage -> beam_runner_api_pb2.PTransform'  [syntax]
   14:14:31 apache_beam/runners/portability/fn_api_runner/translations.py:1485: note: Suggestion: wrap argument types in parentheses
   14:14:31 Found 1 error in 1 file (checked 719 source files)
   14:14:31 error: mypy exited with status 2
   14:14:32 ERROR: InvocationError for command /home/jenkins/jenkins-slave/workspace/beam_PreCommit_PythonLint_Commit/src/sdks/python/test-suites/tox/py37/build/srcs/sdks/python/target/.tox-py37-mypy/py37-mypy/bin/python setup.py mypy (exited with code 1)
   14:14:32 py37-mypy run-test-post: commands[0] | bash /home/jenkins/jenkins-slave/workspace/beam_PreCommit_PythonLint_Commit/src/sdks/python/test-suites/tox/py37/build/srcs/sdks/python/scripts/run_tox_cleanup.sh
   14:14:32 ___________________________________ summary ____________________________________
   14:14:32 ERROR:   py37-mypy: commands failed
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] yifanmai commented on a change in pull request #12605: Copy subtransforms to output of translations.pipeline_from_stages()

Posted by GitBox <gi...@apache.org>.
yifanmai commented on a change in pull request #12605:
URL: https://github.com/apache/beam/pull/12605#discussion_r477508976



##########
File path: sdks/python/apache_beam/runners/portability/fn_api_runner/translations.py
##########
@@ -1475,6 +1482,12 @@ def only_element(iterable):
   return element
 
 
+def only_transform(stage):
+  # type: Stage -> beam_runner_api_pb2.PTransform

Review comment:
       Fixed.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] yifanmai commented on a change in pull request #12605: Copy subtransforms to output of translations.pipeline_from_stages()

Posted by GitBox <gi...@apache.org>.
yifanmai commented on a change in pull request #12605:
URL: https://github.com/apache/beam/pull/12605#discussion_r474274784



##########
File path: sdks/python/apache_beam/runners/portability/fn_api_runner/translations.py
##########
@@ -524,6 +524,22 @@ def add_parent(child, parent):
         add_parent(parent, parents.get(parent))
       components.transforms[parent].subtransforms.append(child)
 
+  copied_subtransform_ids = set()

Review comment:
       Thanks! This simplifies things.

##########
File path: sdks/python/apache_beam/runners/portability/fn_api_runner/translations.py
##########
@@ -541,6 +557,14 @@ def add_parent(child, parent):
     components.transforms[transform_id].CopyFrom(transform)
     add_parent(transform_id, stage.parent)
 
+  if partial:

Review comment:
       Moved it back up and cleaned up the method.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] yifanmai commented on pull request #12605: Copy subtransforms to output of translations.pipeline_from_stages()

Posted by GitBox <gi...@apache.org>.
yifanmai commented on pull request #12605:
URL: https://github.com/apache/beam/pull/12605#issuecomment-684026787


   Is this ready to merge?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] edited a comment on pull request #12605: Copy subtransforms to output of translations.pipeline_from_stages()

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12605:
URL: https://github.com/apache/beam/pull/12605#issuecomment-680234009


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12605?src=pr&el=h1) Report
   > :exclamation: No coverage uploaded for pull request base (`master@12004fd`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12605/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12605?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master   #12605   +/-   ##
   =========================================
     Coverage          ?   34.32%           
   =========================================
     Files             ?      694           
     Lines             ?    82248           
     Branches          ?     9298           
   =========================================
     Hits              ?    28229           
     Misses            ?    53596           
     Partials          ?      423           
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12605?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [runners/worker/bundle\_processor\_test.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-cnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvcl90ZXN0LnB5) | `29.57% <0.00%> (ø)` | |
   | [typehints/decorators.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-dHlwZWhpbnRzL2RlY29yYXRvcnMucHk=) | `35.83% <0.00%> (ø)` | |
   | [...les/snippets/transforms/aggregation/sample\_test.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-ZXhhbXBsZXMvc25pcHBldHMvdHJhbnNmb3Jtcy9hZ2dyZWdhdGlvbi9zYW1wbGVfdGVzdC5weQ==) | `70.00% <0.00%> (ø)` | |
   | [transforms/external.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-dHJhbnNmb3Jtcy9leHRlcm5hbC5weQ==) | `32.03% <0.00%> (ø)` | |
   | [runners/portability/expansion\_service.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-cnVubmVycy9wb3J0YWJpbGl0eS9leHBhbnNpb25fc2VydmljZS5weQ==) | `33.33% <0.00%> (ø)` | |
   | [io/fileio\_test.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-aW8vZmlsZWlvX3Rlc3QucHk=) | `27.05% <0.00%> (ø)` | |
   | [transforms/sql\_test.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-dHJhbnNmb3Jtcy9zcWxfdGVzdC5weQ==) | `52.45% <0.00%> (ø)` | |
   | [runners/portability/fn\_api\_runner/execution.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-cnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL2V4ZWN1dGlvbi5weQ==) | `25.13% <0.00%> (ø)` | |
   | [testing/benchmarks/nexmark/queries/query4.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-dGVzdGluZy9iZW5jaG1hcmtzL25leG1hcmsvcXVlcmllcy9xdWVyeTQucHk=) | `0.00% <0.00%> (ø)` | |
   | [transforms/create\_source.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-dHJhbnNmb3Jtcy9jcmVhdGVfc291cmNlLnB5) | `0.00% <0.00%> (ø)` | |
   | ... and [684 more](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12605?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12605?src=pr&el=footer). Last update [12004fd...233a663](https://codecov.io/gh/apache/beam/pull/12605?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] edited a comment on pull request #12605: Copy subtransforms to output of translations.pipeline_from_stages()

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12605:
URL: https://github.com/apache/beam/pull/12605#issuecomment-680234009


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12605?src=pr&el=h1) Report
   > :exclamation: No coverage uploaded for pull request base (`master@12004fd`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12605/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12605?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master   #12605   +/-   ##
   =========================================
     Coverage          ?   34.32%           
   =========================================
     Files             ?      694           
     Lines             ?    82248           
     Branches          ?     9298           
   =========================================
     Hits              ?    28229           
     Misses            ?    53596           
     Partials          ?      423           
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12605?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [examples/snippets/transforms/elementwise/regex.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-ZXhhbXBsZXMvc25pcHBldHMvdHJhbnNmb3Jtcy9lbGVtZW50d2lzZS9yZWdleC5weQ==) | `17.74% <0.00%> (ø)` | |
   | [testing/benchmarks/nexmark/queries/query4.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-dGVzdGluZy9iZW5jaG1hcmtzL25leG1hcmsvcXVlcmllcy9xdWVyeTQucHk=) | `0.00% <0.00%> (ø)` | |
   | [...unners/interactive/options/capture\_control\_test.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-cnVubmVycy9pbnRlcmFjdGl2ZS9vcHRpb25zL2NhcHR1cmVfY29udHJvbF90ZXN0LnB5) | `32.03% <0.00%> (ø)` | |
   | [examples/snippets/transforms/aggregation/mean.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-ZXhhbXBsZXMvc25pcHBldHMvdHJhbnNmb3Jtcy9hZ2dyZWdhdGlvbi9tZWFuLnB5) | `28.57% <0.00%> (ø)` | |
   | [\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-X19pbml0X18ucHk=) | `64.00% <0.00%> (ø)` | |
   | [examples/streaming\_wordcount\_debugging\_test.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-ZXhhbXBsZXMvc3RyZWFtaW5nX3dvcmRjb3VudF9kZWJ1Z2dpbmdfdGVzdC5weQ==) | `36.36% <0.00%> (ø)` | |
   | [io/vcfio\_test.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-aW8vdmNmaW9fdGVzdC5weQ==) | `26.61% <0.00%> (ø)` | |
   | [typehints/typehints.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-dHlwZWhpbnRzL3R5cGVoaW50cy5weQ==) | `46.62% <0.00%> (ø)` | |
   | [utils/timestamp\_test.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-dXRpbHMvdGltZXN0YW1wX3Rlc3QucHk=) | `21.60% <0.00%> (ø)` | |
   | [examples/cookbook/bigquery\_tornadoes\_test.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-ZXhhbXBsZXMvY29va2Jvb2svYmlncXVlcnlfdG9ybmFkb2VzX3Rlc3QucHk=) | `73.33% <0.00%> (ø)` | |
   | ... and [684 more](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12605?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12605?src=pr&el=footer). Last update [12004fd...233a663](https://codecov.io/gh/apache/beam/pull/12605?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] edited a comment on pull request #12605: Copy subtransforms to output of translations.pipeline_from_stages()

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12605:
URL: https://github.com/apache/beam/pull/12605#issuecomment-680234009


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12605?src=pr&el=h1) Report
   > :exclamation: No coverage uploaded for pull request base (`master@12004fd`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12605/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12605?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master   #12605   +/-   ##
   =========================================
     Coverage          ?   34.32%           
   =========================================
     Files             ?      694           
     Lines             ?    82235           
     Branches          ?     9297           
   =========================================
     Hits              ?    28226           
     Misses            ?    53586           
     Partials          ?      423           
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12605?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [io/mongodbio\_test.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-aW8vbW9uZ29kYmlvX3Rlc3QucHk=) | `34.95% <0.00%> (ø)` | |
   | [testing/benchmarks/chicago\_taxi/trainer/model.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-dGVzdGluZy9iZW5jaG1hcmtzL2NoaWNhZ29fdGF4aS90cmFpbmVyL21vZGVsLnB5) | `0.00% <0.00%> (ø)` | |
   | [transforms/sql\_test.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-dHJhbnNmb3Jtcy9zcWxfdGVzdC5weQ==) | `52.45% <0.00%> (ø)` | |
   | [internal/pickler.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-aW50ZXJuYWwvcGlja2xlci5weQ==) | `64.17% <0.00%> (ø)` | |
   | [runners/portability/flink\_uber\_jar\_job\_server.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-cnVubmVycy9wb3J0YWJpbGl0eS9mbGlua191YmVyX2phcl9qb2Jfc2VydmVyLnB5) | `30.83% <0.00%> (ø)` | |
   | [runners/interactive/display/pcoll\_visualization.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-cnVubmVycy9pbnRlcmFjdGl2ZS9kaXNwbGF5L3Bjb2xsX3Zpc3VhbGl6YXRpb24ucHk=) | `24.25% <0.00%> (ø)` | |
   | [io/gcp/bigquery\_file\_loads\_test.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-aW8vZ2NwL2JpZ3F1ZXJ5X2ZpbGVfbG9hZHNfdGVzdC5weQ==) | `24.53% <0.00%> (ø)` | |
   | [runners/job/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-cnVubmVycy9qb2IvX19pbml0X18ucHk=) | `100.00% <0.00%> (ø)` | |
   | [runners/worker/worker\_id\_interceptor\_test.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-cnVubmVycy93b3JrZXIvd29ya2VyX2lkX2ludGVyY2VwdG9yX3Rlc3QucHk=) | `46.15% <0.00%> (ø)` | |
   | [examples/complete/top\_wikipedia\_sessions.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-ZXhhbXBsZXMvY29tcGxldGUvdG9wX3dpa2lwZWRpYV9zZXNzaW9ucy5weQ==) | `56.36% <0.00%> (ø)` | |
   | ... and [684 more](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12605?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12605?src=pr&el=footer). Last update [12004fd...578d08b](https://codecov.io/gh/apache/beam/pull/12605?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] edited a comment on pull request #12605: Copy subtransforms to output of translations.pipeline_from_stages()

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12605:
URL: https://github.com/apache/beam/pull/12605#issuecomment-680234009


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12605?src=pr&el=h1) Report
   > :exclamation: No coverage uploaded for pull request base (`master@12004fd`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12605/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12605?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master   #12605   +/-   ##
   =========================================
     Coverage          ?   34.32%           
   =========================================
     Files             ?      694           
     Lines             ?    82235           
     Branches          ?     9297           
   =========================================
     Hits              ?    28226           
     Misses            ?    53586           
     Partials          ?      423           
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12605?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [ml/gcp/cloud\_dlp.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-bWwvZ2NwL2Nsb3VkX2RscC5weQ==) | `31.76% <0.00%> (ø)` | |
   | [io/gcp/datastore/v1new/query\_splitter.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-aW8vZ2NwL2RhdGFzdG9yZS92MW5ldy9xdWVyeV9zcGxpdHRlci5weQ==) | `26.47% <0.00%> (ø)` | |
   | [examples/complete/top\_wikipedia\_sessions\_test.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-ZXhhbXBsZXMvY29tcGxldGUvdG9wX3dpa2lwZWRpYV9zZXNzaW9uc190ZXN0LnB5) | `76.47% <0.00%> (ø)` | |
   | [transforms/ptransform.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-dHJhbnNmb3Jtcy9wdHJhbnNmb3JtLnB5) | `37.18% <0.00%> (ø)` | |
   | [...amples/snippets/transforms/aggregation/distinct.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-ZXhhbXBsZXMvc25pcHBldHMvdHJhbnNmb3Jtcy9hZ2dyZWdhdGlvbi9kaXN0aW5jdC5weQ==) | `37.50% <0.00%> (ø)` | |
   | [examples/complete/tfidf\_test.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-ZXhhbXBsZXMvY29tcGxldGUvdGZpZGZfdGVzdC5weQ==) | `44.18% <0.00%> (ø)` | |
   | [io/utils.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-aW8vdXRpbHMucHk=) | `35.29% <0.00%> (ø)` | |
   | [runners/worker/worker\_id\_interceptor.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-cnVubmVycy93b3JrZXIvd29ya2VyX2lkX2ludGVyY2VwdG9yLnB5) | `56.25% <0.00%> (ø)` | |
   | [utils/windowed\_value\_test.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-dXRpbHMvd2luZG93ZWRfdmFsdWVfdGVzdC5weQ==) | `40.62% <0.00%> (ø)` | |
   | [typehints/typehints\_test\_py3.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-dHlwZWhpbnRzL3R5cGVoaW50c190ZXN0X3B5My5weQ==) | `21.89% <0.00%> (ø)` | |
   | ... and [684 more](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12605?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12605?src=pr&el=footer). Last update [12004fd...578d08b](https://codecov.io/gh/apache/beam/pull/12605?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] edited a comment on pull request #12605: Copy subtransforms to output of translations.pipeline_from_stages()

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12605:
URL: https://github.com/apache/beam/pull/12605#issuecomment-680234009


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12605?src=pr&el=h1) Report
   > :exclamation: No coverage uploaded for pull request base (`master@12004fd`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12605/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12605?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master   #12605   +/-   ##
   =========================================
     Coverage          ?   34.32%           
   =========================================
     Files             ?      694           
     Lines             ?    82248           
     Branches          ?     9298           
   =========================================
     Hits              ?    28229           
     Misses            ?    53596           
     Partials          ?      423           
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12605?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [examples/snippets/transforms/aggregation/sample.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-ZXhhbXBsZXMvc25pcHBldHMvdHJhbnNmb3Jtcy9hZ2dyZWdhdGlvbi9zYW1wbGUucHk=) | `28.57% <0.00%> (ø)` | |
   | [io/aws/clients/s3/boto3\_client.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-aW8vYXdzL2NsaWVudHMvczMvYm90bzNfY2xpZW50LnB5) | `14.85% <0.00%> (ø)` | |
   | [transforms/display\_test.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-dHJhbnNmb3Jtcy9kaXNwbGF5X3Rlc3QucHk=) | `26.19% <0.00%> (ø)` | |
   | [coders/coder\_impl.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-Y29kZXJzL2NvZGVyX2ltcGwucHk=) | `91.06% <0.00%> (ø)` | |
   | [io/iobase.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-aW8vaW9iYXNlLnB5) | `47.35% <0.00%> (ø)` | |
   | [runners/dataflow/native\_io/iobase\_test.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-cnVubmVycy9kYXRhZmxvdy9uYXRpdmVfaW8vaW9iYXNlX3Rlc3QucHk=) | `41.66% <0.00%> (ø)` | |
   | [...amples/snippets/transforms/aggregation/min\_test.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-ZXhhbXBsZXMvc25pcHBldHMvdHJhbnNmb3Jtcy9hZ2dyZWdhdGlvbi9taW5fdGVzdC5weQ==) | `70.00% <0.00%> (ø)` | |
   | [runners/dataflow/dataflow\_runner\_test.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-cnVubmVycy9kYXRhZmxvdy9kYXRhZmxvd19ydW5uZXJfdGVzdC5weQ==) | `25.49% <0.00%> (ø)` | |
   | [io/gcp/bigquery\_read\_it\_test.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-aW8vZ2NwL2JpZ3F1ZXJ5X3JlYWRfaXRfdGVzdC5weQ==) | `33.33% <0.00%> (ø)` | |
   | [transforms/external\_it\_test.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-dHJhbnNmb3Jtcy9leHRlcm5hbF9pdF90ZXN0LnB5) | `48.27% <0.00%> (ø)` | |
   | ... and [684 more](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12605?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12605?src=pr&el=footer). Last update [12004fd...233a663](https://codecov.io/gh/apache/beam/pull/12605?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] edited a comment on pull request #12605: Copy subtransforms to output of translations.pipeline_from_stages()

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12605:
URL: https://github.com/apache/beam/pull/12605#issuecomment-680234009


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12605?src=pr&el=h1) Report
   > :exclamation: No coverage uploaded for pull request base (`master@12004fd`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12605/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12605?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master   #12605   +/-   ##
   =========================================
     Coverage          ?   34.32%           
   =========================================
     Files             ?      694           
     Lines             ?    82235           
     Branches          ?     9297           
   =========================================
     Hits              ?    28226           
     Misses            ?    53586           
     Partials          ?      423           
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12605?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [runners/worker/bundle\_processor\_test.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-cnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvcl90ZXN0LnB5) | `29.57% <0.00%> (ø)` | |
   | [typehints/decorators.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-dHlwZWhpbnRzL2RlY29yYXRvcnMucHk=) | `35.83% <0.00%> (ø)` | |
   | [...les/snippets/transforms/aggregation/sample\_test.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-ZXhhbXBsZXMvc25pcHBldHMvdHJhbnNmb3Jtcy9hZ2dyZWdhdGlvbi9zYW1wbGVfdGVzdC5weQ==) | `70.00% <0.00%> (ø)` | |
   | [transforms/external.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-dHJhbnNmb3Jtcy9leHRlcm5hbC5weQ==) | `32.03% <0.00%> (ø)` | |
   | [runners/portability/expansion\_service.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-cnVubmVycy9wb3J0YWJpbGl0eS9leHBhbnNpb25fc2VydmljZS5weQ==) | `33.33% <0.00%> (ø)` | |
   | [io/fileio\_test.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-aW8vZmlsZWlvX3Rlc3QucHk=) | `27.05% <0.00%> (ø)` | |
   | [transforms/sql\_test.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-dHJhbnNmb3Jtcy9zcWxfdGVzdC5weQ==) | `52.45% <0.00%> (ø)` | |
   | [runners/portability/fn\_api\_runner/execution.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-cnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL2V4ZWN1dGlvbi5weQ==) | `25.13% <0.00%> (ø)` | |
   | [testing/benchmarks/nexmark/queries/query4.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-dGVzdGluZy9iZW5jaG1hcmtzL25leG1hcmsvcXVlcmllcy9xdWVyeTQucHk=) | `0.00% <0.00%> (ø)` | |
   | [transforms/create\_source.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-dHJhbnNmb3Jtcy9jcmVhdGVfc291cmNlLnB5) | `0.00% <0.00%> (ø)` | |
   | ... and [684 more](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12605?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12605?src=pr&el=footer). Last update [12004fd...233a663](https://codecov.io/gh/apache/beam/pull/12605?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] edited a comment on pull request #12605: Copy subtransforms to output of translations.pipeline_from_stages()

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12605:
URL: https://github.com/apache/beam/pull/12605#issuecomment-680234009


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12605?src=pr&el=h1) Report
   > :exclamation: No coverage uploaded for pull request base (`master@12004fd`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12605/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12605?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master   #12605   +/-   ##
   =========================================
     Coverage          ?   34.32%           
   =========================================
     Files             ?      694           
     Lines             ?    82235           
     Branches          ?     9297           
   =========================================
     Hits              ?    28226           
     Misses            ?    53586           
     Partials          ?      423           
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12605?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [io/gcp/tests/utils.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-aW8vZ2NwL3Rlc3RzL3V0aWxzLnB5) | `35.29% <0.00%> (ø)` | |
   | [transforms/window.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-dHJhbnNmb3Jtcy93aW5kb3cucHk=) | `55.33% <0.00%> (ø)` | |
   | [io/external/xlang\_kafkaio\_it\_test.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-aW8vZXh0ZXJuYWwveGxhbmdfa2Fma2Fpb19pdF90ZXN0LnB5) | `42.85% <0.00%> (ø)` | |
   | [io/gcp/datastore/v1new/query\_splitter.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-aW8vZ2NwL2RhdGFzdG9yZS92MW5ldy9xdWVyeV9zcGxpdHRlci5weQ==) | `26.47% <0.00%> (ø)` | |
   | [testing/benchmarks/nexmark/models/nexmark\_model.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-dGVzdGluZy9iZW5jaG1hcmtzL25leG1hcmsvbW9kZWxzL25leG1hcmtfbW9kZWwucHk=) | `0.00% <0.00%> (ø)` | |
   | [utils/profiler.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-dXRpbHMvcHJvZmlsZXIucHk=) | `30.27% <0.00%> (ø)` | |
   | [io/external/gcp/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-aW8vZXh0ZXJuYWwvZ2NwL19faW5pdF9fLnB5) | `0.00% <0.00%> (ø)` | |
   | [runners/interactive/caching/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-cnVubmVycy9pbnRlcmFjdGl2ZS9jYWNoaW5nL19faW5pdF9fLnB5) | `100.00% <0.00%> (ø)` | |
   | [runners/interactive/testing/mock\_ipython.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-cnVubmVycy9pbnRlcmFjdGl2ZS90ZXN0aW5nL21vY2tfaXB5dGhvbi5weQ==) | `7.14% <0.00%> (ø)` | |
   | [...tests/streaming/group\_by\_key\_streaming\_pipeline.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-dGVzdGluZy9sb2FkX3Rlc3RzL3N0cmVhbWluZy9ncm91cF9ieV9rZXlfc3RyZWFtaW5nX3BpcGVsaW5lLnB5) | `36.11% <0.00%> (ø)` | |
   | ... and [684 more](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12605?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12605?src=pr&el=footer). Last update [12004fd...578d08b](https://codecov.io/gh/apache/beam/pull/12605?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] robertwb commented on pull request #12605: Copy subtransforms to output of translations.pipeline_from_stages()

Posted by GitBox <gi...@apache.org>.
robertwb commented on pull request #12605:
URL: https://github.com/apache/beam/pull/12605#issuecomment-682805753


   Huh, usually yapf doesn't do that. It should be find though. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] robertwb commented on a change in pull request #12605: Copy subtransforms to output of translations.pipeline_from_stages()

Posted by GitBox <gi...@apache.org>.
robertwb commented on a change in pull request #12605:
URL: https://github.com/apache/beam/pull/12605#discussion_r473198225



##########
File path: sdks/python/apache_beam/runners/portability/fn_api_runner/translations.py
##########
@@ -524,6 +524,22 @@ def add_parent(child, parent):
         add_parent(parent, parents.get(parent))
       components.transforms[parent].subtransforms.append(child)
 
+  copied_subtransform_ids = set()

Review comment:
       Given that the set of subtransformation is a tree (no cycles) we can get rid of this.

##########
File path: sdks/python/apache_beam/runners/portability/fn_api_runner/translations.py
##########
@@ -541,6 +557,14 @@ def add_parent(child, parent):
     components.transforms[transform_id].CopyFrom(transform)
     add_parent(transform_id, stage.parent)
 
+  if partial:

Review comment:
       I think we only want to copy sub-transforms of the transforms from line 552 above, perhaps move this logic up there? (Just a thought, maybe having the method be called (`copy_subtransforms` and having it copy (recursively) just the subtransforms could make this even easier to follow). 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] edited a comment on pull request #12605: Copy subtransforms to output of translations.pipeline_from_stages()

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12605:
URL: https://github.com/apache/beam/pull/12605#issuecomment-680234009


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12605?src=pr&el=h1) Report
   > :exclamation: No coverage uploaded for pull request base (`master@12004fd`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12605/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12605?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master   #12605   +/-   ##
   =========================================
     Coverage          ?   34.32%           
   =========================================
     Files             ?      694           
     Lines             ?    82235           
     Branches          ?     9297           
   =========================================
     Hits              ?    28226           
     Misses            ?    53586           
     Partials          ?      423           
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12605?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [testing/datatype\_inference\_test.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-dGVzdGluZy9kYXRhdHlwZV9pbmZlcmVuY2VfdGVzdC5weQ==) | `66.19% <0.00%> (ø)` | |
   | [io/gcp/tests/pubsub\_matcher.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-aW8vZ2NwL3Rlc3RzL3B1YnN1Yl9tYXRjaGVyLnB5) | `24.70% <0.00%> (ø)` | |
   | [examples/snippets/snippets\_test\_py3.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-ZXhhbXBsZXMvc25pcHBldHMvc25pcHBldHNfdGVzdF9weTMucHk=) | `24.44% <0.00%> (ø)` | |
   | [io/restriction\_trackers.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-aW8vcmVzdHJpY3Rpb25fdHJhY2tlcnMucHk=) | `32.14% <0.00%> (ø)` | |
   | [...unners/interactive/options/capture\_control\_test.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-cnVubmVycy9pbnRlcmFjdGl2ZS9vcHRpb25zL2NhcHR1cmVfY29udHJvbF90ZXN0LnB5) | `32.03% <0.00%> (ø)` | |
   | [io/tfrecordio.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-aW8vdGZyZWNvcmRpby5weQ==) | `41.66% <0.00%> (ø)` | |
   | [io/gcp/internal/clients/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-aW8vZ2NwL2ludGVybmFsL2NsaWVudHMvX19pbml0X18ucHk=) | `100.00% <0.00%> (ø)` | |
   | [io/gcp/internal/clients/bigquery/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-aW8vZ2NwL2ludGVybmFsL2NsaWVudHMvYmlncXVlcnkvX19pbml0X18ucHk=) | `80.00% <0.00%> (ø)` | |
   | [io/gcp/datastore/v1new/util\_test.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-aW8vZ2NwL2RhdGFzdG9yZS92MW5ldy91dGlsX3Rlc3QucHk=) | `32.20% <0.00%> (ø)` | |
   | [metrics/metric.py](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree#diff-bWV0cmljcy9tZXRyaWMucHk=) | `52.10% <0.00%> (ø)` | |
   | ... and [684 more](https://codecov.io/gh/apache/beam/pull/12605/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12605?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12605?src=pr&el=footer). Last update [12004fd...578d08b](https://codecov.io/gh/apache/beam/pull/12605?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org