You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by "liaorui (via GitHub)" <gi...@apache.org> on 2023/03/03 04:35:25 UTC
[GitHub] [inlong] liaorui opened a new pull request, #7509: [INLONG-7508][Sort]cdc-base sends RowData to sink, should carry right RowKind
liaorui opened a new pull request, #7509:
URL: https://github.com/apache/inlong/pull/7509
### Prepare a Pull Request
*(Change the title refer to the following example)*
- Title Example: [INLONG-XYZ][Component] Title of the pull request
*(The following *XYZ* should be replaced by the actual [GitHub Issue](https://github.com/apache/inlong/issues) number)*
- Fixes #7508
### Motivation
*Explain here the context, and why you're making that change. What is the problem you're trying to solve?*
cdc-base sends RowData to sink, should carry right RowKind
### Modifications
*Describe the modifications you've done.*
`AppendMetadataCollector` make a new GenericRowData instance, should pass right RowKind.
### Verifying this change
*(Please pick either of the following options)*
- [ ] This change is a trivial rework/code cleanup without any test coverage.
- [ ] This change is already covered by existing tests, such as:
*(please describe tests)*
- [ ] This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] liaorui commented on pull request #7509: [INLONG-7508][Sort] Carry right RowKind when cdc-base sends RowData to sink
Posted by "liaorui (via GitHub)" <gi...@apache.org>.
liaorui commented on PR #7509:
URL: https://github.com/apache/inlong/pull/7509#issuecomment-1457700410
Close this PR since PR #7397 has solved this problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] liaorui commented on pull request #7509: [INLONG-7508][Sort]cdc-base sends RowData to sink, should carry right RowKind
Posted by "liaorui (via GitHub)" <gi...@apache.org>.
liaorui commented on PR #7509:
URL: https://github.com/apache/inlong/pull/7509#issuecomment-1453031392
>
Source database has a update operation, cdc send `update` type in json data. Sink connector cannot known whether is Update_Before or Update_After.
The 3rd screenshot shows that sink connector always get update before node null from json data.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] gong commented on pull request #7509: [INLONG-7508][Sort] Carry right RowKind when cdc-base sends RowData to sink
Posted by "gong (via GitHub)" <gi...@apache.org>.
gong commented on PR #7509:
URL: https://github.com/apache/inlong/pull/7509#issuecomment-1453306847
> >
>
> When source table has a update operation, cdc send `update` type in json data. Sink connector cannot known whether is Update_Before or Update_After.
>
> The 3rd screenshot shows that sink connector always get `updateBeforeNode` null from json data.
@liaorui @EMsnap have a PR issue this problem. https://github.com/apache/inlong/issues/7397
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] gong commented on pull request #7509: [INLONG-7508][Sort]cdc-base sends RowData to sink, should carry right RowKind
Posted by "gong (via GitHub)" <gi...@apache.org>.
gong commented on PR #7509:
URL: https://github.com/apache/inlong/pull/7509#issuecomment-1453000645
Now sink parse rowkind from data when all database migration. So rowkind use INSERT.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] EMsnap commented on pull request #7509: [INLONG-7508][Sort] Carry right RowKind when cdc-base sends RowData to sink
Posted by "EMsnap (via GitHub)" <gi...@apache.org>.
EMsnap commented on PR #7509:
URL: https://github.com/apache/inlong/pull/7509#issuecomment-1457617585
The opType in allmigrate is represented as the parameter TYPE in canal json. maybe you can get the optype from there
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] liaorui closed pull request #7509: [INLONG-7508][Sort] Carry right RowKind when cdc-base sends RowData to sink
Posted by "liaorui (via GitHub)" <gi...@apache.org>.
liaorui closed pull request #7509: [INLONG-7508][Sort] Carry right RowKind when cdc-base sends RowData to sink
URL: https://github.com/apache/inlong/pull/7509
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org