You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Tony Chemit (JIRA)" <ji...@codehaus.org> on 2011/09/16 01:15:17 UTC
[jira] Created: (MJARSIGNER-19) Make mojo code reusable from
another mojo + customize the working directory.
Make mojo code reusable from another mojo + customize the working directory.
----------------------------------------------------------------------------
Key: MJARSIGNER-19
URL: https://jira.codehaus.org/browse/MJARSIGNER-19
Project: Maven 2.x Jar Signer Plugin
Issue Type: Improvement
Affects Versions: 1.2
Reporter: Tony Chemit
Priority: Trivial
In the webstart-maven-plugin We used the old jarsigner mojo (from the jar plugin).
We'd like to use now this plugin as the mojo from the jar plugin is deprecated for this one (see MWEBSTART-149)
Moreover, we want to use yet another working directory and at the moment in the mojo this is hardcoed to project.getBasedir().
Here is a patch which fix our needs.
Hope this patch will be apply soon, I would really like to use your mojo :)
Thanks for your work.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MJARSIGNER-19) Make mojo code reusable from
another mojo + customize the working directory.
Posted by "Benjamin Bentmann (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MJARSIGNER-19?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=279174#comment-279174 ]
Benjamin Bentmann commented on MJARSIGNER-19:
---------------------------------------------
Look at the maven-filtering or maven-invoker components as examples of shared functionality.
As for the subclassing approach, see http://en.wikipedia.org/wiki/Composition_over_inheritance as a general hint. Maintenance of the JAR Signer Plugin should be possible to have to think about plugin A, B or whoever feels like reusing JAR signing. Maven plugins are not libraries with an API contract, their only purpose is to be invoked by Maven to handle a given use case during a user's build. For instance, your patch adds a new parameter to configure the working directory to the plugin which seems to have no real value in the context of the JAR signer plugin, i.e. pollutes the JAR signer plugin's user interface with external requirements.
> Make mojo code reusable from another mojo + customize the working directory.
> ----------------------------------------------------------------------------
>
> Key: MJARSIGNER-19
> URL: https://jira.codehaus.org/browse/MJARSIGNER-19
> Project: Maven 2.x Jar Signer Plugin
> Issue Type: Improvement
> Affects Versions: 1.2
> Reporter: Tony Chemit
> Priority: Trivial
> Attachments: MJARSIGNER-19.patch
>
>
> In the webstart-maven-plugin We used the old jarsigner mojo (from the jar plugin).
> We'd like to use now this plugin as the mojo from the jar plugin is deprecated for this one (see MWEBSTART-149)
> Moreover, we want to use yet another working directory and at the moment in the mojo this is hardcoed to project.getBasedir().
> Here is a patch which fix our needs.
> Hope this patch will be apply soon, I would really like to use your mojo :)
> Thanks for your work.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MJARSIGNER-19) Make mojo code reusable from
another mojo + customize the working directory.
Posted by "Benjamin Bentmann (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MJARSIGNER-19?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=280843#comment-280843 ]
Benjamin Bentmann commented on MJARSIGNER-19:
---------------------------------------------
That's heading in the right direction. Coupling the JAR signer component API to plexus-utils might not be ideal but that's something the eventual committer can decide. At any rate, the patch is a significant change and unless you have already a CLA with Apache on file, you likely want to read http://www.apache.org/licenses/#clas.
> Make mojo code reusable from another mojo + customize the working directory.
> ----------------------------------------------------------------------------
>
> Key: MJARSIGNER-19
> URL: https://jira.codehaus.org/browse/MJARSIGNER-19
> Project: Maven 2.x Jar Signer Plugin
> Issue Type: Improvement
> Affects Versions: 1.2
> Reporter: Tony Chemit
> Priority: Trivial
> Attachments: create-jarsigner-sharedcomponent.diff, MJARSIGNER-19.patch
>
>
> In the webstart-maven-plugin We used the old jarsigner mojo (from the jar plugin).
> We'd like to use now this plugin as the mojo from the jar plugin is deprecated for this one (see MWEBSTART-149)
> Moreover, we want to use yet another working directory and at the moment in the mojo this is hardcoed to project.getBasedir().
> Here is a patch which fix our needs.
> Hope this patch will be apply soon, I would really like to use your mojo :)
> Thanks for your work.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MJARSIGNER-19) Make mojo code reusable from
another mojo + customize the working directory.
Posted by "Tony Chemit (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MJARSIGNER-19?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=280955#comment-280955 ]
Tony Chemit commented on MJARSIGNER-19:
---------------------------------------
CLA registred.
> Make mojo code reusable from another mojo + customize the working directory.
> ----------------------------------------------------------------------------
>
> Key: MJARSIGNER-19
> URL: https://jira.codehaus.org/browse/MJARSIGNER-19
> Project: Maven 2.x Jar Signer Plugin
> Issue Type: Improvement
> Affects Versions: 1.2
> Reporter: Tony Chemit
> Priority: Trivial
> Attachments: create-jarsigner-sharedcomponent.diff, MJARSIGNER-19.patch
>
>
> In the webstart-maven-plugin We used the old jarsigner mojo (from the jar plugin).
> We'd like to use now this plugin as the mojo from the jar plugin is deprecated for this one (see MWEBSTART-149)
> Moreover, we want to use yet another working directory and at the moment in the mojo this is hardcoed to project.getBasedir().
> Here is a patch which fix our needs.
> Hope this patch will be apply soon, I would really like to use your mojo :)
> Thanks for your work.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MJARSIGNER-19) Make mojo code reusable from
another mojo + customize the working directory.
Posted by "Christian Schulte (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MJARSIGNER-19?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=281460#comment-281460 ]
Christian Schulte commented on MJARSIGNER-19:
---------------------------------------------
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6870812
http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0d7c64c023c6
Method 'JarSignerUtil.isSignatureFile( String entryName )' may need to also account for files ending in '.EC'.
> Make mojo code reusable from another mojo + customize the working directory.
> ----------------------------------------------------------------------------
>
> Key: MJARSIGNER-19
> URL: https://jira.codehaus.org/browse/MJARSIGNER-19
> Project: Maven 2.x Jar Signer Plugin
> Issue Type: Improvement
> Affects Versions: 1.2
> Reporter: Tony Chemit
> Priority: Trivial
> Attachments: create-jarsigner-sharedcomponent.diff, MJARSIGNER-19.patch
>
>
> In the webstart-maven-plugin We used the old jarsigner mojo (from the jar plugin).
> We'd like to use now this plugin as the mojo from the jar plugin is deprecated for this one (see MWEBSTART-149)
> Moreover, we want to use yet another working directory and at the moment in the mojo this is hardcoed to project.getBasedir().
> Here is a patch which fix our needs.
> Hope this patch will be apply soon, I would really like to use your mojo :)
> Thanks for your work.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MJARSIGNER-19) Make mojo code reusable from
another mojo + customize the working directory.
Posted by "Olivier Lamy (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MJARSIGNER-19?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=282323#comment-282323 ]
Olivier Lamy commented on MJARSIGNER-19:
----------------------------------------
code imported in r1190297.
I leave it open as I prefer to have a real external component located in : http://svn.apache.org/repos/asf/maven/shared/trunk/ maven-jarsigner in order to have release cycle different from the plugin.
> Make mojo code reusable from another mojo + customize the working directory.
> ----------------------------------------------------------------------------
>
> Key: MJARSIGNER-19
> URL: https://jira.codehaus.org/browse/MJARSIGNER-19
> Project: Maven 2.x Jar Signer Plugin
> Issue Type: Improvement
> Affects Versions: 1.2
> Reporter: Tony Chemit
> Priority: Trivial
> Attachments: create-jarsigner-sharedcomponent.diff, MJARSIGNER-19.patch
>
>
> In the webstart-maven-plugin We used the old jarsigner mojo (from the jar plugin).
> We'd like to use now this plugin as the mojo from the jar plugin is deprecated for this one (see MWEBSTART-149)
> Moreover, we want to use yet another working directory and at the moment in the mojo this is hardcoed to project.getBasedir().
> Here is a patch which fix our needs.
> Hope this patch will be apply soon, I would really like to use your mojo :)
> Thanks for your work.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Issue Comment Edited: (MJARSIGNER-19) Make mojo code
reusable from another mojo + customize the working directory.
Posted by "Benjamin Bentmann (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MJARSIGNER-19?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=279174#comment-279174 ]
Benjamin Bentmann edited comment on MJARSIGNER-19 at 9/16/11 7:44 AM:
----------------------------------------------------------------------
Look at the maven-filtering or maven-invoker components as examples of shared functionality.
As for the subclassing approach, see http://en.wikipedia.org/wiki/Composition_over_inheritance as a general hint. Maintenance of the JAR Signer Plugin should be possible without having to think about plugin A, B or whoever feels like reusing JAR signing. Maven plugins are not libraries with an API contract, their only purpose is to be invoked by Maven to handle a given use case during a user's build. For instance, your patch adds a new parameter to configure the working directory to the plugin which seems to have no real value in the context of the JAR signer plugin, i.e. pollutes the JAR signer plugin's user interface with external requirements.
was (Author: bentmann):
Look at the maven-filtering or maven-invoker components as examples of shared functionality.
As for the subclassing approach, see http://en.wikipedia.org/wiki/Composition_over_inheritance as a general hint. Maintenance of the JAR Signer Plugin should be possible to have to think about plugin A, B or whoever feels like reusing JAR signing. Maven plugins are not libraries with an API contract, their only purpose is to be invoked by Maven to handle a given use case during a user's build. For instance, your patch adds a new parameter to configure the working directory to the plugin which seems to have no real value in the context of the JAR signer plugin, i.e. pollutes the JAR signer plugin's user interface with external requirements.
> Make mojo code reusable from another mojo + customize the working directory.
> ----------------------------------------------------------------------------
>
> Key: MJARSIGNER-19
> URL: https://jira.codehaus.org/browse/MJARSIGNER-19
> Project: Maven 2.x Jar Signer Plugin
> Issue Type: Improvement
> Affects Versions: 1.2
> Reporter: Tony Chemit
> Priority: Trivial
> Attachments: MJARSIGNER-19.patch
>
>
> In the webstart-maven-plugin We used the old jarsigner mojo (from the jar plugin).
> We'd like to use now this plugin as the mojo from the jar plugin is deprecated for this one (see MWEBSTART-149)
> Moreover, we want to use yet another working directory and at the moment in the mojo this is hardcoed to project.getBasedir().
> Here is a patch which fix our needs.
> Hope this patch will be apply soon, I would really like to use your mojo :)
> Thanks for your work.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MJARSIGNER-19) Make mojo code reusable from
another mojo + customize the working directory.
Posted by "Tony Chemit (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MJARSIGNER-19?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tony Chemit updated MJARSIGNER-19:
----------------------------------
Attachment: create-jarsigner-sharedcomponent.diff
> Make mojo code reusable from another mojo + customize the working directory.
> ----------------------------------------------------------------------------
>
> Key: MJARSIGNER-19
> URL: https://jira.codehaus.org/browse/MJARSIGNER-19
> Project: Maven 2.x Jar Signer Plugin
> Issue Type: Improvement
> Affects Versions: 1.2
> Reporter: Tony Chemit
> Priority: Trivial
> Attachments: create-jarsigner-sharedcomponent.diff, MJARSIGNER-19.patch
>
>
> In the webstart-maven-plugin We used the old jarsigner mojo (from the jar plugin).
> We'd like to use now this plugin as the mojo from the jar plugin is deprecated for this one (see MWEBSTART-149)
> Moreover, we want to use yet another working directory and at the moment in the mojo this is hardcoed to project.getBasedir().
> Here is a patch which fix our needs.
> Hope this patch will be apply soon, I would really like to use your mojo :)
> Thanks for your work.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MJARSIGNER-19) Make mojo code reusable from
another mojo + customize the working directory.
Posted by "Tony Chemit (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MJARSIGNER-19?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tony Chemit updated MJARSIGNER-19:
----------------------------------
Attachment: MJARSIGNER-19.patch
> Make mojo code reusable from another mojo + customize the working directory.
> ----------------------------------------------------------------------------
>
> Key: MJARSIGNER-19
> URL: https://jira.codehaus.org/browse/MJARSIGNER-19
> Project: Maven 2.x Jar Signer Plugin
> Issue Type: Improvement
> Affects Versions: 1.2
> Reporter: Tony Chemit
> Priority: Trivial
> Attachments: MJARSIGNER-19.patch
>
>
> In the webstart-maven-plugin We used the old jarsigner mojo (from the jar plugin).
> We'd like to use now this plugin as the mojo from the jar plugin is deprecated for this one (see MWEBSTART-149)
> Moreover, we want to use yet another working directory and at the moment in the mojo this is hardcoed to project.getBasedir().
> Here is a patch which fix our needs.
> Hope this patch will be apply soon, I would really like to use your mojo :)
> Thanks for your work.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MJARSIGNER-19) Make mojo code reusable from
another mojo + customize the working directory.
Posted by "Tony Chemit (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MJARSIGNER-19?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=282328#comment-282328 ]
Tony Chemit commented on MJARSIGNER-19:
---------------------------------------
Olivier is the Guy ;) Thanks.
> Make mojo code reusable from another mojo + customize the working directory.
> ----------------------------------------------------------------------------
>
> Key: MJARSIGNER-19
> URL: https://jira.codehaus.org/browse/MJARSIGNER-19
> Project: Maven 2.x Jar Signer Plugin
> Issue Type: Improvement
> Affects Versions: 1.2
> Reporter: Tony Chemit
> Assignee: Olivier Lamy
> Priority: Trivial
> Fix For: 1.2
>
> Attachments: create-jarsigner-sharedcomponent.diff, MJARSIGNER-19.patch
>
>
> In the webstart-maven-plugin We used the old jarsigner mojo (from the jar plugin).
> We'd like to use now this plugin as the mojo from the jar plugin is deprecated for this one (see MWEBSTART-149)
> Moreover, we want to use yet another working directory and at the moment in the mojo this is hardcoed to project.getBasedir().
> Here is a patch which fix our needs.
> Hope this patch will be apply soon, I would really like to use your mojo :)
> Thanks for your work.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MJARSIGNER-19) Make mojo code reusable from
another mojo + customize the working directory.
Posted by "Christian Schulte (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MJARSIGNER-19?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=281418#comment-281418 ]
Christian Schulte commented on MJARSIGNER-19:
---------------------------------------------
Just a quick note regarding MJARSIGNER-9. Will it be possible to extend the shared component to support toolchains ? Haven't looked at it that closely.
> Make mojo code reusable from another mojo + customize the working directory.
> ----------------------------------------------------------------------------
>
> Key: MJARSIGNER-19
> URL: https://jira.codehaus.org/browse/MJARSIGNER-19
> Project: Maven 2.x Jar Signer Plugin
> Issue Type: Improvement
> Affects Versions: 1.2
> Reporter: Tony Chemit
> Priority: Trivial
> Attachments: create-jarsigner-sharedcomponent.diff, MJARSIGNER-19.patch
>
>
> In the webstart-maven-plugin We used the old jarsigner mojo (from the jar plugin).
> We'd like to use now this plugin as the mojo from the jar plugin is deprecated for this one (see MWEBSTART-149)
> Moreover, we want to use yet another working directory and at the moment in the mojo this is hardcoed to project.getBasedir().
> Here is a patch which fix our needs.
> Hope this patch will be apply soon, I would really like to use your mojo :)
> Thanks for your work.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MJARSIGNER-19) Make mojo code reusable from
another mojo + customize the working directory.
Posted by "Tony Chemit (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MJARSIGNER-19?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=280836#comment-280836 ]
Tony Chemit commented on MJARSIGNER-19:
---------------------------------------
Ok Benjamin,
I just submitted a new patch with the shared component.
Could you have a look at it, everythin works fine except for the log I think since the Commandline object should no more be exposed into the mojo ?
I used a lot the design of the share invoker component.
If everything is ok, do you want me to do anything else (create new issues for example ?).
Hopes it helps.
> Make mojo code reusable from another mojo + customize the working directory.
> ----------------------------------------------------------------------------
>
> Key: MJARSIGNER-19
> URL: https://jira.codehaus.org/browse/MJARSIGNER-19
> Project: Maven 2.x Jar Signer Plugin
> Issue Type: Improvement
> Affects Versions: 1.2
> Reporter: Tony Chemit
> Priority: Trivial
> Attachments: create-jarsigner-sharedcomponent.diff, MJARSIGNER-19.patch
>
>
> In the webstart-maven-plugin We used the old jarsigner mojo (from the jar plugin).
> We'd like to use now this plugin as the mojo from the jar plugin is deprecated for this one (see MWEBSTART-149)
> Moreover, we want to use yet another working directory and at the moment in the mojo this is hardcoed to project.getBasedir().
> Here is a patch which fix our needs.
> Hope this patch will be apply soon, I would really like to use your mojo :)
> Thanks for your work.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MJARSIGNER-19) Make mojo code reusable from
another mojo + customize the working directory.
Posted by "Christian Schulte (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MJARSIGNER-19?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=281459#comment-281459 ]
Christian Schulte commented on MJARSIGNER-19:
---------------------------------------------
Due to MJARSIGNER-18, class JarSignerUtil may need to provide an 'isSigned( java.io.File jar )' method which scans an archive for any signature files to exist.
> Make mojo code reusable from another mojo + customize the working directory.
> ----------------------------------------------------------------------------
>
> Key: MJARSIGNER-19
> URL: https://jira.codehaus.org/browse/MJARSIGNER-19
> Project: Maven 2.x Jar Signer Plugin
> Issue Type: Improvement
> Affects Versions: 1.2
> Reporter: Tony Chemit
> Priority: Trivial
> Attachments: create-jarsigner-sharedcomponent.diff, MJARSIGNER-19.patch
>
>
> In the webstart-maven-plugin We used the old jarsigner mojo (from the jar plugin).
> We'd like to use now this plugin as the mojo from the jar plugin is deprecated for this one (see MWEBSTART-149)
> Moreover, we want to use yet another working directory and at the moment in the mojo this is hardcoed to project.getBasedir().
> Here is a patch which fix our needs.
> Hope this patch will be apply soon, I would really like to use your mojo :)
> Thanks for your work.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MJARSIGNER-19) Make mojo code reusable from
another mojo + customize the working directory.
Posted by "Tony Chemit (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MJARSIGNER-19?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=279170#comment-279170 ]
Tony Chemit commented on MJARSIGNER-19:
---------------------------------------
Benjamin, do you have an example of a such shared component (using a system command-line)?
I could prepare the code then give you the patch to create the shared component. I really like to move forward on the webstart plugin, so I am ready to help activly.
Could you also briefly explain me why subclassing mojos is bad?
Thanks
> Make mojo code reusable from another mojo + customize the working directory.
> ----------------------------------------------------------------------------
>
> Key: MJARSIGNER-19
> URL: https://jira.codehaus.org/browse/MJARSIGNER-19
> Project: Maven 2.x Jar Signer Plugin
> Issue Type: Improvement
> Affects Versions: 1.2
> Reporter: Tony Chemit
> Priority: Trivial
> Attachments: MJARSIGNER-19.patch
>
>
> In the webstart-maven-plugin We used the old jarsigner mojo (from the jar plugin).
> We'd like to use now this plugin as the mojo from the jar plugin is deprecated for this one (see MWEBSTART-149)
> Moreover, we want to use yet another working directory and at the moment in the mojo this is hardcoed to project.getBasedir().
> Here is a patch which fix our needs.
> Hope this patch will be apply soon, I would really like to use your mojo :)
> Thanks for your work.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MJARSIGNER-19) Make mojo code reusable from
another mojo + customize the working directory.
Posted by "Benjamin Bentmann (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MJARSIGNER-19?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=279159#comment-279159 ]
Benjamin Bentmann commented on MJARSIGNER-19:
---------------------------------------------
The proper way to reuse this functionality is to extract the desired code into a shared component which both mojos than use. Subclassing mojos is an anti-pattern.
> Make mojo code reusable from another mojo + customize the working directory.
> ----------------------------------------------------------------------------
>
> Key: MJARSIGNER-19
> URL: https://jira.codehaus.org/browse/MJARSIGNER-19
> Project: Maven 2.x Jar Signer Plugin
> Issue Type: Improvement
> Affects Versions: 1.2
> Reporter: Tony Chemit
> Priority: Trivial
> Attachments: MJARSIGNER-19.patch
>
>
> In the webstart-maven-plugin We used the old jarsigner mojo (from the jar plugin).
> We'd like to use now this plugin as the mojo from the jar plugin is deprecated for this one (see MWEBSTART-149)
> Moreover, we want to use yet another working directory and at the moment in the mojo this is hardcoed to project.getBasedir().
> Here is a patch which fix our needs.
> Hope this patch will be apply soon, I would really like to use your mojo :)
> Thanks for your work.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MJARSIGNER-19) Make mojo code reusable from another
mojo + customize the working directory.
Posted by "Olivier Lamy (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MJARSIGNER-19?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Olivier Lamy closed MJARSIGNER-19.
----------------------------------
Resolution: Fixed
Fix Version/s: 1.2
Assignee: Olivier Lamy
so all done.
Have fun :-)
> Make mojo code reusable from another mojo + customize the working directory.
> ----------------------------------------------------------------------------
>
> Key: MJARSIGNER-19
> URL: https://jira.codehaus.org/browse/MJARSIGNER-19
> Project: Maven 2.x Jar Signer Plugin
> Issue Type: Improvement
> Affects Versions: 1.2
> Reporter: Tony Chemit
> Assignee: Olivier Lamy
> Priority: Trivial
> Fix For: 1.2
>
> Attachments: create-jarsigner-sharedcomponent.diff, MJARSIGNER-19.patch
>
>
> In the webstart-maven-plugin We used the old jarsigner mojo (from the jar plugin).
> We'd like to use now this plugin as the mojo from the jar plugin is deprecated for this one (see MWEBSTART-149)
> Moreover, we want to use yet another working directory and at the moment in the mojo this is hardcoed to project.getBasedir().
> Here is a patch which fix our needs.
> Hope this patch will be apply soon, I would really like to use your mojo :)
> Thanks for your work.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira