You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@linkis.apache.org by GitBox <gi...@apache.org> on 2022/02/14 10:41:39 UTC
[GitHub] [incubator-linkis] det101 opened a new pull request #1456: add linkis datasource web
det101 opened a new pull request #1456:
URL: https://github.com/apache/incubator-linkis/pull/1456
### What is the purpose of the change
DataSource web module is the front-end display of the data source module, which is used by the user to manage and view the data source on the interface. #912
### Brief change log
- The newly added data source configuration does not need to modify the front-end code, only requires the back-end configuration, and supports conventional front-end components.
### Verifying this change
Linkis Computing Management Desk->Data Source Management
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For additional commands, e-mail: commits-help@linkis.apache.org
[GitHub] [incubator-linkis] peacewong commented on a change in pull request #1456: add linkis datasource web
Posted by GitBox <gi...@apache.org>.
peacewong commented on a change in pull request #1456:
URL: https://github.com/apache/incubator-linkis/pull/1456#discussion_r805719635
##########
File path: web/src/apps/linkis/module/datasource/dataSourceApi.js
##########
@@ -0,0 +1,167 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import api from '@/common/service/api';
+import { serialize } from 'object-to-formdata';
+
+/**
+ * 获取数据源列表
Review comment:
English is recommended
##########
File path: web/package.json
##########
@@ -23,6 +23,7 @@
]
},
"dependencies": {
+ "@form-create/iview": "^2.5.13",
Review comment:
need to add license and notice
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For additional commands, e-mail: commits-help@linkis.apache.org
[GitHub] [incubator-linkis] det101 commented on a change in pull request #1456: add linkis datasource web
Posted by GitBox <gi...@apache.org>.
det101 commented on a change in pull request #1456:
URL: https://github.com/apache/incubator-linkis/pull/1456#discussion_r805746947
##########
File path: web/src/apps/linkis/module/datasource/dataSourceApi.js
##########
@@ -0,0 +1,167 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import api from '@/common/service/api';
+import { serialize } from 'object-to-formdata';
+
+/**
+ * 获取数据源列表
Review comment:
fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For additional commands, e-mail: commits-help@linkis.apache.org
[GitHub] [incubator-linkis] peacewong merged pull request #1456: add linkis datasource web
Posted by GitBox <gi...@apache.org>.
peacewong merged pull request #1456:
URL: https://github.com/apache/incubator-linkis/pull/1456
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For additional commands, e-mail: commits-help@linkis.apache.org
[GitHub] [incubator-linkis] det101 commented on a change in pull request #1456: add linkis datasource web
Posted by GitBox <gi...@apache.org>.
det101 commented on a change in pull request #1456:
URL: https://github.com/apache/incubator-linkis/pull/1456#discussion_r805743827
##########
File path: web/package.json
##########
@@ -23,6 +23,7 @@
]
},
"dependencies": {
+ "@form-create/iview": "^2.5.13",
Review comment:
package.json can not super annotation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For additional commands, e-mail: commits-help@linkis.apache.org
[GitHub] [incubator-linkis] casionone commented on pull request #1456: add linkis datasource web
Posted by GitBox <gi...@apache.org>.
casionone commented on pull request #1456:
URL: https://github.com/apache/incubator-linkis/pull/1456#issuecomment-1039077128
LGTM.
In the left menu bar, is it more reasonable to put DataSource Management before the FAQ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For additional commands, e-mail: commits-help@linkis.apache.org
[GitHub] [incubator-linkis] peacewong merged pull request #1456: add linkis datasource web
Posted by GitBox <gi...@apache.org>.
peacewong merged pull request #1456:
URL: https://github.com/apache/incubator-linkis/pull/1456
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For additional commands, e-mail: commits-help@linkis.apache.org