[jira] [Commented] (YARN-5388) MAPREDUCE-6719 requires changes to DockerContainerExecutor

["Karthik Kambatla (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-5388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15546941#comment-15546941 ] 

Karthik Kambatla commented on YARN-5388:
----------------------------------------

+1 for the trunk patch. [~sidharta-s], [~vvasudev] - would really appreciate a quick nod from you too. 

branch-2 patch: Shouldn't the deprecation be a java annotation as below instead of being part of the javadoc the current patch has? Also, we should add more details on the reasons for deprecation and suggest alternatives. 
{code}
@Deprecated
public class DockerContainerExecutor extends ContainerExecutor {
{code}

> MAPREDUCE-6719 requires changes to DockerContainerExecutor
> ----------------------------------------------------------
>
>                 Key: YARN-5388
>                 URL: https://issues.apache.org/jira/browse/YARN-5388
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: nodemanager
>            Reporter: Daniel Templeton
>            Assignee: Daniel Templeton
>            Priority: Critical
>             Fix For: 2.9.0
>
>         Attachments: YARN-5388.001.patch, YARN-5388.002.patch, YARN-5388.branch-2.001.patch
>
>
> Because the {{DockerContainerExecuter}} overrides the {{writeLaunchEnv()}} method, it must also have the wildcard processing logic from YARN-4958/YARN-5373 added to it.  Without it, the use of -libjars will fail unless wildcarding is disabled.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org