You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by YolandaMDavis <gi...@git.apache.org> on 2016/07/19 00:15:10 UTC

[GitHub] nifi pull request #674: NIFI-2310 - Shiftr Transform in JoltTransformJSON Pr...

GitHub user YolandaMDavis opened a pull request:

    https://github.com/apache/nifi/pull/674

    NIFI-2310 - Shiftr Transform in JoltTransformJSON Processor Does Not Support Escaping Special Characters

    upgrade Jolt version to 0.0.21 which resolved issue.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/YolandaMDavis/nifi NIFI-2310

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/674.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #674
    
----
commit 861f728927628da2f5d8245f0d2c5ba259617ab1
Author: Yolanda M. Davis <yo...@gmail.com>
Date:   2016-07-19T00:09:09Z

    NIFI-2310 - upgraded jolt to 0.0.21 to resolve special character issue

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #674: NIFI-2310 - Shiftr Transform in JoltTransformJSON Processor...

Posted by ijokarumawak <gi...@git.apache.org>.
Github user ijokarumawak commented on the issue:

    https://github.com/apache/nifi/pull/674
  
    Merged this commit to branch 0.x, too. Confirmed the sample Jolt spec with escape characters is validated and transformed successfully.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #674: NIFI-2310 - Shiftr Transform in JoltTransformJSON Processor...

Posted by ijokarumawak <gi...@git.apache.org>.
Github user ijokarumawak commented on the issue:

    https://github.com/apache/nifi/pull/674
  
    +1
    
    I reproduced the validation error before applying this fix using the sample input and spec you shared, and confirmed that it's valid with this fix. Run a NiFi data-flow to transform Json using Jolt processor. It worked without problem.
    Passed local contrib check successfully.
    
    I will merge it in master branch.
    Also I am going to test this with 0.x branch.
    
    Thanks @YolandaMDavis !


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #674: NIFI-2310 - Shiftr Transform in JoltTransformJSON Pr...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/nifi/pull/674


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #674: NIFI-2310 - Shiftr Transform in JoltTransformJSON Processor...

Posted by YolandaMDavis <gi...@git.apache.org>.
Github user YolandaMDavis commented on the issue:

    https://github.com/apache/nifi/pull/674
  
    Here is the error that occurred before this fix <img width="1397" alt="shiftrparseerror" src="https://cloud.githubusercontent.com/assets/1371858/16953212/3b7b93e0-4d9a-11e6-879d-080c9ec9ed89.png">
    
    To test use the following specification for Shiftr ensure that spec is valid:
    
    `{
          "\\@context": {
            "name": "&1.Name",
            "ingredient": "&1.Inputs",
            "yield": "\\@context.Makes",
            "*": "&1.&"
          },
          "name": "Name",
          "ingredient": "Inputs",
          "yield": "Makes",
          "*": "&"
        }
     `
    
    Also the below test input can be used in the Advance (from http://jolt-demo.appspot.com/#json-ld-escaping)
    
    `{
      "comment" : "pulled from http://json-ld.org/playground/ example recipe.  Also, Mojitos are good.",
    
      "@context": {
        "name": "http://rdf.data-vocabulary.org/#name",
        "ingredient": "http://rdf.data-vocabulary.org/#ingredients",
        "yield": "http://rdf.data-vocabulary.org/#yield",
        "instructions": "http://rdf.data-vocabulary.org/#instructions",
        "step": {
          "@id": "http://rdf.data-vocabulary.org/#step",
          "@type": "xsd:integer"
        },
        "description": "http://rdf.data-vocabulary.org/#description",
        "xsd": "http://www.w3.org/2001/XMLSchema#"
      },
      "name": "Mojito",
      "ingredient": [
        "12 fresh mint leaves",
        "1/2 lime, juiced with pulp",
        "1 tablespoons white sugar",
        "1 cup ice cubes",
        "2 fluid ounces white rum",
        "1/2 cup club soda"
      ],
      "yield": "1 cocktail",
      "instructions": [
        {
          "step": 1,
          "description": "Crush lime juice, mint and sugar together in glass."
        },
        {
          "step": 2,
          "description": "Fill glass to top with ice cubes."
        },
        {
          "step": 3,
          "description": "Pour white rum over ice."
        },
        {
          "step": 4,
          "description": "Fill the rest of glass with club soda, stir."
        },
        {
          "step": 5,
          "description": "Garnish with a lime wedge."
        }
      ]
    }`



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #674: NIFI-2310 - Shiftr Transform in JoltTransformJSON Processor...

Posted by ijokarumawak <gi...@git.apache.org>.
Github user ijokarumawak commented on the issue:

    https://github.com/apache/nifi/pull/674
  
    Start reviewing...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---