[GitHub] seelmann commented on issue #2: Change the method name "select" to "isSelected".

[GitBox <gi...@apache.org>]

seelmann commented on issue #2: Change the method name "select" to "isSelected".
URL: https://github.com/apache/directory-studio/pull/2#issuecomment-383411399
 
 
   I agree that `isSelected` would be the better name. However the `select` method name is given by the super class `org.eclipse.jface.viewers.ViewerFilter` from the Eclipse framework where it is defined as abstract method. Changing it to `isSelected` in the implementation class would cause compile errors, right?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services