[jira] [Commented] (OOZIE-2181) JsonToBean has some missing and incorrect mappings

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OOZIE-2181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14372547#comment-14372547 ] 

Hadoop QA commented on OOZIE-2181:
----------------------------------

Testing JIRA OOZIE-2181

Cleaning local git workspace

----------------------------

{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.    {color:green}+1{color} the patch does not introduce any @author tags
.    {color:green}+1{color} the patch does not introduce any tabs
.    {color:green}+1{color} the patch does not introduce any trailing spaces
.    {color:green}+1{color} the patch does not introduce any line longer than 132
.    {color:green}+1{color} the patch does adds/modifies 1 testcase(s)
{color:green}+1 RAT{color}
.    {color:green}+1{color} the patch does not seem to introduce new RAT warnings
{color:green}+1 JAVADOC{color}
.    {color:green}+1{color} the patch does not seem to introduce new Javadoc warnings
{color:green}+1 COMPILE{color}
.    {color:green}+1{color} HEAD compiles
.    {color:green}+1{color} patch compiles
.    {color:green}+1{color} the patch does not seem to introduce new javac warnings
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.    {color:green}+1{color} the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations
.    {color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.    Tests run: 1630
.    Tests failed: 2
.    Tests errors: 0

.    The patch failed the following testcases:

.      testCoordRerunDateNeg(org.apache.oozie.command.coord.TestCoordRerunXCommand)
.      testBundleStatusNotTransitionFromKilled(org.apache.oozie.service.TestStatusTransitService)

{color:green}+1 DISTRO{color}
.    {color:green}+1{color} distro tarball builds with the patch 

----------------------------
{color:red}*-1 Overall result, please check the reported -1(s)*{color}


The full output of the test-patch run is available at

.   https://builds.apache.org/job/oozie-trunk-precommit-build/2266/

> JsonToBean has some missing and incorrect mappings
> --------------------------------------------------
>
>                 Key: OOZIE-2181
>                 URL: https://issues.apache.org/jira/browse/OOZIE-2181
>             Project: Oozie
>          Issue Type: Bug
>          Components: client
>            Reporter: Robert Kanter
>            Assignee: Robert Kanter
>         Attachments: OOZIE-2181.patch
>
>
> {{JsonToBean}} has code to map from Bundle Job, Coordinator Job, etc JSON into the associated {{BundleJob}}, {{CoordinatorJob}}, etc classes.  
> If a mapping is missing, and you try to call a getter, the code will compile but you'll get a {{RuntimeException}}.  For example; the mapping for {{BundleJob.getAcl()}} is missing.  Specifically, when you use this code:
> {code:java}
> BundleJob job = client.getBundleJobInfo(jobId);
> String acl = job.getAcl();
> {code}
> you get this exception:
> {noformat}
> Exception in thread "main" java.lang.RuntimeException: Undefined method mapping: getAcl
> 	at org.apache.oozie.client.rest.JsonToBean$JsonInvocationHandler.invoke(JsonToBean.java:217)
> 	at com.sun.proxy.$Proxy4.getAcl(Unknown Source)
>         ...
> {noformat}
> There are a few inconsistencies including extra mappings, missing mappings, and missing information from the server.
> We should:
> # Fix these inconsistencies.
> # Write tests to prevent this sort of thing from happening in the future.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)