You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hawq.apache.org by zhangh43 <gi...@git.apache.org> on 2015/12/22 02:03:15 UTC
[GitHub] incubator-hawq pull request: HAWQ-269. Change net_disk_ratio from ...
GitHub user zhangh43 opened a pull request:
https://github.com/apache/incubator-hawq/pull/207
HAWQ-269. Change net_disk_ratio from int to double type.
net_disk_ratio is the punishment factor of the size of remote read compared with local read.
we need to set it to be double type.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zhangh43/incubator-hawq hawq269
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/207.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #207
----
commit 9550f54ec822539adfe5c72b8beeab46035dd3ca
Author: hubertzhang <hz...@pivotal.io>
Date: 2015-12-22T01:00:55Z
HAWQ-269. Change net_disk_ratio from int to double type.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-269. Change net_disk_ratio from ...
Posted by huor <gi...@git.apache.org>.
Github user huor commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/207#discussion_r48213492
--- Diff: src/backend/utils/misc/guc.c ---
@@ -720,7 +720,7 @@ int optimizer_log_failure;
double optimizer_cost_threshold;
double optimizer_nestloop_factor;
double locality_upper_bound;
-int net_disk_ratio;
+double net_disk_ratio;
--- End diff --
The indentation needs be followed here
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-269. Change net_disk_ratio from ...
Posted by zhangh43 <gi...@git.apache.org>.
Github user zhangh43 commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/207#discussion_r48213610
--- Diff: src/backend/utils/misc/guc.c ---
@@ -720,7 +720,7 @@ int optimizer_log_failure;
double optimizer_cost_threshold;
double optimizer_nestloop_factor;
double locality_upper_bound;
-int net_disk_ratio;
+double net_disk_ratio;
--- End diff --
I'll change it, Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-269. Change net_disk_ratio from ...
Posted by huor <gi...@git.apache.org>.
Github user huor commented on the pull request:
https://github.com/apache/incubator-hawq/pull/207#issuecomment-166474427
The overall fix looks good. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-269. Change net_disk_ratio from ...
Posted by wengyanqing <gi...@git.apache.org>.
Github user wengyanqing commented on the pull request:
https://github.com/apache/incubator-hawq/pull/207#issuecomment-166474294
looks good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-269. Change net_disk_ratio from ...
Posted by yaoj2 <gi...@git.apache.org>.
Github user yaoj2 commented on the pull request:
https://github.com/apache/incubator-hawq/pull/207#issuecomment-166470629
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-269. Change net_disk_ratio from ...
Posted by zhangh43 <gi...@git.apache.org>.
Github user zhangh43 closed the pull request at:
https://github.com/apache/incubator-hawq/pull/207
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-269. Change net_disk_ratio from ...
Posted by huor <gi...@git.apache.org>.
Github user huor commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/207#discussion_r48213507
--- Diff: src/backend/utils/misc/guc.c ---
@@ -6857,6 +6846,15 @@ static struct config_real ConfigureNamesReal[] =
&locality_upper_bound,
1.2, 1.0, 2.0, NULL, NULL
},
+ {
+ {"net_disk_ratio", PGC_USERSET, DEVELOPER_OPTIONS,
+ gettext_noop("set the scan volumn ratio of disk against network."),
--- End diff --
"Sets the scan ..."
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---