You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "liuyongvs (via GitHub)" <gi...@apache.org> on 2024/03/07 03:37:55 UTC

[PR] [FLINK-34604][table] Migrate BatchPhysicalCalcRule to java. [flink]

liuyongvs opened a new pull request, #24452:
URL: https://github.com/apache/flink/pull/24452

   ## What is the purpose of the change
   
   A bit reasoning for the change
   
   The reason is that since 1.28.0 ( [CALCITE-4787](https://issues.apache.org/jira/browse/CALCITE-4787) - Move core to use Immutables instead of ImmutableBeans ) Calcite started to use Immutables (https://immutables.github.io/) and since 1.29.0 removed ImmutableBeans ( [CALCITE-4839](https://issues.apache.org/jira/browse/CALCITE-4839) - Remove remnants of ImmutableBeans post 1.28 release ). All rule configuration related api which is not Immutables based is marked as deprecated. Since Immutables implies code generation while java compilation it is seems impossible to use for rules in Scala code.
   
   The PR migrates BatchPhysicalCalcRule to java
   
   ## Verifying this change
   
   This change is already covered by existing tests
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-34604][table] Migrate BatchPhysicalCalcRule to java. [flink]

Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on PR #24452:
URL: https://github.com/apache/flink/pull/24452#issuecomment-1982516141

   I'm going to cloase all PRs trying to migrate `ConverterRule` except https://github.com/apache/flink/pull/24457
   since 
   1. there is still no response on my questsion and they keep appearing
   2. We don't need to migrate `ConverterRule`'s


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-34604][table] Migrate BatchPhysicalCalcRule to java. [flink]

Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin closed pull request #24452: [FLINK-34604][table] Migrate BatchPhysicalCalcRule to java.
URL: https://github.com/apache/flink/pull/24452


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-34604][table] Migrate BatchPhysicalCalcRule to java. [flink]

Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #24452:
URL: https://github.com/apache/flink/pull/24452#issuecomment-1982295668

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b9d86645c8237e8cd28a15ca9fe3a3a7b53aa81a",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "b9d86645c8237e8cd28a15ca9fe3a3a7b53aa81a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * b9d86645c8237e8cd28a15ca9fe3a3a7b53aa81a UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org