You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "mureinik (via GitHub)" <gi...@apache.org> on 2023/10/01 09:18:35 UTC
[GitHub] [rocketmq] mureinik opened a new pull request, #7419: Fix unstable UtilAllTest#testCalculateFileSizeInPath on Windows
mureinik opened a new pull request, #7419:
URL: https://github.com/apache/rocketmq/pull/7419
### Which Issue(s) This PR Fixes
<!-- Please ensure that the related issue has already been created, and [link this pull request to that issue using keywords](<https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword>) to ensure automatic closure. -->
Fixes #7418
### Brief Description
On my Windows laptop, `UtilAllTest#testCalculateFileSizeInPath` is unstable, presumably due to leftovers from previous runs that were not properly cleanup up.
Converting the test to use a proper TemporaryFolder @Rule like other tests that rely on the filesystem instead of trying to implement the cleanup logic in the test itself seems to solve this.
### How Did You Test This Change?
Running `mvn install` passes now, as well as running this test manually from IntelliJ
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix unstable UtilAllTest#testCalculateFileSizeInPath on Windows [rocketmq]
Posted by "mureinik (via GitHub)" <gi...@apache.org>.
mureinik commented on PR #7419:
URL: https://github.com/apache/rocketmq/pull/7419#issuecomment-1742670672
@lizhimins thanks for approving this!
The code coverage test is failing, but it seems like a problem with a 3rd party, not with the MR itself:
```
[2023-10-02T08:26:29.267Z] ['info'] Pinging Codecov: https://codecov.io/upload/v4?package=github-action-3.1.4-uploader-0.6.2&token=*******&branch=UtilAllTest.testCalculateFileSizeInPath-stability&build=6369546285&build_url=https%3A%2F%2Fgithub.com%2Fapache%2Frocketmq%2Factions%2Fruns%2F6369546285%2Fjob%2F17306296116&commit=076e62b9b61916a323780b1fce66981190ae67ad&job=Coverage&pr=7419&service=github-actions&slug=apache%2Frocketmq&name=&tag=&flags=&parent=
[2023-10-02T08:26:29.267Z] ['verbose'] Passed token was 0 characters long
[2023-10-02T08:26:29.267Z] ['verbose'] https://codecov.io/upload/v4?package=github-action-3.1.4-uploader-0.6.2&branch=UtilAllTest.testCalculateFileSizeInPath-stability&build=6369546285&build_url=https%3A%2F%2Fgithub.com%2Fapache%2Frocketmq%2Factions%2Fruns%2F6369546285%2Fjob%2F17306296116&commit=076e62b9b61916a323780b1fce66981190ae67ad&job=Coverage&pr=7419&service=github-actions&slug=apache%2Frocketmq&name=&tag=&flags=&parent=
Content-Type: 'text/plain'
Content-Encoding: 'gzip'
X-Reduced-Redundancy: 'false'
[2023-10-02T08:26:29.541Z] ['error'] There was an error running the uploader: Error uploading to [https://codecov.io:](https://codecov.io/) Error: There was an error fetching the storage URL during POST: 404 - {'detail': ErrorDetail(string='Unable to locate build via Github Actions API. Please upload with the Codecov repository upload token to resolve issue.', code='not_found')}
[2023-10-02T08:26:29.541Z] ['verbose'] The error stack is: Error: Error uploading to [https://codecov.io:](https://codecov.io/) Error: There was an error fetching the storage URL during POST: 404 - {'detail': ErrorDetail(string='Unable to locate build via Github Actions API. Please upload with the Codecov repository upload token to resolve issue.', code='not_found')}
at main (/snapshot/repo/dist/src/index.js)
at processTicksAndRejections (node:internal/process/task_queues:96:5)
[2023-10-02T08:26:29.542Z] ['verbose'] End of uploader: 1417 milliseconds
Error: Codecov: Failed to properly upload: The process '/home/runner/work/_actions/codecov/codecov-action/v3/dist/codecov' failed with exit code 255
```
Can this job be re-run?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix unstable UtilAllTest#testCalculateFileSizeInPath on Windows [rocketmq]
Posted by "lizhanhui (via GitHub)" <gi...@apache.org>.
lizhanhui commented on PR #7419:
URL: https://github.com/apache/rocketmq/pull/7419#issuecomment-1803110138
@mureinik This pull request is good and shall be merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix unstable UtilAllTest#testCalculateFileSizeInPath on Windows [rocketmq]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #7419:
URL: https://github.com/apache/rocketmq/pull/7419#issuecomment-1757324401
## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/7419?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#7419](https://app.codecov.io/gh/apache/rocketmq/pull/7419?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (076e62b) into [develop](https://app.codecov.io/gh/apache/rocketmq/commit/4f1b42a7c5557bcadd6b9982a0c9bd876622c69e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (4f1b42a) will **decrease** coverage by `0.01%`.
> Report is 10 commits behind head on develop.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## develop #7419 +/- ##
=============================================
- Coverage 42.62% 42.61% -0.01%
+ Complexity 9466 9456 -10
=============================================
Files 1150 1150
Lines 82758 82758
Branches 10779 10779
=============================================
- Hits 35272 35264 -8
- Misses 43062 43071 +9
+ Partials 4424 4423 -1
```
[see 24 files with indirect coverage changes](https://app.codecov.io/gh/apache/rocketmq/pull/7419/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix unstable UtilAllTest#testCalculateFileSizeInPath on Windows [rocketmq]
Posted by "lizhanhui (via GitHub)" <gi...@apache.org>.
lizhanhui merged PR #7419:
URL: https://github.com/apache/rocketmq/pull/7419
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix unstable UtilAllTest#testCalculateFileSizeInPath on Windows [rocketmq]
Posted by "mureinik (via GitHub)" <gi...@apache.org>.
mureinik commented on PR #7419:
URL: https://github.com/apache/rocketmq/pull/7419#issuecomment-1765808449
I've rebased this PR on to of the current `develop` branch that includes #7445.
IMHO, this is a "cleaner" solution to the same problem, although #7445 already properly fixes it.
In other words, this PR does not fix any test failure anymore, but IMHO does improve the style/readability of the test.
Of course, if the maintainers disagree, I'll close it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org