[GitHub] [dolphinscheduler] JinyLeeChina commented on a diff in pull request #9980: [Fix-9921] Add the mechanism to increment the workerWaitingTaskCount in HeartBea…

[GitBox <gi...@apache.org>]

JinyLeeChina commented on code in PR #9980:
URL: https://github.com/apache/dolphinscheduler/pull/9980#discussion_r873363096


##########
dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/registry/HeartBeatTask.java:
##########
@@ -67,6 +67,15 @@ public HeartBeatTask(long startupTime,
         this.heartBeat = new HeartBeat(startupTime, maxCpuloadAvg, reservedMemory, hostWeight, workerThreadCount);
     }
 
+    public void setWorkerWaitingTaskCount(int count){
+        this.workerWaitingTaskCount  = count;
+    }
+
+    public void incrementWorkerWaitingTaskCount(){
+        this.workerWaitingTaskCount++;

Review Comment:
   I don't think this modification can solve this problem, this value is the number of tasks to be run held by the current worker, not the count of heartbeat



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org