You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "manuzhang (via GitHub)" <gi...@apache.org> on 2025/07/21 15:32:18 UTC
[PR] Docs: Move links to other implementations out of Java docs [iceberg]
manuzhang opened a new pull request, #13618:
URL: https://github.com/apache/iceberg/pull/13618
Closes #12910
<img width="2934" height="2028" alt="CleanShot 2025-07-21 at 23 24 34@2x" src="https://github.com/user-attachments/assets/14fd30ef-ae8b-4466-bff9-6649e4998231" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Docs: Move links to other implementations out of Java docs [iceberg]
Posted by "manuzhang (via GitHub)" <gi...@apache.org>.
manuzhang commented on code in PR #13618:
URL: https://github.com/apache/iceberg/pull/13618#discussion_r2227309136
##########
site/mkdocs.yml:
##########
@@ -35,6 +35,7 @@ theme:
- navigation.tabs
- navigation.tabs.sticky
- navigation.path
+ - navigation.sections
Review Comment:
Yes, such that the links to other language implementations are always visible at the top level.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Docs: Move links to other implementations out of Java docs [iceberg]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on code in PR #13618:
URL: https://github.com/apache/iceberg/pull/13618#discussion_r2227282314
##########
site/mkdocs.yml:
##########
@@ -35,6 +35,7 @@ theme:
- navigation.tabs
- navigation.tabs.sticky
- navigation.path
+ - navigation.sections
Review Comment:
what is this for?
sounds like its for rendering groups
https://squidfunk.github.io/mkdocs-material/setup/setting-up-navigation/#navigation-sections
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Docs: Move links to other implementations out of Java docs [iceberg]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on PR #13618:
URL: https://github.com/apache/iceberg/pull/13618#issuecomment-3111910372
thank for the pr @manuzhang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Docs: Move links to other implementations out of Java docs [iceberg]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu merged PR #13618:
URL: https://github.com/apache/iceberg/pull/13618
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org