You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@libcloud.apache.org by GitBox <gi...@apache.org> on 2022/05/10 21:50:52 UTC

[GitHub] [libcloud] Kami opened a new pull request, #1691: Replace 3rd party mock package with unittest.mock package from stdlib

Kami opened a new pull request, #1691:
URL: https://github.com/apache/libcloud/pull/1691

   This pull request removes the dependency on 3rd party ```mock`` package by utilizing ``unittest.mock`` package from stdlib.
   
   Since mock is just a backport for older Python versions, this is a drop in replacement without any negative side effects.
   
   Thanks to @pgajdos for reporting this.
   
   Resolves #1684.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [libcloud] codecov-commenter commented on pull request #1691: Replace 3rd party mock package with unittest.mock package from stdlib

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #1691:
URL: https://github.com/apache/libcloud/pull/1691#issuecomment-1122923767

   # [Codecov](https://codecov.io/gh/apache/libcloud/pull/1691?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1691](https://codecov.io/gh/apache/libcloud/pull/1691?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e62bb28) into [trunk](https://codecov.io/gh/apache/libcloud/commit/b9b07c7e1e49ac8f8fe37e8a1cc2f60d3748f4be?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b9b07c7) will **increase** coverage by `0.00%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/libcloud/pull/1691/graphs/tree.svg?width=650&height=150&src=pr&token=PYoduksh69&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/libcloud/pull/1691?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@           Coverage Diff           @@
   ##            trunk    #1691   +/-   ##
   =======================================
     Coverage   83.26%   83.26%           
   =======================================
     Files         400      400           
     Lines       87304    87302    -2     
     Branches     9277     9277           
   =======================================
   - Hits        72697    72696    -1     
   + Misses      11454    11453    -1     
     Partials     3153     3153           
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/libcloud/pull/1691?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...chmarks/test\_list\_objects\_filtering\_performance.py](https://codecov.io/gh/apache/libcloud/pull/1691/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvdGVzdC9iZW5jaG1hcmtzL3Rlc3RfbGlzdF9vYmplY3RzX2ZpbHRlcmluZ19wZXJmb3JtYW5jZS5weQ==) | `91.66% <ø> (ø)` | |
   | [libcloud/test/common/test\_aws.py](https://codecov.io/gh/apache/libcloud/pull/1691/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvdGVzdC9jb21tb24vdGVzdF9hd3MucHk=) | `98.21% <ø> (ø)` | |
   | [libcloud/test/common/test\_base.py](https://codecov.io/gh/apache/libcloud/pull/1691/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvdGVzdC9jb21tb24vdGVzdF9iYXNlLnB5) | `88.88% <ø> (ø)` | |
   | [libcloud/test/common/test\_base\_driver.py](https://codecov.io/gh/apache/libcloud/pull/1691/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvdGVzdC9jb21tb24vdGVzdF9iYXNlX2RyaXZlci5weQ==) | `100.00% <ø> (ø)` | |
   | [libcloud/test/common/test\_google.py](https://codecov.io/gh/apache/libcloud/pull/1691/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvdGVzdC9jb21tb24vdGVzdF9nb29nbGUucHk=) | `97.77% <ø> (ø)` | |
   | [libcloud/test/common/test\_nfsn.py](https://codecov.io/gh/apache/libcloud/pull/1691/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvdGVzdC9jb21tb24vdGVzdF9uZnNuLnB5) | `93.54% <ø> (ø)` | |
   | [libcloud/test/common/test\_openstack.py](https://codecov.io/gh/apache/libcloud/pull/1691/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvdGVzdC9jb21tb24vdGVzdF9vcGVuc3RhY2sucHk=) | `100.00% <ø> (ø)` | |
   | [libcloud/test/common/test\_openstack\_identity.py](https://codecov.io/gh/apache/libcloud/pull/1691/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvdGVzdC9jb21tb24vdGVzdF9vcGVuc3RhY2tfaWRlbnRpdHkucHk=) | `97.11% <ø> (ø)` | |
   | [libcloud/test/common/test\_retry\_limit.py](https://codecov.io/gh/apache/libcloud/pull/1691/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvdGVzdC9jb21tb24vdGVzdF9yZXRyeV9saW1pdC5weQ==) | `100.00% <ø> (ø)` | |
   | [libcloud/test/common/test\_upcloud.py](https://codecov.io/gh/apache/libcloud/pull/1691/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvdGVzdC9jb21tb24vdGVzdF91cGNsb3VkLnB5) | `100.00% <ø> (ø)` | |
   | ... and [21 more](https://codecov.io/gh/apache/libcloud/pull/1691/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/libcloud/pull/1691?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/libcloud/pull/1691?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b9b07c7...e62bb28](https://codecov.io/gh/apache/libcloud/pull/1691?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [libcloud] Kami merged pull request #1691: Replace 3rd party mock package with unittest.mock package from stdlib

Posted by GitBox <gi...@apache.org>.
Kami merged PR #1691:
URL: https://github.com/apache/libcloud/pull/1691


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org