[jira] [Commented] (OAK-4618) Align GCMonitorMBean MBean with new generation based GC

["Andrei Dulceanu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-4618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15426455#comment-15426455 ] 

Andrei Dulceanu commented on OAK-4618:
--------------------------------------

[~mduerig], since OAK-4657 handled most of the concerns raised in the issue description, I'd propose a patch in which only to get rid of the two time series, {{getRepositorySize}} and {{getReclaimedSize}}. WDYT?

> Align GCMonitorMBean MBean with new generation based GC
> -------------------------------------------------------
>
>                 Key: OAK-4618
>                 URL: https://issues.apache.org/jira/browse/OAK-4618
>             Project: Jackrabbit Oak
>          Issue Type: Task
>          Components: segment-tar
>            Reporter: Michael Dürig
>            Assignee: Andrei Dulceanu
>              Labels: production
>             Fix For: Segment Tar 0.0.12
>
>
> The {{GCMonitorMBean}} MBean still dates back to the old {{oak-segment}}. We need to review its endpoints and only keep those that make sense for {{oak-segment-tar}}, adapt the others as necessary any add further functionality as required. 
> Specifically I think we should get rid of the time series for {{getRepositorySize()}} and {{getReclaimedSize()}}.
> Also the name {{getRepositorySize()}} is confusing and we should change it. It leads callers to think it would return current size of the repository opposed to the size it had after the last cleanup. (There is {{FileStoreStatsMBean.getRepositorySize()}} for the latter.)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)