You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by "prateekm (via GitHub)" <gi...@apache.org> on 2023/03/22 04:05:17 UTC
[GitHub] [samza] prateekm commented on pull request #1658: Changed uses of Apache Commons IO FileUtils.deleteDirectory to PathUtils.deleteDirectory
prateekm commented on PR #1658:
URL: https://github.com/apache/samza/pull/1658#issuecomment-1478891059
@shekhars-li FYI, another symptom/side effect of this bug is that a file can appear in both DirIndex#filesPresent and DirIndex#filesRemoved lists, despite the validation in the constructor. This is because `validatePresentAndRemovedOverlap` compares FileIndexes, whose `equals` also compares file permissions. So the same file with changed permissions (e.g. due to bug above) will be considered different than the remote file and be present in filesAdded (new local file) and filesRemoved (old remote file).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@samza.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org