[GitHub] [incubator-iceberg] aokolnychyi commented on a change in pull request #734: HIVE: On alter table prevent hive from recursively scanning the complete table dir

[GitBox <gi...@apache.org>]

aokolnychyi commented on a change in pull request #734: HIVE: On alter table prevent hive from recursively scanning the complete table dir
URL: https://github.com/apache/incubator-iceberg/pull/734#discussion_r366306052
 
 

 ##########
 File path: hive/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java
 ##########
 @@ -163,7 +165,10 @@ protected void doCommit(TableMetadata base, TableMetadata metadata) {
 
       if (base != null) {
         metaClients.run(client -> {
-          client.alter_table(database, tableName, tbl);
+          client.alter_table(database, tableName, tbl,
 
 Review comment:
   Nit: Iceberg uses 4 spaces for continued indentation and `ImmutableMap` from Guava.
   
   What about this?
   
   ```
   EnvironmentContext envContext = new EnvironmentContext(
       ImmutableMap.of(StatsSetupConst.DO_NOT_UPDATE_STATS, StatsSetupConst.TRUE)
   );
   client.alter_table(database, tableName, tbl, envContext);
   
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org