You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "huangkai66 (via GitHub)" <gi...@apache.org> on 2023/07/17 12:25:48 UTC

[GitHub] [doris-flink-connector] huangkai66 opened a new pull request, #164: Optimize method for constructing builder object based on Builder pattern

huangkai66 opened a new pull request, #164:
URL: https://github.com/apache/doris-flink-connector/pull/164

   # Proposed changes
   
   Issue Number: close #xxx
   
   ## Problem Summary:
   
   Add a builderDefaults() method which returns Builder in stead of DorisExecutionOptions. 
   According to the Builder pattern, this method can not only configure the json format and reading json by line, but also configure other parameters that developers need to set.
   
   ## Checklist(Required)
   
   1. Does it affect the original behavior: (No)
   2. Has unit tests been added: (No)
   3. Has document been added or modified: (No)
   4. Does it need to update dependencies: (No)
   5. Are there any changes that cannot be rolled back: (No)
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris-flink-connector] JNSimba merged pull request #164: [Improve]Optimize method for constructing builder object based on Builder pattern

Posted by "JNSimba (via GitHub)" <gi...@apache.org>.
JNSimba merged PR #164:
URL: https://github.com/apache/doris-flink-connector/pull/164


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org