(beam) branch master updated: Add missing format strings to logging calls (#36192)

[jr...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

jrmccluskey pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/beam.git


The following commit(s) were added to refs/heads/master by this push:
     new db18391bb86 Add missing format strings to logging calls (#36192)
db18391bb86 is described below

commit db18391bb86a7ce7165263547b4fc6b7278231d1
Author: Jack McCluskey <34...@users.noreply.github.com>
AuthorDate: Thu Sep 18 13:21:02 2025 -0400

    Add missing format strings to logging calls (#36192)
---
 sdks/go/container/tools/buffered_logging.go          | 4 ++--
 sdks/go/container/tools/logging_test.go              | 2 +-
 sdks/go/pkg/beam/runners/dataflow/dataflowlib/job.go | 2 +-
 sdks/python/container/boot.go                        | 6 +++---
 4 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/sdks/go/container/tools/buffered_logging.go b/sdks/go/container/tools/buffered_logging.go
index a7b84e56af3..a0937b8eb14 100644
--- a/sdks/go/container/tools/buffered_logging.go
+++ b/sdks/go/container/tools/buffered_logging.go
@@ -78,7 +78,7 @@ func (b *BufferedLogger) FlushAtError(ctx context.Context) {
 		return
 	}
 	for _, message := range b.logs {
-		b.logger.Errorf(ctx, message)
+		b.logger.Errorf(ctx, "%s", message)
 	}
 	b.logs = nil
 	b.lastFlush = time.Now()
@@ -91,7 +91,7 @@ func (b *BufferedLogger) FlushAtDebug(ctx context.Context) {
 		return
 	}
 	for _, message := range b.logs {
-		b.logger.Printf(ctx, message)
+		b.logger.Printf(ctx, "%s", message)
 	}
 	b.logs = nil
 	b.lastFlush = time.Now()
diff --git a/sdks/go/container/tools/logging_test.go b/sdks/go/container/tools/logging_test.go
index 8730a0fe9c1..c68600f75e2 100644
--- a/sdks/go/container/tools/logging_test.go
+++ b/sdks/go/container/tools/logging_test.go
@@ -85,7 +85,7 @@ func TestLogger(t *testing.T) {
 
 		catcher.err = errors.New("test error")
 		wantMsg := "checking for error?"
-		l.Printf(ctx, wantMsg)
+		l.Printf(ctx, "%s", wantMsg)
 
 		line, err := buf.ReadString('\n')
 		if err != nil {
diff --git a/sdks/go/pkg/beam/runners/dataflow/dataflowlib/job.go b/sdks/go/pkg/beam/runners/dataflow/dataflowlib/job.go
index ed706ec1a48..96c0750d18e 100644
--- a/sdks/go/pkg/beam/runners/dataflow/dataflowlib/job.go
+++ b/sdks/go/pkg/beam/runners/dataflow/dataflowlib/job.go
@@ -262,7 +262,7 @@ func WaitForCompletion(ctx context.Context, client *df.Service, project, region,
 		if err != nil {
 			return err
 		}
-		log.Infof(ctx, msg)
+		log.Infof(ctx, "%s", msg)
 		if terminal {
 			return nil
 		}
diff --git a/sdks/python/container/boot.go b/sdks/python/container/boot.go
index b7cbc07dca6..847325d4f83 100644
--- a/sdks/python/container/boot.go
+++ b/sdks/python/container/boot.go
@@ -188,7 +188,7 @@ func launchSDKProcess() error {
 	if err != nil {
 		fmtErr := fmt.Errorf("failed to retrieve staged files: %v", err)
 		// Send error message to logging service before returning up the call stack
-		logger.Errorf(ctx, fmtErr.Error())
+		logger.Errorf(ctx, "%s", fmtErr.Error())
 		// No need to fail the job if submission_environment_dependencies.txt cannot be loaded
 		if strings.Contains(fmtErr.Error(), "submission_environment_dependencies.txt") {
 			logger.Printf(ctx, "Ignore the error when loading submission_environment_dependencies.txt.")
@@ -214,7 +214,7 @@ func launchSDKProcess() error {
 	if setupErr := installSetupPackages(ctx, logger, fileNames, dir, requirementsFiles); setupErr != nil {
 		fmtErr := fmt.Errorf("failed to install required packages: %v", setupErr)
 		// Send error message to logging service before returning up the call stack
-		logger.Errorf(ctx, fmtErr.Error())
+		logger.Errorf(ctx, "%s", fmtErr.Error())
 		return fmtErr
 	}
 
@@ -500,6 +500,6 @@ func logSubmissionEnvDependencies(ctx context.Context, bufLogger *tools.Buffered
 	if err != nil {
 		return err
 	}
-	bufLogger.Printf(ctx, string(content))
+	bufLogger.Printf(ctx, "%s", string(content))
 	return nil
 }