You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "chb2ab (via GitHub)" <gi...@apache.org> on 2024/01/24 18:56:32 UTC
[PR] Minor update to KafkaApisTest [kafka]
chb2ab opened a new pull request, #15257:
URL: https://github.com/apache/kafka/pull/15257
@jolshan noticed I was using the ZERO_UUID topicId instead of the actual topicId in the testFetchResponseContainsNewLeaderOnNotLeaderOrFollower introduced in https://github.com/apache/kafka/pull/14444, updating as the actual topicId is more correct.
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.*
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Minor update to KafkaApisTest [kafka]
Posted by "chb2ab (via GitHub)" <gi...@apache.org>.
chb2ab commented on code in PR #15257:
URL: https://github.com/apache/kafka/pull/15257#discussion_r1465584550
##########
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##########
@@ -4296,9 +4296,9 @@ class KafkaApisTest extends Logging {
Optional.empty(), OptionalLong.empty(), Optional.empty(), OptionalInt.empty(), false)))
})
- val fetchData = Map(tidp -> new FetchRequest.PartitionData(Uuid.ZERO_UUID, 0, 0, 1000,
+ val fetchData = Map(tidp -> new FetchRequest.PartitionData(topicId, 0, 0, 1000,
Optional.empty())).asJava
- val fetchDataBuilder = Map(tp -> new FetchRequest.PartitionData(Uuid.ZERO_UUID, 0, 0, 1000,
+ val fetchDataBuilder = Map(tp -> new FetchRequest.PartitionData(topicId, 0, 0, 1000,
Review Comment:
updated, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Minor update to KafkaApisTest [kafka]
Posted by "jolshan (via GitHub)" <gi...@apache.org>.
jolshan commented on PR #15257:
URL: https://github.com/apache/kafka/pull/15257#issuecomment-1910743134
Very strange this build has been running for almost a day and the link to it doesn't work: https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-15257/1/pipeline
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Minor update to KafkaApisTest [kafka]
Posted by "jolshan (via GitHub)" <gi...@apache.org>.
jolshan commented on code in PR #15257:
URL: https://github.com/apache/kafka/pull/15257#discussion_r1465430002
##########
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##########
@@ -4296,9 +4296,9 @@ class KafkaApisTest extends Logging {
Optional.empty(), OptionalLong.empty(), Optional.empty(), OptionalInt.empty(), false)))
})
- val fetchData = Map(tidp -> new FetchRequest.PartitionData(Uuid.ZERO_UUID, 0, 0, 1000,
+ val fetchData = Map(tidp -> new FetchRequest.PartitionData(topicId, 0, 0, 1000,
Optional.empty())).asJava
- val fetchDataBuilder = Map(tp -> new FetchRequest.PartitionData(Uuid.ZERO_UUID, 0, 0, 1000,
+ val fetchDataBuilder = Map(tp -> new FetchRequest.PartitionData(topicId, 0, 0, 1000,
Review Comment:
FullFetchContext should also set usesTopicIds to true.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Minor update to KafkaApisTest [kafka]
Posted by "jolshan (via GitHub)" <gi...@apache.org>.
jolshan merged PR #15257:
URL: https://github.com/apache/kafka/pull/15257
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org