[GitHub] [superset] villebro commented on pull request #13260: ci: always execute tests on non-PRs

[GitBox <gi...@apache.org>]

villebro commented on pull request #13260:
URL: https://github.com/apache/superset/pull/13260#issuecomment-783120721


   > I wonder whether it'd make the workflow scripts easier to understand if we use step **output** instead of **outcome** , considering all future steps will have to check the step results anyway.
   > 
   > ```shell
   > for FILE in ${FILES}
   > do
   >   for REGEX in "${REGEXES[@]}"
   >   do
   >     if [[ "${FILE}" =~ ${REGEX} ]]; then
   >       echo "Detected changes in following file: ${FILE}"
   >       exit 0
   >     fi
   >   done
   > done
   > echo "No matching file changes detected"
   > echo "::set-output name=no_matching_change::true"
   > ```
   > 
   > Then maybe we can also use condition check on the check job itself (`if: github.event_name == 'pull_request'`) to address what this PR is trying to solve? I.e. run the file change check only on pull requests, and _skip_ future tasks only if `steps.check_file_change.output.no_matching_change = true`.
   
   This is a really good idea; I'll merge this one first to fix the problem but will follow up with something along these lines if it works well.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org