You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/09/02 06:52:24 UTC
[GitHub] [apisix-helm-chart] nic-6443 opened a new pull request, #335: feat: create rbac resources when kubernetes service discovery enabled
nic-6443 opened a new pull request, #335:
URL: https://github.com/apache/apisix-helm-chart/pull/335
Signed-off-by: Nic <qi...@api7.ai>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] nic-6443 commented on a diff in pull request #335: feat: create rbac resources when kubernetes service discovery enabled
Posted by GitBox <gi...@apache.org>.
nic-6443 commented on code in PR #335:
URL: https://github.com/apache/apisix-helm-chart/pull/335#discussion_r962405266
##########
charts/apisix/templates/service-account.yaml:
##########
@@ -0,0 +1,23 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+{{- if .Values.serviceAccount.create }}
+apiVersion: v1
+kind: ServiceAccount
+metadata:
+ name: {{ include "apisix.serviceAccountName" . }}
Review Comment:
https://github.com/apache/apisix-helm-chart/blob/2ebd372eff42ccf3e874cc016f00851e18b1ca79/charts/apisix/templates/_helpers.tpl#L54-L63
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tokers commented on a diff in pull request #335: feat: create rbac resources when kubernetes service discovery enabled
Posted by GitBox <gi...@apache.org>.
tokers commented on code in PR #335:
URL: https://github.com/apache/apisix-helm-chart/pull/335#discussion_r962290029
##########
charts/apisix/templates/service-account.yaml:
##########
@@ -0,0 +1,23 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+{{- if .Values.serviceAccount.create }}
+apiVersion: v1
+kind: ServiceAccount
+metadata:
+ name: {{ include "apisix.serviceAccountName" . }}
Review Comment:
Where did we define `apisix.serviceAccountName`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tao12345666333 commented on pull request #335: feat: create rbac resources when kubernetes service discovery enabled
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on PR #335:
URL: https://github.com/apache/apisix-helm-chart/pull/335#issuecomment-1235503566
Duplicate #278
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] nic-6443 closed pull request #335: feat: create rbac resources when kubernetes service discovery enabled
Posted by GitBox <gi...@apache.org>.
nic-6443 closed pull request #335: feat: create rbac resources when kubernetes service discovery enabled
URL: https://github.com/apache/apisix-helm-chart/pull/335
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org