[GitHub] [beam] benWize commented on pull request #15174: [WIP][BEAM-12100][BEAM-10379][BEAM-9514] AssertionError type mismatch from AggregateScanConverter

[GitBox <gi...@apache.org>]

benWize commented on pull request #15174:
URL: https://github.com/apache/beam/pull/15174#issuecomment-895604449


   Hi @ibzib, I overrode `identity()` in `LongSum` as you suggested, it was necessary to override `identity()` for the other sum types as well. 
   I found out that `VarianceFn` and `CovarianceFn` were throwing an ArithmeticException like in https://ci-beam.apache.org/job/beam_PreCommit_SQL_Commit/4013/testReport/junit/org.apache.beam.sdk.extensions.sql/BeamSqlDslSqlStdOperatorsTest/testVARPOP/ so I added a check when count and variance are zero to avoid the division undefined exception.
   I am stuck now with a couple of errors related to the incompatibility of Coders like in https://ci-beam.apache.org/job/beam_PreCommit_SQL_Java11_Commit/2966/testReport/junit/org.apache.beam.sdk.extensions.sql.zetasql/ZetaSqlDialectSpecTest/testArrayAggZetasql/ and https://ci-beam.apache.org/job/beam_PreCommit_SQL_Java11_Commit/2966/testReport/junit/org.apache.beam.sdk.extensions.sql.zetasql/ZetaSqlDialectSpecTest/testCountIfZetaSQLDialect/. 
   Do you have a suggestion of how should I proceed with these?
   Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org