You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by "liubao68 (via GitHub)" <gi...@apache.org> on 2024/08/31 10:39:37 UTC
[PR] [#4477]Fix GoAway issue in Http2 after many requests timeout [servicecomb-java-chassis]
liubao68 opened a new pull request, #4487:
URL: https://github.com/apache/servicecomb-java-chassis/pull/4487
Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean install -Pit` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [#4477]Fix GoAway issue in Http2 after many requests timeout [servicecomb-java-chassis]
Posted by "liubao68 (via GitHub)" <gi...@apache.org>.
liubao68 commented on PR #4487:
URL: https://github.com/apache/servicecomb-java-chassis/pull/4487#issuecomment-2323657678
> 这个改法是判断连接是否closed来决定服务端是否调用end方法,推送数据,这里跳过end方法是否会对服务端的连接产生影响?
closed意味着早已经end, 这个是没问题的。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [#4477]Fix GoAway issue in Http2 after many requests timeout [servicecomb-java-chassis]
Posted by "liubao68 (via GitHub)" <gi...@apache.org>.
liubao68 merged PR #4487:
URL: https://github.com/apache/servicecomb-java-chassis/pull/4487
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [#4477]Fix GoAway issue in Http2 after many requests timeout [servicecomb-java-chassis]
Posted by "yanghao605 (via GitHub)" <gi...@apache.org>.
yanghao605 commented on PR #4487:
URL: https://github.com/apache/servicecomb-java-chassis/pull/4487#issuecomment-2323587096
这个改法是判断连接是否closed来决定服务端是否调用end方法,推送数据,这里跳过end方法是否会对服务端的连接产生影响?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org