You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/05/17 22:08:36 UTC

[GitHub] [activemq-artemis] michaelpearce-gain commented on a change in pull request #3580: ARTEMIS-3297 Historic Journal Backup

michaelpearce-gain commented on a change in pull request #3580:
URL: https://github.com/apache/activemq-artemis/pull/3580#discussion_r633899129



##########
File path: artemis-server/src/main/resources/schema/artemis-configuration.xsd
##########
@@ -675,6 +675,82 @@
             </xsd:annotation>
          </xsd:element>
 
+         <xsd:element name="journal-retention" maxOccurs="1" minOccurs="0">
+            <xsd:annotation>
+               <xsd:documentation>
+                  Configuration about the journal retention configuration.
+               </xsd:documentation>
+            </xsd:annotation>
+            <xsd:complexType>
+               <xsd:attribute name="unit" use="required">
+                  <xsd:annotation>
+                     <xsd:documentation>
+                        This configures the period type to use on limit. By default it is DAYS.
+                     </xsd:documentation>
+                  </xsd:annotation>
+                  <xsd:simpleType>
+                     <xsd:restriction base="xsd:string">
+                        <xsd:enumeration value="DAYS"/>
+                        <xsd:enumeration value="HOURS"/>
+                        <xsd:enumeration value="SECONDS"/>
+                     </xsd:restriction>
+                  </xsd:simpleType>
+               </xsd:attribute>
+               <xsd:attribute name="directory" type="xsd:string" use="required">

Review comment:
       ```
               <xsd:element name="journal-retention-directory" maxOccurs="1" minOccurs="0">
                   <xsd:annotation>
                       <xsd:documentation>
                           the directory to store journal-retention message in and rention configuraion.
                       </xsd:documentation>
                   </xsd:annotation>
                   <xsd:complexType>
                       <xsd:simpleContent>
                           <xsd:extension base="xsd:string">
                               <xsd:attribute name="unit" use="optional">
                                   <xsd:annotation>
                                       <xsd:documentation>
                                           This configures the period type to use on limit. By default it is DAYS.
                                       </xsd:documentation>
                                   </xsd:annotation>
                                   <xsd:simpleType>
                                       <xsd:restriction base="xsd:string">
                                           <xsd:enumeration value="DAYS"/>
                                           <xsd:enumeration value="HOURS"/>
                                           <xsd:enumeration value="SECONDS"/>
                                       </xsd:restriction>
                                   </xsd:simpleType>
                               </xsd:attribute>
                               <xsd:attribute name="period" type="xsd:integer" use="optional">
                                   <xsd:annotation>
                                       <xsd:documentation>
                                           The amount of time used to keep files.
                                       </xsd:documentation>
                                   </xsd:annotation>
                               </xsd:attribute>
                               <xsd:attribute name="storage-limit" type="xsd:string" use="optional">
                                   <xsd:annotation>
                                       <xsd:documentation>
                                           Size (in bytes) before we starting removing files from the retention area.
                                           this is an extra protection on top of the period.
                                           Notice we first remove files based on period and if you're using more storage then you
                                           configured we start removing older files.
                                           By default this is unlimited (not filled).
                                           Supports byte notation like "K", "Mb", "GB", etc.
                                       </xsd:documentation>
                                   </xsd:annotation>
                               </xsd:attribute>
                           </xsd:extension>
                       </xsd:simpleContent>
                   </xsd:complexType>
               </xsd:element>```
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org