You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Nitiraj Rathore <ni...@gmail.com> on 2017/01/23 07:15:20 UTC
Review Request 55831: Hive view loosing one row every 100 row in
result set.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55831/
-----------------------------------------------------------
Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, and Rohit Choudhary.
Bugs: AMBARI-19666
https://issues.apache.org/jira/browse/AMBARI-19666
Repository: ambari
Description
-------
corrected the order of boolean check to avoid fetching one more result from resultSet when not required.
Diffs
-----
contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/actor/ResultSetIterator.java 1052bd4
contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/ResultSetIterator.java 4b4a407
Diff: https://reviews.apache.org/r/55831/diff/
Testing
-------
manual testing done.
Thanks,
Nitiraj Rathore
Re: Review Request 55831: Hive view loosing one row every 100 row in
result set.
Posted by Gaurav Nagar <gn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55831/#review162604
-----------------------------------------------------------
Ship it!
Ship It!
- Gaurav Nagar
On Jan. 23, 2017, 7:15 a.m., Nitiraj Rathore wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55831/
> -----------------------------------------------------------
>
> (Updated Jan. 23, 2017, 7:15 a.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, and Rohit Choudhary.
>
>
> Bugs: AMBARI-19666
> https://issues.apache.org/jira/browse/AMBARI-19666
>
>
> Repository: ambari
>
>
> Description
> -------
>
> corrected the order of boolean check to avoid fetching one more result from resultSet when not required.
>
>
> Diffs
> -----
>
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/actor/ResultSetIterator.java 1052bd4
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/ResultSetIterator.java 4b4a407
>
> Diff: https://reviews.apache.org/r/55831/diff/
>
>
> Testing
> -------
>
> manual testing done.
>
>
> Thanks,
>
> Nitiraj Rathore
>
>
Re: Review Request 55831: Hive view loosing one row every 100 row in
result set.
Posted by Rohit Choudhary <rc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55831/#review162609
-----------------------------------------------------------
Ship it!
Ship It!
- Rohit Choudhary
On Jan. 23, 2017, 7:15 a.m., Nitiraj Rathore wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55831/
> -----------------------------------------------------------
>
> (Updated Jan. 23, 2017, 7:15 a.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, and Rohit Choudhary.
>
>
> Bugs: AMBARI-19666
> https://issues.apache.org/jira/browse/AMBARI-19666
>
>
> Repository: ambari
>
>
> Description
> -------
>
> corrected the order of boolean check to avoid fetching one more result from resultSet when not required.
>
>
> Diffs
> -----
>
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/actor/ResultSetIterator.java 1052bd4
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/ResultSetIterator.java 4b4a407
>
> Diff: https://reviews.apache.org/r/55831/diff/
>
>
> Testing
> -------
>
> manual testing done.
>
>
> Thanks,
>
> Nitiraj Rathore
>
>
Re: Review Request 55831: Hive view loosing one row every 100 row in
result set.
Posted by DIPAYAN BHOWMICK <di...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55831/#review162611
-----------------------------------------------------------
Ship it!
Ship It!
- DIPAYAN BHOWMICK
On Jan. 23, 2017, 7:15 a.m., Nitiraj Rathore wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55831/
> -----------------------------------------------------------
>
> (Updated Jan. 23, 2017, 7:15 a.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, and Rohit Choudhary.
>
>
> Bugs: AMBARI-19666
> https://issues.apache.org/jira/browse/AMBARI-19666
>
>
> Repository: ambari
>
>
> Description
> -------
>
> corrected the order of boolean check to avoid fetching one more result from resultSet when not required.
>
>
> Diffs
> -----
>
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/actor/ResultSetIterator.java 1052bd4
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/ResultSetIterator.java 4b4a407
>
> Diff: https://reviews.apache.org/r/55831/diff/
>
>
> Testing
> -------
>
> manual testing done.
>
>
> Thanks,
>
> Nitiraj Rathore
>
>