You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by GitBox <gi...@apache.org> on 2021/12/30 10:20:02 UTC
[GitHub] [incubator-kyuubi] yaooqinn opened a new pull request #1658: Revamp swagger ui dependencies
yaooqinn opened a new pull request #1658:
URL: https://github.com/apache/incubator-kyuubi/pull/1658
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html
2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] [Run test](https://kyuubi.readthedocs.io/en/latest/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yaooqinn edited a comment on pull request #1658: Revamp swagger ui dependencies
Posted by GitBox <gi...@apache.org>.
yaooqinn edited a comment on pull request #1658:
URL: https://github.com/apache/incubator-kyuubi/pull/1658#issuecomment-1003247115
> ```json
> components
> ```
> Sorry for the later review, @yaooqinn
>
> > This PR mainly removes the swagger-scala-module which is currently fine to remove.
>
> This is a breaking change for openapi. `swagger-scala-module` is a library that automatically generates a schema from a Scala case class.
>
> After this PR
>
> ```json
> "components" : {
> "schemas" : {
> "OpActionRequest" : {
> "type" : "object"
> },
> "KyuubiOperationEvent" : {
> "type" : "object"
> },
> "OperationLog" : {
> "type" : "object"
> },
> "ResultSetMetaData" : {
> "type" : "object"
> },
> "OperationHandle" : {
> "type" : "object",
> "properties" : {
> "hasResultSet" : {
> "type" : "boolean",
> "writeOnly" : true
> }
> }
> },
> "ExecPoolStatistic" : {
> "type" : "object"
> },
> "StatementRequest" : {
> "type" : "object"
> },
> "GetColumnsRequest" : {
> "type" : "object"
> },
> "GetFunctionsRequest" : {
> "type" : "object"
> },
> "InfoDetail" : {
> "type" : "object"
> },
> "GetSchemasRequest" : {
> "type" : "object"
> },
> "GetTablesRequest" : {
> "type" : "object"
> },
> "SessionHandle" : {
> "type" : "object"
> },
> "SessionOpenRequest" : {
> "type" : "object"
> },
> "SessionOpenCount" : {
> "type" : "object"
> },
> "KyuubiSessionEvent" : {
> "type" : "object"
> },
> "SessionList" : {
> "type" : "object"
> }
> }
> }
> ```
>
> Before this PR
>
> ```json
> "components" : {
> "schemas" : {
> "OpActionRequest" : {
> "required" : [ "action" ],
> "type" : "object",
> "properties" : {
> "action" : {
> "type" : "string"
> }
> }
> },
> "KyuubiOperationEvent" : {
> "required" : [ "eventTime", "shouldRunAsync", "statementId" ],
> "type" : "object",
> "properties" : {
> "statementId" : {
> "type" : "string"
> },
> "remoteId" : {
> "type" : "string"
> },
> "statement" : {
> "type" : "string"
> },
> "shouldRunAsync" : {
> "type" : "boolean"
> },
> "state" : {
> "type" : "string"
> },
> "eventTime" : {
> "type" : "integer",
> "format" : "int64"
> },
> "createTime" : {
> "type" : "integer",
> "format" : "int64"
> },
> "startTime" : {
> "type" : "integer",
> "format" : "int64"
> },
> "completeTime" : {
> "type" : "integer",
> "format" : "int64"
> },
> "exception" : {
> "type" : "object",
> "properties" : {
> "cause" : {
> "required" : [ "stackTrace", "suppressed" ],
> "type" : "object",
> "properties" : {
> "stackTrace" : {
> "type" : "array",
> "items" : {
> "required" : [ "lineNumber" ],
> "type" : "object",
> "properties" : {
> "methodName" : {
> "type" : "string"
> },
> "fileName" : {
> "type" : "string"
> },
> "lineNumber" : {
> "type" : "integer",
> "format" : "int32"
> },
> "className" : {
> "type" : "string"
> },
> "nativeMethod" : {
> "type" : "boolean"
> }
> }
> }
> },
> "message" : {
> "type" : "string"
> },
> "localizedMessage" : {
> "type" : "string"
> },
> "suppressed" : {
> "type" : "array",
> "items" : {
> "type" : "object",
> "properties" : {
> "stackTrace" : {
> "type" : "array",
> "items" : {
> "required" : [ "lineNumber" ],
> "type" : "object",
> "properties" : {
> "methodName" : {
> "type" : "string"
> },
> "fileName" : {
> "type" : "string"
> },
> "lineNumber" : {
> "type" : "integer",
> "format" : "int32"
> },
> "className" : {
> "type" : "string"
> },
> "nativeMethod" : {
> "type" : "boolean"
> }
> }
> }
> },
> "message" : {
> "type" : "string"
> },
> "localizedMessage" : {
> "type" : "string"
> }
> }
> }
> }
> }
> },
> "stackTrace" : {
> "type" : "array",
> "items" : {
> "required" : [ "lineNumber" ],
> "type" : "object",
> "properties" : {
> "methodName" : {
> "type" : "string"
> },
> "fileName" : {
> "type" : "string"
> },
> "lineNumber" : {
> "type" : "integer",
> "format" : "int32"
> },
> "className" : {
> "type" : "string"
> },
> "nativeMethod" : {
> "type" : "boolean"
> }
> }
> }
> },
> "message" : {
> "type" : "string"
> },
> "localizedMessage" : {
> "type" : "string"
> },
> "suppressed" : {
> "type" : "array",
> "items" : {
> "type" : "object",
> "properties" : {
> "stackTrace" : {
> "type" : "array",
> "items" : {
> "required" : [ "lineNumber" ],
> "type" : "object",
> "properties" : {
> "methodName" : {
> "type" : "string"
> },
> "fileName" : {
> "type" : "string"
> },
> "lineNumber" : {
> "type" : "integer",
> "format" : "int32"
> },
> "className" : {
> "type" : "string"
> },
> "nativeMethod" : {
> "type" : "boolean"
> }
> }
> }
> },
> "message" : {
> "type" : "string"
> },
> "localizedMessage" : {
> "type" : "string"
> }
> }
> }
> }
> }
> },
> "sessionId" : {
> "type" : "string"
> },
> "sessionUser" : {
> "type" : "string"
> },
> "eventType" : {
> "type" : "string"
> }
> }
> },
> "OperationLog" : {
> "required" : [ "logRowSet", "rowCount" ],
> "type" : "object",
> "properties" : {
> "logRowSet" : {
> "type" : "array",
> "items" : {
> "type" : "string"
> }
> },
> "rowCount" : {
> "type" : "integer",
> "format" : "int32"
> }
> }
> },
> "SeqString" : {
> "type" : "array",
> "items" : {
> "type" : "string"
> }
> },
> "ColumnDesc" : {
> "required" : [ "columnIndex", "columnName" ],
> "type" : "object",
> "properties" : {
> "columnName" : {
> "type" : "string"
> },
> "dataType" : {
> "type" : "string"
> },
> "columnIndex" : {
> "type" : "integer",
> "format" : "int32"
> },
> "precision" : {
> "type" : "integer",
> "format" : "int32"
> },
> "scale" : {
> "type" : "integer",
> "format" : "int32"
> },
> "comment" : {
> "type" : "string"
> }
> }
> },
> "ResultSetMetaData" : {
> "required" : [ "columns" ],
> "type" : "object",
> "properties" : {
> "columns" : {
> "type" : "array",
> "items" : {
> "$ref" : "#/components/schemas/ColumnDesc"
> }
> }
> }
> },
> "SeqColumnDesc" : {
> "type" : "array",
> "items" : {
> "$ref" : "#/components/schemas/ColumnDesc"
> }
> },
> "HandleIdentifier" : {
> "required" : [ "publicId" ],
> "type" : "object",
> "properties" : {
> "publicId" : {
> "type" : "string",
> "format" : "uuid"
> },
> "secretId" : {
> "type" : "string",
> "format" : "uuid"
> }
> }
> },
> "OperationHandle" : {
> "required" : [ "hasResultSet", "identifier", "protocol", "typ" ],
> "type" : "object",
> "properties" : {
> "identifier" : {
> "$ref" : "#/components/schemas/HandleIdentifier"
> },
> "typ" : {
> "$ref" : "#/components/schemas/Value"
> },
> "protocol" : {
> "type" : "string",
> "enum" : [ "HIVE_CLI_SERVICE_PROTOCOL_V1", "HIVE_CLI_SERVICE_PROTOCOL_V2", "HIVE_CLI_SERVICE_PROTOCOL_V3", "HIVE_CLI_SERVICE_PROTOCOL_V4", "HIVE_CLI_SERVICE_PROTOCOL_V5", "HIVE_CLI_SERVICE_PROTOCOL_V6", "HIVE_CLI_SERVICE_PROTOCOL_V7", "HIVE_CLI_SERVICE_PROTOCOL_V8", "HIVE_CLI_SERVICE_PROTOCOL_V9", "HIVE_CLI_SERVICE_PROTOCOL_V10" ]
> },
> "hasResultSet" : {
> "type" : "boolean",
> "writeOnly" : true
> }
> }
> },
> "Value" : {
> "type" : "object"
> },
> "ExecPoolStatistic" : {
> "required" : [ "execPoolSize" ],
> "type" : "object",
> "properties" : {
> "execPoolSize" : {
> "type" : "integer",
> "format" : "int32"
> },
> "execPoolActiveCount" : {
> "type" : "integer",
> "format" : "int32"
> }
> }
> },
> "StatementRequest" : {
> "required" : [ "queryTimeout", "runAsync", "statement" ],
> "type" : "object",
> "properties" : {
> "statement" : {
> "type" : "string"
> },
> "runAsync" : {
> "type" : "boolean"
> },
> "queryTimeout" : {
> "type" : "integer",
> "format" : "int64"
> }
> }
> },
> "GetColumnsRequest" : {
> "required" : [ "catalogName" ],
> "type" : "object",
> "properties" : {
> "catalogName" : {
> "type" : "string"
> },
> "schemaName" : {
> "type" : "string"
> },
> "tableName" : {
> "type" : "string"
> },
> "columnName" : {
> "type" : "string"
> }
> }
> },
> "GetFunctionsRequest" : {
> "required" : [ "catalogName" ],
> "type" : "object",
> "properties" : {
> "catalogName" : {
> "type" : "string"
> },
> "schemaName" : {
> "type" : "string"
> },
> "functionName" : {
> "type" : "string"
> }
> }
> },
> "InfoDetail" : {
> "required" : [ "infoType" ],
> "type" : "object",
> "properties" : {
> "infoType" : {
> "type" : "string"
> },
> "infoValue" : {
> "type" : "string"
> }
> }
> },
> "GetSchemasRequest" : {
> "required" : [ "catalogName" ],
> "type" : "object",
> "properties" : {
> "catalogName" : {
> "type" : "string"
> },
> "schemaName" : {
> "type" : "string"
> }
> }
> },
> "GetTablesRequest" : {
> "required" : [ "catalogName", "tableTypes" ],
> "type" : "object",
> "properties" : {
> "catalogName" : {
> "type" : "string"
> },
> "schemaName" : {
> "type" : "string"
> },
> "tableName" : {
> "type" : "string"
> },
> "tableTypes" : {
> "type" : "array",
> "items" : {
> "type" : "string"
> }
> }
> }
> },
> "SessionHandle" : {
> "required" : [ "identifier", "protocol" ],
> "type" : "object",
> "properties" : {
> "identifier" : {
> "$ref" : "#/components/schemas/HandleIdentifier"
> },
> "protocol" : {
> "type" : "string",
> "enum" : [ "HIVE_CLI_SERVICE_PROTOCOL_V1", "HIVE_CLI_SERVICE_PROTOCOL_V2", "HIVE_CLI_SERVICE_PROTOCOL_V3", "HIVE_CLI_SERVICE_PROTOCOL_V4", "HIVE_CLI_SERVICE_PROTOCOL_V5", "HIVE_CLI_SERVICE_PROTOCOL_V6", "HIVE_CLI_SERVICE_PROTOCOL_V7", "HIVE_CLI_SERVICE_PROTOCOL_V8", "HIVE_CLI_SERVICE_PROTOCOL_V9", "HIVE_CLI_SERVICE_PROTOCOL_V10" ]
> }
> }
> },
> "MapStringString" : {
> "type" : "object",
> "additionalProperties" : {
> "type" : "string"
> }
> },
> "SessionOpenRequest" : {
> "required" : [ "configs", "protocolVersion", "user" ],
> "type" : "object",
> "properties" : {
> "protocolVersion" : {
> "type" : "integer",
> "format" : "int32"
> },
> "user" : {
> "type" : "string"
> },
> "password" : {
> "type" : "string"
> },
> "ipAddr" : {
> "type" : "string"
> },
> "configs" : {
> "type" : "object",
> "additionalProperties" : {
> "type" : "string"
> }
> }
> }
> },
> "SessionOpenCount" : {
> "required" : [ "openSessionCount" ],
> "type" : "object",
> "properties" : {
> "openSessionCount" : {
> "type" : "integer",
> "format" : "int32"
> }
> }
> },
> "KyuubiSessionEvent" : {
> "required" : [ "clientVersion", "conf", "sessionId", "startTime" ],
> "type" : "object",
> "properties" : {
> "sessionId" : {
> "type" : "string"
> },
> "clientVersion" : {
> "type" : "integer",
> "format" : "int32"
> },
> "sessionName" : {
> "type" : "string"
> },
> "user" : {
> "type" : "string"
> },
> "clientIP" : {
> "type" : "string"
> },
> "serverIP" : {
> "type" : "string"
> },
> "conf" : {
> "type" : "object",
> "additionalProperties" : {
> "type" : "string"
> }
> },
> "startTime" : {
> "type" : "integer",
> "format" : "int64"
> },
> "remoteSessionId" : {
> "type" : "string"
> },
> "engineId" : {
> "type" : "string"
> },
> "openedTime" : {
> "type" : "integer",
> "format" : "int64"
> },
> "endTime" : {
> "type" : "integer",
> "format" : "int64"
> },
> "totalOperations" : {
> "type" : "integer",
> "format" : "int32"
> },
> "eventType" : {
> "type" : "string"
> }
> }
> },
> "SeqSessionOverview" : {
> "type" : "array",
> "items" : {
> "$ref" : "#/components/schemas/SessionOverview"
> }
> },
> "SessionList" : {
> "required" : [ "sessionList" ],
> "type" : "object",
> "properties" : {
> "sessionList" : {
> "type" : "array",
> "items" : {
> "$ref" : "#/components/schemas/SessionOverview"
> }
> }
> }
> },
> "SessionOverview" : {
> "required" : [ "createTime", "user" ],
> "type" : "object",
> "properties" : {
> "user" : {
> "type" : "string"
> },
> "ipAddr" : {
> "type" : "string"
> },
> "createTime" : {
> "type" : "integer",
> "format" : "int64"
> },
> "sessionHandle" : {
> "$ref" : "#/components/schemas/SessionHandle"
> }
> }
> }
> }
> }
> ```
can we inline some logic for that, that module seems one have one class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #1658: Revamp swagger ui dependencies
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #1658:
URL: https://github.com/apache/incubator-kyuubi/pull/1658#discussion_r776687611
##########
File path: pom.xml
##########
@@ -670,17 +669,10 @@
<groupId>io.swagger.core.v3</groupId>
<artifactId>swagger-jaxrs2</artifactId>
<version>${swagger.version}</version>
- </dependency>
-
- <!-- ref: https://github.com/swagger-akka-http/swagger-scala-module -->
- <dependency>
- <groupId>com.github.swagger-akka-http</groupId>
- <artifactId>swagger-scala-module_${scala.binary.version}</artifactId>
- <version>${swagger.scala.module.version}</version>
Review comment:
not quite sure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yaooqinn closed pull request #1658: Revamp swagger ui dependencies
Posted by GitBox <gi...@apache.org>.
yaooqinn closed pull request #1658:
URL: https://github.com/apache/incubator-kyuubi/pull/1658
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #1658: Revamp swagger ui dependencies
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1658:
URL: https://github.com/apache/incubator-kyuubi/pull/1658#issuecomment-1003058819
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1658?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1658](https://codecov.io/gh/apache/incubator-kyuubi/pull/1658?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d5ab076) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/6a9550938eade6b57a0ec7e3c346f766816293f6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6a95509) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1658?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1658 +/- ##
============================================
- Coverage 59.57% 59.56% -0.01%
Complexity 193 193
============================================
Files 265 265
Lines 13084 13084
Branches 1649 1649
============================================
- Hits 7795 7794 -1
- Misses 4631 4632 +1
Partials 658 658
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1658?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...he/kyuubi/engine/spark/repl/KyuubiSparkILoop.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1658/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay9yZXBsL0t5dXViaVNwYXJrSUxvb3Auc2NhbGE=) | `90.16% <0.00%> (-3.28%)` | :arrow_down: |
| [...ache/kyuubi/operation/KyuubiOperationManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1658/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vS3l1dWJpT3BlcmF0aW9uTWFuYWdlci5zY2FsYQ==) | `95.00% <0.00%> (+2.50%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1658?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1658?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6a95509...d5ab076](https://codecov.io/gh/apache/incubator-kyuubi/pull/1658?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yaooqinn closed pull request #1658: Revamp swagger ui dependencies
Posted by GitBox <gi...@apache.org>.
yaooqinn closed pull request #1658:
URL: https://github.com/apache/incubator-kyuubi/pull/1658
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #1658: Revamp swagger ui dependencies
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #1658:
URL: https://github.com/apache/incubator-kyuubi/pull/1658#issuecomment-1002968415
cc @pan3793 @cfmcgrady
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] ulysses-you commented on pull request #1658: Revamp swagger ui dependencies
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on pull request #1658:
URL: https://github.com/apache/incubator-kyuubi/pull/1658#issuecomment-1003232767
thanks, merging to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #1658: Revamp swagger ui dependencies
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #1658:
URL: https://github.com/apache/incubator-kyuubi/pull/1658#issuecomment-1003247115
> ```json
> components
> ```
> Sorry for the later review, @yaooqinn
>
> > This PR mainly removes the swagger-scala-module which is currently fine to remove.
>
> This is a breaking change for openapi. `swagger-scala-module` is a library that automatically generates a schema from a Scala case class.
>
> After this PR
>
> ```json
> "components" : {
> "schemas" : {
> "OpActionRequest" : {
> "type" : "object"
> },
> "KyuubiOperationEvent" : {
> "type" : "object"
> },
> "OperationLog" : {
> "type" : "object"
> },
> "ResultSetMetaData" : {
> "type" : "object"
> },
> "OperationHandle" : {
> "type" : "object",
> "properties" : {
> "hasResultSet" : {
> "type" : "boolean",
> "writeOnly" : true
> }
> }
> },
> "ExecPoolStatistic" : {
> "type" : "object"
> },
> "StatementRequest" : {
> "type" : "object"
> },
> "GetColumnsRequest" : {
> "type" : "object"
> },
> "GetFunctionsRequest" : {
> "type" : "object"
> },
> "InfoDetail" : {
> "type" : "object"
> },
> "GetSchemasRequest" : {
> "type" : "object"
> },
> "GetTablesRequest" : {
> "type" : "object"
> },
> "SessionHandle" : {
> "type" : "object"
> },
> "SessionOpenRequest" : {
> "type" : "object"
> },
> "SessionOpenCount" : {
> "type" : "object"
> },
> "KyuubiSessionEvent" : {
> "type" : "object"
> },
> "SessionList" : {
> "type" : "object"
> }
> }
> }
> ```
>
> Before this PR
>
> ```json
> "components" : {
> "schemas" : {
> "OpActionRequest" : {
> "required" : [ "action" ],
> "type" : "object",
> "properties" : {
> "action" : {
> "type" : "string"
> }
> }
> },
> "KyuubiOperationEvent" : {
> "required" : [ "eventTime", "shouldRunAsync", "statementId" ],
> "type" : "object",
> "properties" : {
> "statementId" : {
> "type" : "string"
> },
> "remoteId" : {
> "type" : "string"
> },
> "statement" : {
> "type" : "string"
> },
> "shouldRunAsync" : {
> "type" : "boolean"
> },
> "state" : {
> "type" : "string"
> },
> "eventTime" : {
> "type" : "integer",
> "format" : "int64"
> },
> "createTime" : {
> "type" : "integer",
> "format" : "int64"
> },
> "startTime" : {
> "type" : "integer",
> "format" : "int64"
> },
> "completeTime" : {
> "type" : "integer",
> "format" : "int64"
> },
> "exception" : {
> "type" : "object",
> "properties" : {
> "cause" : {
> "required" : [ "stackTrace", "suppressed" ],
> "type" : "object",
> "properties" : {
> "stackTrace" : {
> "type" : "array",
> "items" : {
> "required" : [ "lineNumber" ],
> "type" : "object",
> "properties" : {
> "methodName" : {
> "type" : "string"
> },
> "fileName" : {
> "type" : "string"
> },
> "lineNumber" : {
> "type" : "integer",
> "format" : "int32"
> },
> "className" : {
> "type" : "string"
> },
> "nativeMethod" : {
> "type" : "boolean"
> }
> }
> }
> },
> "message" : {
> "type" : "string"
> },
> "localizedMessage" : {
> "type" : "string"
> },
> "suppressed" : {
> "type" : "array",
> "items" : {
> "type" : "object",
> "properties" : {
> "stackTrace" : {
> "type" : "array",
> "items" : {
> "required" : [ "lineNumber" ],
> "type" : "object",
> "properties" : {
> "methodName" : {
> "type" : "string"
> },
> "fileName" : {
> "type" : "string"
> },
> "lineNumber" : {
> "type" : "integer",
> "format" : "int32"
> },
> "className" : {
> "type" : "string"
> },
> "nativeMethod" : {
> "type" : "boolean"
> }
> }
> }
> },
> "message" : {
> "type" : "string"
> },
> "localizedMessage" : {
> "type" : "string"
> }
> }
> }
> }
> }
> },
> "stackTrace" : {
> "type" : "array",
> "items" : {
> "required" : [ "lineNumber" ],
> "type" : "object",
> "properties" : {
> "methodName" : {
> "type" : "string"
> },
> "fileName" : {
> "type" : "string"
> },
> "lineNumber" : {
> "type" : "integer",
> "format" : "int32"
> },
> "className" : {
> "type" : "string"
> },
> "nativeMethod" : {
> "type" : "boolean"
> }
> }
> }
> },
> "message" : {
> "type" : "string"
> },
> "localizedMessage" : {
> "type" : "string"
> },
> "suppressed" : {
> "type" : "array",
> "items" : {
> "type" : "object",
> "properties" : {
> "stackTrace" : {
> "type" : "array",
> "items" : {
> "required" : [ "lineNumber" ],
> "type" : "object",
> "properties" : {
> "methodName" : {
> "type" : "string"
> },
> "fileName" : {
> "type" : "string"
> },
> "lineNumber" : {
> "type" : "integer",
> "format" : "int32"
> },
> "className" : {
> "type" : "string"
> },
> "nativeMethod" : {
> "type" : "boolean"
> }
> }
> }
> },
> "message" : {
> "type" : "string"
> },
> "localizedMessage" : {
> "type" : "string"
> }
> }
> }
> }
> }
> },
> "sessionId" : {
> "type" : "string"
> },
> "sessionUser" : {
> "type" : "string"
> },
> "eventType" : {
> "type" : "string"
> }
> }
> },
> "OperationLog" : {
> "required" : [ "logRowSet", "rowCount" ],
> "type" : "object",
> "properties" : {
> "logRowSet" : {
> "type" : "array",
> "items" : {
> "type" : "string"
> }
> },
> "rowCount" : {
> "type" : "integer",
> "format" : "int32"
> }
> }
> },
> "SeqString" : {
> "type" : "array",
> "items" : {
> "type" : "string"
> }
> },
> "ColumnDesc" : {
> "required" : [ "columnIndex", "columnName" ],
> "type" : "object",
> "properties" : {
> "columnName" : {
> "type" : "string"
> },
> "dataType" : {
> "type" : "string"
> },
> "columnIndex" : {
> "type" : "integer",
> "format" : "int32"
> },
> "precision" : {
> "type" : "integer",
> "format" : "int32"
> },
> "scale" : {
> "type" : "integer",
> "format" : "int32"
> },
> "comment" : {
> "type" : "string"
> }
> }
> },
> "ResultSetMetaData" : {
> "required" : [ "columns" ],
> "type" : "object",
> "properties" : {
> "columns" : {
> "type" : "array",
> "items" : {
> "$ref" : "#/components/schemas/ColumnDesc"
> }
> }
> }
> },
> "SeqColumnDesc" : {
> "type" : "array",
> "items" : {
> "$ref" : "#/components/schemas/ColumnDesc"
> }
> },
> "HandleIdentifier" : {
> "required" : [ "publicId" ],
> "type" : "object",
> "properties" : {
> "publicId" : {
> "type" : "string",
> "format" : "uuid"
> },
> "secretId" : {
> "type" : "string",
> "format" : "uuid"
> }
> }
> },
> "OperationHandle" : {
> "required" : [ "hasResultSet", "identifier", "protocol", "typ" ],
> "type" : "object",
> "properties" : {
> "identifier" : {
> "$ref" : "#/components/schemas/HandleIdentifier"
> },
> "typ" : {
> "$ref" : "#/components/schemas/Value"
> },
> "protocol" : {
> "type" : "string",
> "enum" : [ "HIVE_CLI_SERVICE_PROTOCOL_V1", "HIVE_CLI_SERVICE_PROTOCOL_V2", "HIVE_CLI_SERVICE_PROTOCOL_V3", "HIVE_CLI_SERVICE_PROTOCOL_V4", "HIVE_CLI_SERVICE_PROTOCOL_V5", "HIVE_CLI_SERVICE_PROTOCOL_V6", "HIVE_CLI_SERVICE_PROTOCOL_V7", "HIVE_CLI_SERVICE_PROTOCOL_V8", "HIVE_CLI_SERVICE_PROTOCOL_V9", "HIVE_CLI_SERVICE_PROTOCOL_V10" ]
> },
> "hasResultSet" : {
> "type" : "boolean",
> "writeOnly" : true
> }
> }
> },
> "Value" : {
> "type" : "object"
> },
> "ExecPoolStatistic" : {
> "required" : [ "execPoolSize" ],
> "type" : "object",
> "properties" : {
> "execPoolSize" : {
> "type" : "integer",
> "format" : "int32"
> },
> "execPoolActiveCount" : {
> "type" : "integer",
> "format" : "int32"
> }
> }
> },
> "StatementRequest" : {
> "required" : [ "queryTimeout", "runAsync", "statement" ],
> "type" : "object",
> "properties" : {
> "statement" : {
> "type" : "string"
> },
> "runAsync" : {
> "type" : "boolean"
> },
> "queryTimeout" : {
> "type" : "integer",
> "format" : "int64"
> }
> }
> },
> "GetColumnsRequest" : {
> "required" : [ "catalogName" ],
> "type" : "object",
> "properties" : {
> "catalogName" : {
> "type" : "string"
> },
> "schemaName" : {
> "type" : "string"
> },
> "tableName" : {
> "type" : "string"
> },
> "columnName" : {
> "type" : "string"
> }
> }
> },
> "GetFunctionsRequest" : {
> "required" : [ "catalogName" ],
> "type" : "object",
> "properties" : {
> "catalogName" : {
> "type" : "string"
> },
> "schemaName" : {
> "type" : "string"
> },
> "functionName" : {
> "type" : "string"
> }
> }
> },
> "InfoDetail" : {
> "required" : [ "infoType" ],
> "type" : "object",
> "properties" : {
> "infoType" : {
> "type" : "string"
> },
> "infoValue" : {
> "type" : "string"
> }
> }
> },
> "GetSchemasRequest" : {
> "required" : [ "catalogName" ],
> "type" : "object",
> "properties" : {
> "catalogName" : {
> "type" : "string"
> },
> "schemaName" : {
> "type" : "string"
> }
> }
> },
> "GetTablesRequest" : {
> "required" : [ "catalogName", "tableTypes" ],
> "type" : "object",
> "properties" : {
> "catalogName" : {
> "type" : "string"
> },
> "schemaName" : {
> "type" : "string"
> },
> "tableName" : {
> "type" : "string"
> },
> "tableTypes" : {
> "type" : "array",
> "items" : {
> "type" : "string"
> }
> }
> }
> },
> "SessionHandle" : {
> "required" : [ "identifier", "protocol" ],
> "type" : "object",
> "properties" : {
> "identifier" : {
> "$ref" : "#/components/schemas/HandleIdentifier"
> },
> "protocol" : {
> "type" : "string",
> "enum" : [ "HIVE_CLI_SERVICE_PROTOCOL_V1", "HIVE_CLI_SERVICE_PROTOCOL_V2", "HIVE_CLI_SERVICE_PROTOCOL_V3", "HIVE_CLI_SERVICE_PROTOCOL_V4", "HIVE_CLI_SERVICE_PROTOCOL_V5", "HIVE_CLI_SERVICE_PROTOCOL_V6", "HIVE_CLI_SERVICE_PROTOCOL_V7", "HIVE_CLI_SERVICE_PROTOCOL_V8", "HIVE_CLI_SERVICE_PROTOCOL_V9", "HIVE_CLI_SERVICE_PROTOCOL_V10" ]
> }
> }
> },
> "MapStringString" : {
> "type" : "object",
> "additionalProperties" : {
> "type" : "string"
> }
> },
> "SessionOpenRequest" : {
> "required" : [ "configs", "protocolVersion", "user" ],
> "type" : "object",
> "properties" : {
> "protocolVersion" : {
> "type" : "integer",
> "format" : "int32"
> },
> "user" : {
> "type" : "string"
> },
> "password" : {
> "type" : "string"
> },
> "ipAddr" : {
> "type" : "string"
> },
> "configs" : {
> "type" : "object",
> "additionalProperties" : {
> "type" : "string"
> }
> }
> }
> },
> "SessionOpenCount" : {
> "required" : [ "openSessionCount" ],
> "type" : "object",
> "properties" : {
> "openSessionCount" : {
> "type" : "integer",
> "format" : "int32"
> }
> }
> },
> "KyuubiSessionEvent" : {
> "required" : [ "clientVersion", "conf", "sessionId", "startTime" ],
> "type" : "object",
> "properties" : {
> "sessionId" : {
> "type" : "string"
> },
> "clientVersion" : {
> "type" : "integer",
> "format" : "int32"
> },
> "sessionName" : {
> "type" : "string"
> },
> "user" : {
> "type" : "string"
> },
> "clientIP" : {
> "type" : "string"
> },
> "serverIP" : {
> "type" : "string"
> },
> "conf" : {
> "type" : "object",
> "additionalProperties" : {
> "type" : "string"
> }
> },
> "startTime" : {
> "type" : "integer",
> "format" : "int64"
> },
> "remoteSessionId" : {
> "type" : "string"
> },
> "engineId" : {
> "type" : "string"
> },
> "openedTime" : {
> "type" : "integer",
> "format" : "int64"
> },
> "endTime" : {
> "type" : "integer",
> "format" : "int64"
> },
> "totalOperations" : {
> "type" : "integer",
> "format" : "int32"
> },
> "eventType" : {
> "type" : "string"
> }
> }
> },
> "SeqSessionOverview" : {
> "type" : "array",
> "items" : {
> "$ref" : "#/components/schemas/SessionOverview"
> }
> },
> "SessionList" : {
> "required" : [ "sessionList" ],
> "type" : "object",
> "properties" : {
> "sessionList" : {
> "type" : "array",
> "items" : {
> "$ref" : "#/components/schemas/SessionOverview"
> }
> }
> }
> },
> "SessionOverview" : {
> "required" : [ "createTime", "user" ],
> "type" : "object",
> "properties" : {
> "user" : {
> "type" : "string"
> },
> "ipAddr" : {
> "type" : "string"
> },
> "createTime" : {
> "type" : "integer",
> "format" : "int64"
> },
> "sessionHandle" : {
> "$ref" : "#/components/schemas/SessionHandle"
> }
> }
> }
> }
> }
> ```
can we inline some logic for that, that module seems on have one class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on pull request #1658: Revamp swagger ui dependencies
Posted by GitBox <gi...@apache.org>.
pan3793 commented on pull request #1658:
URL: https://github.com/apache/incubator-kyuubi/pull/1658#issuecomment-1002993469
Always happy to see reducing dependencies
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] cfmcgrady commented on pull request #1658: Revamp swagger ui dependencies
Posted by GitBox <gi...@apache.org>.
cfmcgrady commented on pull request #1658:
URL: https://github.com/apache/incubator-kyuubi/pull/1658#issuecomment-1003244581
Sorry for the later review, @yaooqinn
> This PR mainly removes the swagger-scala-module which is currently fine to remove.
This is a breaking change for openapi. `swagger-scala-module` is a library that automatically generates a schema from a Scala case class.
After this PR
```json
"components" : {
"schemas" : {
"OpActionRequest" : {
"type" : "object"
},
"KyuubiOperationEvent" : {
"type" : "object"
},
"OperationLog" : {
"type" : "object"
},
"ResultSetMetaData" : {
"type" : "object"
},
"OperationHandle" : {
"type" : "object",
"properties" : {
"hasResultSet" : {
"type" : "boolean",
"writeOnly" : true
}
}
},
"ExecPoolStatistic" : {
"type" : "object"
},
"StatementRequest" : {
"type" : "object"
},
"GetColumnsRequest" : {
"type" : "object"
},
"GetFunctionsRequest" : {
"type" : "object"
},
"InfoDetail" : {
"type" : "object"
},
"GetSchemasRequest" : {
"type" : "object"
},
"GetTablesRequest" : {
"type" : "object"
},
"SessionHandle" : {
"type" : "object"
},
"SessionOpenRequest" : {
"type" : "object"
},
"SessionOpenCount" : {
"type" : "object"
},
"KyuubiSessionEvent" : {
"type" : "object"
},
"SessionList" : {
"type" : "object"
}
}
}
```
Before this PR
```json
"components" : {
"schemas" : {
"OpActionRequest" : {
"required" : [ "action" ],
"type" : "object",
"properties" : {
"action" : {
"type" : "string"
}
}
},
"KyuubiOperationEvent" : {
"required" : [ "eventTime", "shouldRunAsync", "statementId" ],
"type" : "object",
"properties" : {
"statementId" : {
"type" : "string"
},
"remoteId" : {
"type" : "string"
},
"statement" : {
"type" : "string"
},
"shouldRunAsync" : {
"type" : "boolean"
},
"state" : {
"type" : "string"
},
"eventTime" : {
"type" : "integer",
"format" : "int64"
},
"createTime" : {
"type" : "integer",
"format" : "int64"
},
"startTime" : {
"type" : "integer",
"format" : "int64"
},
"completeTime" : {
"type" : "integer",
"format" : "int64"
},
"exception" : {
"type" : "object",
"properties" : {
"cause" : {
"required" : [ "stackTrace", "suppressed" ],
"type" : "object",
"properties" : {
"stackTrace" : {
"type" : "array",
"items" : {
"required" : [ "lineNumber" ],
"type" : "object",
"properties" : {
"methodName" : {
"type" : "string"
},
"fileName" : {
"type" : "string"
},
"lineNumber" : {
"type" : "integer",
"format" : "int32"
},
"className" : {
"type" : "string"
},
"nativeMethod" : {
"type" : "boolean"
}
}
}
},
"message" : {
"type" : "string"
},
"localizedMessage" : {
"type" : "string"
},
"suppressed" : {
"type" : "array",
"items" : {
"type" : "object",
"properties" : {
"stackTrace" : {
"type" : "array",
"items" : {
"required" : [ "lineNumber" ],
"type" : "object",
"properties" : {
"methodName" : {
"type" : "string"
},
"fileName" : {
"type" : "string"
},
"lineNumber" : {
"type" : "integer",
"format" : "int32"
},
"className" : {
"type" : "string"
},
"nativeMethod" : {
"type" : "boolean"
}
}
}
},
"message" : {
"type" : "string"
},
"localizedMessage" : {
"type" : "string"
}
}
}
}
}
},
"stackTrace" : {
"type" : "array",
"items" : {
"required" : [ "lineNumber" ],
"type" : "object",
"properties" : {
"methodName" : {
"type" : "string"
},
"fileName" : {
"type" : "string"
},
"lineNumber" : {
"type" : "integer",
"format" : "int32"
},
"className" : {
"type" : "string"
},
"nativeMethod" : {
"type" : "boolean"
}
}
}
},
"message" : {
"type" : "string"
},
"localizedMessage" : {
"type" : "string"
},
"suppressed" : {
"type" : "array",
"items" : {
"type" : "object",
"properties" : {
"stackTrace" : {
"type" : "array",
"items" : {
"required" : [ "lineNumber" ],
"type" : "object",
"properties" : {
"methodName" : {
"type" : "string"
},
"fileName" : {
"type" : "string"
},
"lineNumber" : {
"type" : "integer",
"format" : "int32"
},
"className" : {
"type" : "string"
},
"nativeMethod" : {
"type" : "boolean"
}
}
}
},
"message" : {
"type" : "string"
},
"localizedMessage" : {
"type" : "string"
}
}
}
}
}
},
"sessionId" : {
"type" : "string"
},
"sessionUser" : {
"type" : "string"
},
"eventType" : {
"type" : "string"
}
}
},
"OperationLog" : {
"required" : [ "logRowSet", "rowCount" ],
"type" : "object",
"properties" : {
"logRowSet" : {
"type" : "array",
"items" : {
"type" : "string"
}
},
"rowCount" : {
"type" : "integer",
"format" : "int32"
}
}
},
"SeqString" : {
"type" : "array",
"items" : {
"type" : "string"
}
},
"ColumnDesc" : {
"required" : [ "columnIndex", "columnName" ],
"type" : "object",
"properties" : {
"columnName" : {
"type" : "string"
},
"dataType" : {
"type" : "string"
},
"columnIndex" : {
"type" : "integer",
"format" : "int32"
},
"precision" : {
"type" : "integer",
"format" : "int32"
},
"scale" : {
"type" : "integer",
"format" : "int32"
},
"comment" : {
"type" : "string"
}
}
},
"ResultSetMetaData" : {
"required" : [ "columns" ],
"type" : "object",
"properties" : {
"columns" : {
"type" : "array",
"items" : {
"$ref" : "#/components/schemas/ColumnDesc"
}
}
}
},
"SeqColumnDesc" : {
"type" : "array",
"items" : {
"$ref" : "#/components/schemas/ColumnDesc"
}
},
"HandleIdentifier" : {
"required" : [ "publicId" ],
"type" : "object",
"properties" : {
"publicId" : {
"type" : "string",
"format" : "uuid"
},
"secretId" : {
"type" : "string",
"format" : "uuid"
}
}
},
"OperationHandle" : {
"required" : [ "hasResultSet", "identifier", "protocol", "typ" ],
"type" : "object",
"properties" : {
"identifier" : {
"$ref" : "#/components/schemas/HandleIdentifier"
},
"typ" : {
"$ref" : "#/components/schemas/Value"
},
"protocol" : {
"type" : "string",
"enum" : [ "HIVE_CLI_SERVICE_PROTOCOL_V1", "HIVE_CLI_SERVICE_PROTOCOL_V2", "HIVE_CLI_SERVICE_PROTOCOL_V3", "HIVE_CLI_SERVICE_PROTOCOL_V4", "HIVE_CLI_SERVICE_PROTOCOL_V5", "HIVE_CLI_SERVICE_PROTOCOL_V6", "HIVE_CLI_SERVICE_PROTOCOL_V7", "HIVE_CLI_SERVICE_PROTOCOL_V8", "HIVE_CLI_SERVICE_PROTOCOL_V9", "HIVE_CLI_SERVICE_PROTOCOL_V10" ]
},
"hasResultSet" : {
"type" : "boolean",
"writeOnly" : true
}
}
},
"Value" : {
"type" : "object"
},
"ExecPoolStatistic" : {
"required" : [ "execPoolSize" ],
"type" : "object",
"properties" : {
"execPoolSize" : {
"type" : "integer",
"format" : "int32"
},
"execPoolActiveCount" : {
"type" : "integer",
"format" : "int32"
}
}
},
"StatementRequest" : {
"required" : [ "queryTimeout", "runAsync", "statement" ],
"type" : "object",
"properties" : {
"statement" : {
"type" : "string"
},
"runAsync" : {
"type" : "boolean"
},
"queryTimeout" : {
"type" : "integer",
"format" : "int64"
}
}
},
"GetColumnsRequest" : {
"required" : [ "catalogName" ],
"type" : "object",
"properties" : {
"catalogName" : {
"type" : "string"
},
"schemaName" : {
"type" : "string"
},
"tableName" : {
"type" : "string"
},
"columnName" : {
"type" : "string"
}
}
},
"GetFunctionsRequest" : {
"required" : [ "catalogName" ],
"type" : "object",
"properties" : {
"catalogName" : {
"type" : "string"
},
"schemaName" : {
"type" : "string"
},
"functionName" : {
"type" : "string"
}
}
},
"InfoDetail" : {
"required" : [ "infoType" ],
"type" : "object",
"properties" : {
"infoType" : {
"type" : "string"
},
"infoValue" : {
"type" : "string"
}
}
},
"GetSchemasRequest" : {
"required" : [ "catalogName" ],
"type" : "object",
"properties" : {
"catalogName" : {
"type" : "string"
},
"schemaName" : {
"type" : "string"
}
}
},
"GetTablesRequest" : {
"required" : [ "catalogName", "tableTypes" ],
"type" : "object",
"properties" : {
"catalogName" : {
"type" : "string"
},
"schemaName" : {
"type" : "string"
},
"tableName" : {
"type" : "string"
},
"tableTypes" : {
"type" : "array",
"items" : {
"type" : "string"
}
}
}
},
"SessionHandle" : {
"required" : [ "identifier", "protocol" ],
"type" : "object",
"properties" : {
"identifier" : {
"$ref" : "#/components/schemas/HandleIdentifier"
},
"protocol" : {
"type" : "string",
"enum" : [ "HIVE_CLI_SERVICE_PROTOCOL_V1", "HIVE_CLI_SERVICE_PROTOCOL_V2", "HIVE_CLI_SERVICE_PROTOCOL_V3", "HIVE_CLI_SERVICE_PROTOCOL_V4", "HIVE_CLI_SERVICE_PROTOCOL_V5", "HIVE_CLI_SERVICE_PROTOCOL_V6", "HIVE_CLI_SERVICE_PROTOCOL_V7", "HIVE_CLI_SERVICE_PROTOCOL_V8", "HIVE_CLI_SERVICE_PROTOCOL_V9", "HIVE_CLI_SERVICE_PROTOCOL_V10" ]
}
}
},
"MapStringString" : {
"type" : "object",
"additionalProperties" : {
"type" : "string"
}
},
"SessionOpenRequest" : {
"required" : [ "configs", "protocolVersion", "user" ],
"type" : "object",
"properties" : {
"protocolVersion" : {
"type" : "integer",
"format" : "int32"
},
"user" : {
"type" : "string"
},
"password" : {
"type" : "string"
},
"ipAddr" : {
"type" : "string"
},
"configs" : {
"type" : "object",
"additionalProperties" : {
"type" : "string"
}
}
}
},
"SessionOpenCount" : {
"required" : [ "openSessionCount" ],
"type" : "object",
"properties" : {
"openSessionCount" : {
"type" : "integer",
"format" : "int32"
}
}
},
"KyuubiSessionEvent" : {
"required" : [ "clientVersion", "conf", "sessionId", "startTime" ],
"type" : "object",
"properties" : {
"sessionId" : {
"type" : "string"
},
"clientVersion" : {
"type" : "integer",
"format" : "int32"
},
"sessionName" : {
"type" : "string"
},
"user" : {
"type" : "string"
},
"clientIP" : {
"type" : "string"
},
"serverIP" : {
"type" : "string"
},
"conf" : {
"type" : "object",
"additionalProperties" : {
"type" : "string"
}
},
"startTime" : {
"type" : "integer",
"format" : "int64"
},
"remoteSessionId" : {
"type" : "string"
},
"engineId" : {
"type" : "string"
},
"openedTime" : {
"type" : "integer",
"format" : "int64"
},
"endTime" : {
"type" : "integer",
"format" : "int64"
},
"totalOperations" : {
"type" : "integer",
"format" : "int32"
},
"eventType" : {
"type" : "string"
}
}
},
"SeqSessionOverview" : {
"type" : "array",
"items" : {
"$ref" : "#/components/schemas/SessionOverview"
}
},
"SessionList" : {
"required" : [ "sessionList" ],
"type" : "object",
"properties" : {
"sessionList" : {
"type" : "array",
"items" : {
"$ref" : "#/components/schemas/SessionOverview"
}
}
}
},
"SessionOverview" : {
"required" : [ "createTime", "user" ],
"type" : "object",
"properties" : {
"user" : {
"type" : "string"
},
"ipAddr" : {
"type" : "string"
},
"createTime" : {
"type" : "integer",
"format" : "int64"
},
"sessionHandle" : {
"$ref" : "#/components/schemas/SessionHandle"
}
}
}
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] ulysses-you closed pull request #1658: Revamp swagger ui dependencies
Posted by GitBox <gi...@apache.org>.
ulysses-you closed pull request #1658:
URL: https://github.com/apache/incubator-kyuubi/pull/1658
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] ulysses-you commented on a change in pull request #1658: Revamp swagger ui dependencies
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on a change in pull request #1658:
URL: https://github.com/apache/incubator-kyuubi/pull/1658#discussion_r776685486
##########
File path: pom.xml
##########
@@ -670,17 +669,10 @@
<groupId>io.swagger.core.v3</groupId>
<artifactId>swagger-jaxrs2</artifactId>
<version>${swagger.version}</version>
- </dependency>
-
- <!-- ref: https://github.com/swagger-akka-http/swagger-scala-module -->
- <dependency>
- <groupId>com.github.swagger-akka-http</groupId>
- <artifactId>swagger-scala-module_${scala.binary.version}</artifactId>
- <version>${swagger.scala.module.version}</version>
Review comment:
Is it we do not use `Option` type as the value of annotation, so we can remove this dependency safely ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org