You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/05/24 09:06:24 UTC
[GitHub] [hudi] bhasudha opened a new pull request #1659: [HUDI-936] Fix fetch ordering val in HoodieSparkSqlWriter to remove u…
bhasudha opened a new pull request #1659:
URL: https://github.com/apache/hudi/pull/1659
…nnecessary conversion to String
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contributing.html before opening a pull request.*
## What is the purpose of the pull request
*(For example: This pull request adds quick-start document.)*
## Brief change log
*(for example:)*
- *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [x] Has a corresponding JIRA in PR title & commit
- [x] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] vinothchandar merged pull request #1659: [HUDI-936] Fix fetch ordering val in HoodieSparkSqlWriter to remove u…
Posted by GitBox <gi...@apache.org>.
vinothchandar merged pull request #1659:
URL: https://github.com/apache/hudi/pull/1659
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] leesf commented on pull request #1659: [HUDI-936] Fix fetch ordering val in HoodieSparkSqlWriter to remove u…
Posted by GitBox <gi...@apache.org>.
leesf commented on pull request #1659:
URL: https://github.com/apache/hudi/pull/1659#issuecomment-634114232
travis is very fragile recently and restarted.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codecov-commenter commented on pull request #1659: [HUDI-936] Fix fetch ordering val in HoodieSparkSqlWriter to remove u…
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1659:
URL: https://github.com/apache/hudi/pull/1659#issuecomment-634135220
# [Codecov](https://codecov.io/gh/apache/hudi/pull/1659?src=pr&el=h1) Report
> Merging [#1659](https://codecov.io/gh/apache/hudi/pull/1659?src=pr&el=desc) into [master](https://codecov.io/gh/apache/hudi/commit/d3edac4612bde2fa9deca9536801dbc48961fb95&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/hudi/pull/1659?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1659 +/- ##
============================================
- Coverage 18.22% 18.21% -0.02%
+ Complexity 857 856 -1
============================================
Files 348 348
Lines 15332 15331 -1
Branches 1523 1523
============================================
- Hits 2795 2792 -3
- Misses 12180 12182 +2
Partials 357 357
```
| [Impacted Files](https://codecov.io/gh/apache/hudi/pull/1659?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...n/scala/org/apache/hudi/HoodieSparkSqlWriter.scala](https://codecov.io/gh/apache/hudi/pull/1659/diff?src=pr&el=tree#diff-aHVkaS1zcGFyay9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2h1ZGkvSG9vZGllU3BhcmtTcWxXcml0ZXIuc2NhbGE=) | `47.59% <100.00%> (-0.32%)` | `0.00 <0.00> (ø)` | |
| [...apache/hudi/common/fs/HoodieWrapperFileSystem.java](https://codecov.io/gh/apache/hudi/pull/1659/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0hvb2RpZVdyYXBwZXJGaWxlU3lzdGVtLmphdmE=) | `21.98% <0.00%> (-0.71%)` | `28.00% <0.00%> (-1.00%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/hudi/pull/1659?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/hudi/pull/1659?src=pr&el=footer). Last update [d3edac4...b9840db](https://codecov.io/gh/apache/hudi/pull/1659?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codecov-commenter edited a comment on pull request #1659: [HUDI-936] Fix fetch ordering val in HoodieSparkSqlWriter to remove u…
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1659:
URL: https://github.com/apache/hudi/pull/1659#issuecomment-634135220
# [Codecov](https://codecov.io/gh/apache/hudi/pull/1659?src=pr&el=h1) Report
> Merging [#1659](https://codecov.io/gh/apache/hudi/pull/1659?src=pr&el=desc) into [master](https://codecov.io/gh/apache/hudi/commit/d3edac4612bde2fa9deca9536801dbc48961fb95&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/hudi/pull/1659?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1659 +/- ##
============================================
- Coverage 18.22% 18.21% -0.02%
+ Complexity 857 856 -1
============================================
Files 348 348
Lines 15332 15331 -1
Branches 1523 1523
============================================
- Hits 2795 2792 -3
- Misses 12180 12182 +2
Partials 357 357
```
| [Impacted Files](https://codecov.io/gh/apache/hudi/pull/1659?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...n/scala/org/apache/hudi/HoodieSparkSqlWriter.scala](https://codecov.io/gh/apache/hudi/pull/1659/diff?src=pr&el=tree#diff-aHVkaS1zcGFyay9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2h1ZGkvSG9vZGllU3BhcmtTcWxXcml0ZXIuc2NhbGE=) | `47.59% <100.00%> (-0.32%)` | `0.00 <0.00> (ø)` | |
| [...apache/hudi/common/fs/HoodieWrapperFileSystem.java](https://codecov.io/gh/apache/hudi/pull/1659/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0hvb2RpZVdyYXBwZXJGaWxlU3lzdGVtLmphdmE=) | `21.98% <0.00%> (-0.71%)` | `28.00% <0.00%> (-1.00%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/hudi/pull/1659?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/hudi/pull/1659?src=pr&el=footer). Last update [d3edac4...b9840db](https://codecov.io/gh/apache/hudi/pull/1659?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org