[GitHub] [iceberg] JonasJ-ap commented on a diff in pull request #7299: Support case insensitive id assignment for applyNameMapping when reading parquet

["JonasJ-ap (via GitHub)" <gi...@apache.org>]

JonasJ-ap commented on code in PR #7299:
URL: https://github.com/apache/iceberg/pull/7299#discussion_r1164736364


##########
parquet/src/test/java/org/apache/iceberg/parquet/TestParquetSchemaUtil.java:
##########
@@ -127,6 +127,33 @@ public void testAssignIdsByNameMapping() {
     Assert.assertEquals(messageTypeWithIds, messageTypeWithIdsFromNameMapping);
   }
 
+  @Test
+  public void testAssignIdsByNameMappingCaseInsensitive() {
+    Types.StructType structTypeLowerCase =
+        Types.StructType.of(required(0, "id", Types.LongType.get()));

Review Comment:
   Would it be worth testing on more complex schema to thoroughly evaluate the performance? By 'complex,' I mean a nested schema that contains fields such as `list_of_struct_of_nested_types.m1.id`. We could potentially modify the existing schema to include these fields. I'd love to hear your thoughts on this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org