[GitHub] [cassandra] yukim commented on pull request #2372: CASSANDRA-18554 Adding Mutual Tls authenticators for client & internode connections

["yukim (via GitHub)" <gi...@apache.org>]

yukim commented on PR #2372:
URL: https://github.com/apache/cassandra/pull/2372#issuecomment-1612376590

   Hi @jyothsnakonisa 
   
   Shouldn't we change the condition here so Cassandra does not log confusing message to the user of mTLS auth?
   
   ```java
           if (!(authenticator instanceof PasswordAuthenticator)
               && (conf.credentials_update_interval != null
                   || conf.credentials_validity.toMilliseconds() != 2000
                   || conf.credentials_cache_max_entries != 1000))
           {
               logger.info("Configuration options credentials_update_interval, credentials_validity and " +
                           "credentials_cache_max_entries may not be applicable for the configured authenticator ({})",
                           authenticator.getClass().getName());
           }
   
   ```
   https://github.com/apache/cassandra/pull/2372/files#diff-6cb647a8107efc82a7abdd3639ea1da0d2e58feb37350770bd29fe09ac46f687R64-R72


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org