You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "AngersZhuuuu (via GitHub)" <gi...@apache.org> on 2023/06/14 09:11:47 UTC
[GitHub] [incubator-celeborn] AngersZhuuuu opened a new pull request, #1593: [CELEBORN-681][DOC] Add celeborn.metrics.conf to conf entity
AngersZhuuuu opened a new pull request, #1593:
URL: https://github.com/apache/incubator-celeborn/pull/1593
### What changes were proposed in this pull request?
Add celeborn.metrics.conf to conf entity
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
### How was this patch tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 commented on a diff in pull request #1593: [CELEBORN-681][DOC] Add celeborn.metrics.conf to conf entity
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #1593:
URL: https://github.com/apache/incubator-celeborn/pull/1593#discussion_r1229318306
##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -3168,6 +3169,14 @@ object CelebornConf extends Logging {
.stringConf
.createOptional
+ val METRICS_CONF: OptionalConfigEntry[String] =
+ buildConf("celeborn.metrics.conf")
+ .categories("metrics")
+ .doc("Customize metrics conf path.")
Review Comment:
```suggestion
.doc("Custom metrics configuration file path. Default use `metrics.properties` in classpath.")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] AngersZhuuuu closed pull request #1593: [CELEBORN-681][DOC] Add celeborn.metrics.conf to conf entity
Posted by "AngersZhuuuu (via GitHub)" <gi...@apache.org>.
AngersZhuuuu closed pull request #1593: [CELEBORN-681][DOC] Add celeborn.metrics.conf to conf entity
URL: https://github.com/apache/incubator-celeborn/pull/1593
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] AngersZhuuuu commented on pull request #1593: [CELEBORN-681][DOC] Add celeborn.metrics.conf to conf entity
Posted by "AngersZhuuuu (via GitHub)" <gi...@apache.org>.
AngersZhuuuu commented on PR #1593:
URL: https://github.com/apache/incubator-celeborn/pull/1593#issuecomment-1590808206
ping @pan3793
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] AngersZhuuuu commented on a diff in pull request #1593: [CELEBORN-681][DOC] Add celeborn.metrics.conf to conf entity
Posted by "AngersZhuuuu (via GitHub)" <gi...@apache.org>.
AngersZhuuuu commented on code in PR #1593:
URL: https://github.com/apache/incubator-celeborn/pull/1593#discussion_r1229326056
##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -3168,6 +3169,14 @@ object CelebornConf extends Logging {
.stringConf
.createOptional
+ val METRICS_CONF: OptionalConfigEntry[String] =
+ buildConf("celeborn.metrics.conf")
+ .categories("metrics")
+ .doc("Customize metrics conf path.")
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1593: [CELEBORN-681][DOC] Add celeborn.metrics.conf to conf entity
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #1593:
URL: https://github.com/apache/incubator-celeborn/pull/1593#issuecomment-1590827888
## [Codecov](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1593?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#1593](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1593?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (707a72f) into [main](https://app.codecov.io/gh/apache/incubator-celeborn/commit/da853473302d4df793f3d5d60a211b948c1b9997?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (da85347) will **decrease** coverage by `0.14%`.
> The diff coverage is `62.50%`.
```diff
@@ Coverage Diff @@
## main #1593 +/- ##
==========================================
- Coverage 45.66% 45.51% -0.14%
==========================================
Files 158 158
Lines 9859 9864 +5
Branches 969 969
==========================================
- Hits 4501 4489 -12
- Misses 5059 5074 +15
- Partials 299 301 +2
```
| [Impacted Files](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1593?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/celeborn/common/metrics/MetricsConfig.scala](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1593?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vY29tbW9uL21ldHJpY3MvTWV0cmljc0NvbmZpZy5zY2FsYQ==) | `0.00% <0.00%> (ø)` | |
| [...cala/org/apache/celeborn/common/CelebornConf.scala](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1593?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vY29tbW9uL0NlbGVib3JuQ29uZi5zY2FsYQ==) | `87.12% <83.34%> (-<0.01%)` | :arrow_down: |
... and [2 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1593/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org