You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/08/30 06:10:39 UTC
[GitHub] [incubator-seatunnel] kalencaya commented on a diff in pull request #2543: [Bug][flink-connector-elasticsearch7]sink failure caused by deprecated TransportClient
kalencaya commented on code in PR #2543:
URL: https://github.com/apache/incubator-seatunnel/pull/2543#discussion_r958043155
##########
seatunnel-connectors/seatunnel-connectors-flink/seatunnel-connector-flink-elasticsearch7/src/main/java/org/apache/seatunnel/flink/elasticsearch/sink/ElasticsearchOutputFormat.java:
##########
@@ -64,27 +62,14 @@ public ElasticsearchOutputFormat(Config userConfig, ElasticsearchSinkFunction<T>
@Override
public void configure(Configuration configuration) {
List<String> hosts = config.getStringList(HOSTS);
- Settings.Builder settings = Settings.builder();
-
- config.entrySet().forEach(entry -> {
Review Comment:
Elasticsearch will not support settings on rest client, neither 7.x RestHighLevelClient or 8.x ElasticsearchClient, for what all them based on RestClient doesn't support it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org