[jira] [Commented] (IMPALA-6628) Use unqualified table references in .test files run from test_queries.py

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IMPALA-6628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17218136#comment-17218136 ] 

ASF subversion and git services commented on IMPALA-6628:
---------------------------------------------------------

Commit 6dbf1ca09c9d8b53a0d37d9201508847e3247283 in impala's branch refs/heads/master from Qifan Chen
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=6dbf1ca ]

IMPALA-6628: Use unqualified table references in .test files run from test_queries.py

This fix modified the following tests launched from test_queries.py by
removing references to database 'functional' whenever possible. The
objective of the change is to allow more testing coverage with different
databases than the single 'functional' database. In the fix, neither new
tables were added nor expected results were altered.

  empty.test
  inline-view-limit.test
  inline-view.test
  limit.test
  misc.test
  sort.test
  subquery-single-node.test
  subquery.test
  top-n.test
  union.test
  with-clause.test

It was determined that other tests in
testdata/workloads/functional-query/queries/QueryTest do not refer to
'functional' or the references are a must for some reason.

Testing
   Ran query_tests on these changed tests with exhaustive exploration
   strategy.

Change-Id: Idd50eaaaba25e3bedc2b30592a314d2b6b83f972
Reviewed-on: http://gerrit.cloudera.org:8080/16603
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>


> Use unqualified table references in .test files run from test_queries.py
> ------------------------------------------------------------------------
>
>                 Key: IMPALA-6628
>                 URL: https://issues.apache.org/jira/browse/IMPALA-6628
>             Project: IMPALA
>          Issue Type: Improvement
>          Components: Infrastructure
>            Reporter: Alexander Behm
>            Assignee: Qifan Chen
>            Priority: Major
>
> To increase our test coverage over different file formats we should go through the .test files referenced from test_queries.py and switch to using unqualified table references where possible.
> The state today is that in the exhaustive exploration strategy we run every .test file once for every file format. However, since many .test use fully-qualified table references we are not actually getting coverage over all formats, so we are spending the time to run the tests but not getting the coverage we'd like.
> I skimmed a few files and identified that at least these could be improved:
> analytic-fns.test
> subquery.test
> limit.test
> top-n.test
> Likely there are more .test files. Probably there are similar issues in different .py files as well, but to keep this JIRA focused I propose we focus on test_queries.py first.
> *What to do*
> * Go through the .test files and change fully-qualified table references to unqualified table references where possible. Our test framework issues a "use <database" before running each such test. Different databases have different file formats.
> * Example: The fully-qualified table reference "functional.alltypes" should be changed to an unqualified table reference "alltypes"
> * Make sure the tests pass in exhaustive



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org