You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2017/07/05 11:08:53 UTC
Review Request 60652: Bundled rake as part of managed ruby
dependencies of website.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60652/
-----------------------------------------------------------
Review request for mesos, haosdent huang and Vinod Kone.
Repository: mesos
Description
-------
While rake is available from the package manager on some flavors of
Linux, on e.g., macOS seems to currently only be available as a gem.
In order to provide a working website environment with minimal extra
configuration, bundle rake with bundler as well.
We also update the existing website tooling to use the now bundled
version of rake.
Diffs
-----
site/Dockerfile 8ba0be0c28e924f7a2b89e6e5a3237deb3751a41
site/Gemfile 4dcd0a5ad452085e6e3bb152a6547575636cd807
site/Gemfile.lock 1393246f06631155bb052669a86e431778e891bf
site/build.sh 11f15e15621c4d3db1472e88911787b9b3100f97
Diff: https://reviews.apache.org/r/60652/diff/1/
Testing
-------
`bundle install && bundle exec rake && bundle exec rake dev` on macOS.
Thanks,
Benjamin Bannier
Re: Review Request 60652: Bundled rake as part of managed ruby
dependencies of website.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60652/#review179711
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On July 5, 2017, 11:08 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60652/
> -----------------------------------------------------------
>
> (Updated July 5, 2017, 11:08 a.m.)
>
>
> Review request for mesos, haosdent huang and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> While rake is available from the package manager on some flavors of
> Linux, on e.g., macOS seems to currently only be available as a gem.
> In order to provide a working website environment with minimal extra
> configuration, bundle rake with bundler as well.
>
> We also update the existing website tooling to use the now bundled
> version of rake.
>
>
> Diffs
> -----
>
> site/Dockerfile 8ba0be0c28e924f7a2b89e6e5a3237deb3751a41
> site/Gemfile 4dcd0a5ad452085e6e3bb152a6547575636cd807
> site/Gemfile.lock 1393246f06631155bb052669a86e431778e891bf
> site/build.sh 11f15e15621c4d3db1472e88911787b9b3100f97
>
>
> Diff: https://reviews.apache.org/r/60652/diff/1/
>
>
> Testing
> -------
>
> `bundle install && bundle exec rake && bundle exec rake dev` on macOS.
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 60652: Bundled rake as part of managed ruby
dependencies of website.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60652/
-----------------------------------------------------------
(Updated July 5, 2017, 10:09 p.m.)
Review request for mesos, haosdent huang and Vinod Kone.
Changes
-------
Updated review dependency -- @vinodkone
Repository: mesos
Description
-------
While rake is available from the package manager on some flavors of
Linux, on e.g., macOS seems to currently only be available as a gem.
In order to provide a working website environment with minimal extra
configuration, bundle rake with bundler as well.
We also update the existing website tooling to use the now bundled
version of rake.
Diffs
-----
site/Dockerfile 8ba0be0c28e924f7a2b89e6e5a3237deb3751a41
site/Gemfile 4dcd0a5ad452085e6e3bb152a6547575636cd807
site/Gemfile.lock 1393246f06631155bb052669a86e431778e891bf
site/build.sh 11f15e15621c4d3db1472e88911787b9b3100f97
Diff: https://reviews.apache.org/r/60652/diff/1/
Testing
-------
`bundle install && bundle exec rake && bundle exec rake dev` on macOS.
Thanks,
Benjamin Bannier