[GitHub] [incubator-kyuubi] cfmcgrady commented on a change in pull request #986: [KYUUBI #962] Support engine pool feature

[GitBox <gi...@apache.org>]

cfmcgrady commented on a change in pull request #986:
URL: https://github.com/apache/incubator-kyuubi/pull/986#discussion_r695854182



##########
File path: kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala
##########
@@ -572,12 +572,12 @@ object KyuubiConf {
     .checkValues(ShareLevel.values.map(_.toString))
     .createWithDefault(ShareLevel.USER.toString)
 
-  private val validEngineSubDomain: Pattern = "^[a-zA-Z_]{1,10}$".r.pattern
+  private val validEngineSubDomain: Pattern = "^[a-zA-Z_-]{1,14}$".r.pattern
 
   val ENGINE_SHARE_LEVEL_SUB_DOMAIN: OptionalConfigEntry[String] =
     buildConf("engine.share.level.sub.domain")
       .doc("Allow end-users to create a sub-domain for the share level of an engine. A" +
-        " sub-domain is a case-insensitive string values in `^[a-zA-Z_]{1,10}$` form." +
+        " sub-domain is a case-insensitive string values in `^[a-zA-Z_-]{1,14}$` form." +

Review comment:
       We also need to update the error message of `checkValue`.
   
   ```
   "must be [1, 14] length alphabet string, e.g. 'abc', 'apache'"
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org