You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/09/21 10:56:59 UTC
[GitHub] [flink] rmetzger opened a new pull request #13439: [FLINK-19295][yarn][tests] Exclude more meaningless akka shutdown errors
rmetzger opened a new pull request #13439:
URL: https://github.com/apache/flink/pull/13439
## What is the purpose of the change
A test stumbled across some exceptions from Akka's shutdown. This PR is adding them to the whitelist of accepted exceptions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13439: [FLINK-19295][yarn][tests] Exclude more meaningless akka shutdown errors
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13439:
URL: https://github.com/apache/flink/pull/13439#issuecomment-696056061
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c05b38c50eec5ab2aedba11e840bbe74c49b40e4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c05b38c50eec5ab2aedba11e840bbe74c49b40e4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c05b38c50eec5ab2aedba11e840bbe74c49b40e4 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #13439: [FLINK-19295][yarn][tests] Exclude more meaningless akka shutdown errors
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #13439:
URL: https://github.com/apache/flink/pull/13439#discussion_r492539341
##########
File path: flink-yarn-tests/src/test/java/org/apache/flink/yarn/YarnTestBase.java
##########
@@ -128,10 +128,11 @@
// workaround for annoying InterruptedException logging:
// https://issues.apache.org/jira/browse/YARN-1022
"java.lang.InterruptedException",
- // very specific on purpose
+ // very specific on purpose; whitelist meaningless exceptions that occur during akka shutdown:
"Remote connection to [null] failed with java.net.ConnectException: Connection refused",
"Remote connection to [null] failed with java.nio.channels.NotYetConnectedException",
"java.io.IOException: Connection reset by peer",
+ "Caused by: [java.net.ConnectException: Connection refused:",
Review comment:
I'm wondering whether we should rework this to work on `Patterns` instead; then we could also include `akka.remote.ReliableDeliverySupervisor`, or in fact the entire message.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13439: [FLINK-19295][yarn][tests] Exclude more meaningless akka shutdown errors
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13439:
URL: https://github.com/apache/flink/pull/13439#issuecomment-696043639
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit c05b38c50eec5ab2aedba11e840bbe74c49b40e4 (Mon Sep 21 10:59:41 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13439: [FLINK-19295][yarn][tests] Exclude more meaningless akka shutdown errors
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13439:
URL: https://github.com/apache/flink/pull/13439#issuecomment-696056061
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c05b38c50eec5ab2aedba11e840bbe74c49b40e4",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6699",
"triggerID" : "c05b38c50eec5ab2aedba11e840bbe74c49b40e4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c05b38c50eec5ab2aedba11e840bbe74c49b40e4 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6699)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on pull request #13439: [FLINK-19295][yarn][tests] Exclude more meaningless akka shutdown errors
Posted by GitBox <gi...@apache.org>.
rmetzger commented on pull request #13439:
URL: https://github.com/apache/flink/pull/13439#issuecomment-703454812
Thanks a lot for your review. Merging.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger merged pull request #13439: [FLINK-19295][yarn][tests] Exclude more meaningless akka shutdown errors
Posted by GitBox <gi...@apache.org>.
rmetzger merged pull request #13439:
URL: https://github.com/apache/flink/pull/13439
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13439: [FLINK-19295][yarn][tests] Exclude more meaningless akka shutdown errors
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13439:
URL: https://github.com/apache/flink/pull/13439#issuecomment-696056061
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c05b38c50eec5ab2aedba11e840bbe74c49b40e4",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6699",
"triggerID" : "c05b38c50eec5ab2aedba11e840bbe74c49b40e4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c05b38c50eec5ab2aedba11e840bbe74c49b40e4 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6699)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13439: [FLINK-19295][yarn][tests] Exclude more meaningless akka shutdown errors
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13439:
URL: https://github.com/apache/flink/pull/13439#issuecomment-696056061
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c05b38c50eec5ab2aedba11e840bbe74c49b40e4",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6699",
"triggerID" : "c05b38c50eec5ab2aedba11e840bbe74c49b40e4",
"triggerType" : "PUSH"
}, {
"hash" : "60686bf90c2d97578ae3023adc52e5ff8e059b37",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7055",
"triggerID" : "60686bf90c2d97578ae3023adc52e5ff8e059b37",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c05b38c50eec5ab2aedba11e840bbe74c49b40e4 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6699)
* 60686bf90c2d97578ae3023adc52e5ff8e059b37 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7055)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #13439: [FLINK-19295][yarn][tests] Exclude more meaningless akka shutdown errors
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #13439:
URL: https://github.com/apache/flink/pull/13439#discussion_r492539341
##########
File path: flink-yarn-tests/src/test/java/org/apache/flink/yarn/YarnTestBase.java
##########
@@ -128,10 +128,11 @@
// workaround for annoying InterruptedException logging:
// https://issues.apache.org/jira/browse/YARN-1022
"java.lang.InterruptedException",
- // very specific on purpose
+ // very specific on purpose; whitelist meaningless exceptions that occur during akka shutdown:
"Remote connection to [null] failed with java.net.ConnectException: Connection refused",
"Remote connection to [null] failed with java.nio.channels.NotYetConnectedException",
"java.io.IOException: Connection reset by peer",
+ "Caused by: [java.net.ConnectException: Connection refused:",
Review comment:
I'm wondering whether we should rework this to work on `Patterns` instead; then we could also include `akka.remote.ReliableDeliverySupervisor`, or in fact the entire message.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13439: [FLINK-19295][yarn][tests] Exclude more meaningless akka shutdown errors
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13439:
URL: https://github.com/apache/flink/pull/13439#issuecomment-696043639
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13439: [FLINK-19295][yarn][tests] Exclude more meaningless akka shutdown errors
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13439:
URL: https://github.com/apache/flink/pull/13439#issuecomment-696056061
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c05b38c50eec5ab2aedba11e840bbe74c49b40e4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6699",
"triggerID" : "c05b38c50eec5ab2aedba11e840bbe74c49b40e4",
"triggerType" : "PUSH"
}, {
"hash" : "60686bf90c2d97578ae3023adc52e5ff8e059b37",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7055",
"triggerID" : "60686bf90c2d97578ae3023adc52e5ff8e059b37",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 60686bf90c2d97578ae3023adc52e5ff8e059b37 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7055)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13439: [FLINK-19295][yarn][tests] Exclude more meaningless akka shutdown errors
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13439:
URL: https://github.com/apache/flink/pull/13439#issuecomment-696056061
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #13439: [FLINK-19295][yarn][tests] Exclude more meaningless akka shutdown errors
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #13439:
URL: https://github.com/apache/flink/pull/13439#discussion_r496570327
##########
File path: flink-yarn-tests/src/test/java/org/apache/flink/yarn/YarnTestBase.java
##########
@@ -123,26 +124,26 @@
};
/** These strings are white-listed, overriding the prohibited strings. */
- protected static final String[] WHITELISTED_STRINGS = {
- "akka.remote.RemoteTransportExceptionNoStackTrace",
+ protected static final Pattern[] WHITELISTED_STRINGS = {
+ Pattern.compile("akka\\.remote\\.RemoteTransportExceptionNoStackTrace"),
Review comment:
nit: In practice `\\.` is probably not necessary here; chances are slim that another message would manage to match the pattern. You could also pass the `LITERAL` flag for all but the akka message.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13439: [FLINK-19295][yarn][tests] Exclude more meaningless akka shutdown errors
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13439:
URL: https://github.com/apache/flink/pull/13439#issuecomment-696056061
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c05b38c50eec5ab2aedba11e840bbe74c49b40e4",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6699",
"triggerID" : "c05b38c50eec5ab2aedba11e840bbe74c49b40e4",
"triggerType" : "PUSH"
}, {
"hash" : "60686bf90c2d97578ae3023adc52e5ff8e059b37",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "60686bf90c2d97578ae3023adc52e5ff8e059b37",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c05b38c50eec5ab2aedba11e840bbe74c49b40e4 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6699)
* 60686bf90c2d97578ae3023adc52e5ff8e059b37 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org