You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2012/07/24 00:10:34 UTC
Review Request: Added an Allocator::activated to clean up conflating issues
in Allocator::frameworkAdded and made sure we recover executor resources
when a framework is removed.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6097/
-----------------------------------------------------------
Review request for mesos, Thomas Marshall and Vinod Kone.
Description
-------
See summary.
This addresses bug MESOS-239.
https://issues.apache.org/jira/browse/MESOS-239
Diffs
-----
src/master/allocator.hpp e55b9ec
src/master/dominant_share_allocator.hpp bc5505b
src/master/dominant_share_allocator.cpp a2de26f
src/master/master.cpp 43407fa
src/tests/utils.hpp ced8592
Diff: https://reviews.apache.org/r/6097/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request: Added an Allocator::activated to clean up conflating
issues in Allocator::frameworkAdded and made sure we recover executor
resources when a framework is removed.
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On July 23, 2012, 10:30 p.m., Vinod Kone wrote:
> > src/master/allocator.hpp, line 55
> > <https://reviews.apache.org/r/6097/diff/2/?file=127788#file127788line55>
> >
> > We should really have docs for this interface functions. Since many more allocators are going to be written against this.
Agreed.
> On July 23, 2012, 10:30 p.m., Vinod Kone wrote:
> > src/master/dominant_share_allocator.cpp, line 200
> > <https://reviews.apache.org/r/6097/diff/2/?file=127790#file127790line200>
> >
> > CHECK(initialized)
Done.
> On July 23, 2012, 10:30 p.m., Vinod Kone wrote:
> > src/master/dominant_share_allocator.cpp, line 202
> > <https://reviews.apache.org/r/6097/diff/2/?file=127790#file127790line202>
> >
> > new line
Done.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6097/#review9374
-----------------------------------------------------------
On July 23, 2012, 10:10 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6097/
> -----------------------------------------------------------
>
> (Updated July 23, 2012, 10:10 p.m.)
>
>
> Review request for mesos, Thomas Marshall and Vinod Kone.
>
>
> Description
> -------
>
> See summary.
>
>
> This addresses bug MESOS-239.
> https://issues.apache.org/jira/browse/MESOS-239
>
>
> Diffs
> -----
>
> src/master/allocator.hpp e55b9ec
> src/master/dominant_share_allocator.hpp bc5505b
> src/master/dominant_share_allocator.cpp a2de26f
> src/master/master.cpp 43407fa
> src/tests/utils.hpp ced8592
>
> Diff: https://reviews.apache.org/r/6097/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request: Added an Allocator::activated to clean up conflating
issues in Allocator::frameworkAdded and made sure we recover executor
resources when a framework is removed.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6097/#review9374
-----------------------------------------------------------
Ship it!
src/master/allocator.hpp
<https://reviews.apache.org/r/6097/#comment20109>
We should really have docs for this interface functions. Since many more allocators are going to be written against this.
src/master/dominant_share_allocator.cpp
<https://reviews.apache.org/r/6097/#comment20110>
CHECK(initialized)
src/master/dominant_share_allocator.cpp
<https://reviews.apache.org/r/6097/#comment20111>
new line
- Vinod Kone
On July 23, 2012, 10:10 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6097/
> -----------------------------------------------------------
>
> (Updated July 23, 2012, 10:10 p.m.)
>
>
> Review request for mesos, Thomas Marshall and Vinod Kone.
>
>
> Description
> -------
>
> See summary.
>
>
> This addresses bug MESOS-239.
> https://issues.apache.org/jira/browse/MESOS-239
>
>
> Diffs
> -----
>
> src/master/allocator.hpp e55b9ec
> src/master/dominant_share_allocator.hpp bc5505b
> src/master/dominant_share_allocator.cpp a2de26f
> src/master/master.cpp 43407fa
> src/tests/utils.hpp ced8592
>
> Diff: https://reviews.apache.org/r/6097/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>