You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "terrymanu (via GitHub)" <gi...@apache.org> on 2026/09/04 09:55:03 UTC
[PR] Remove redundant coding standards guidance [shardingsphere]
terrymanu opened a new pull request, #39725:
URL: https://github.com/apache/shardingsphere/pull/39725
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove redundant coding standards guidance [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu commented on PR #39725:
URL: https://github.com/apache/shardingsphere/pull/39725#issuecomment-5538786585
### Result
**Review Result: Mergeable**
Removed redundant coding-standard text, aligned the Chinese testing rule with the English conditional requirement, and corrected the wording canary without weakening its behavior.
### Evidence
- Removed the non-actionable “Ensure compliance with coding standards” rule from all three documents.
- Removed the duplicated unit-test coverage rule from `docs/community/content/involved/conduct/code.en.md`.
- Merged the Chinese test-method rule while preserving the English requirement strength.
- Updated `.codex/harness/agents/cases.toml:980` to accept `unknown` or the equivalent `not defined`.
- Policy comparison passed: 110/110 cases and 148/148 source-read traces, with no regression from V0.
- Harness tests passed: 65 tests.
- Direct grading confirmed that `not defined` now passes.
- `git diff --check` passed.
- Checkstyle and Spotless do not govern these Markdown or TOML files.
### Coverage
- Candidate type: standalone local candidate.
- Baseline: `cb1c207827f01b90b539ea79354d2b72444dbefb`.
- Reviewed files:
- `.codex/harness/agents/cases.toml`
- `CODE_OF_CONDUCT.md`
- `docs/community/content/involved/conduct/code.en.md`
- `docs/community/content/involved/conduct/code.cn.md`
- Reviewed clusters: coding-standard redundancy cleanup and wording-canary equivalence.
- Root-cause, blast-radius, tests/runtime, and convergence passes completed with no findings.
- Unrelated `RELEASE-NOTES.md` and existing `__pycache__` changes were excluded and preserved.
- No unresolved risks. CI was not reviewed; this is a code-scope result.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove redundant coding standards guidance [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu merged PR #39725:
URL: https://github.com/apache/shardingsphere/pull/39725
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org