You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@metron.apache.org by nickwallen <gi...@git.apache.org> on 2018/02/09 14:13:56 UTC
[GitHub] metron pull request #933: METRON-1452 Rebase Dev Environment on Latest CentO...
GitHub user nickwallen opened a pull request:
https://github.com/apache/metron/pull/933
METRON-1452 Rebase Dev Environment on Latest CentOS 6
Currently the CentOS development environment (`metron-deployment/development/centos6`) is based on an image [metron/centos_base](https://app.vagrantup.com/metron/boxes/centos_base) that has not been updated in 11 months. This image is really just a snapshot of [bento/centos6.7](https://app.vagrantup.com/bento/boxes/centos-6.7) from 11 months ago. The [bento/centos6.7](https://app.vagrantup.com/bento/boxes/centos-6.7) image has not been updated in quite some time also.
On the other hand, the [centos/6](https://app.vagrantup.com/centos/boxes/6) image was updated 23 days ago. Presumably these images are receiving critical patches for long term support.
We should base the CentOS development environment `metron-deployment/development/centos6` on the [centos/6](https://app.vagrantup.com/centos/boxes/6) image so that we can be confident that Metron continues to work on the latest patches for the CentOS 6 series.
This would match what we do for the Ubuntu development environment which is based on [ubuntu/trusty64](https://app.vagrantup.com/ubuntu/boxes/trusty64). This image continues to receive updates regularly despite the age of the Ubuntu 14 release. It was updated just 3 days ago.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nickwallen/metron METRON-1452
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/933.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #933
----
commit 9a6f92878e472aba27db9f000a894a8c82349ce9
Author: Nick Allen <ni...@...>
Date: 2018-02-09T14:11:31Z
METRON-1452 Rebase Dev Environment on Latest CentOS 6
----
---
[GitHub] metron pull request #933: METRON-1452 Rebase Dev Environment on Latest CentO...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/metron/pull/933
---
[GitHub] metron issue #933: METRON-1452 Rebase Dev Environment on Latest CentOS 6
Posted by nickwallen <gi...@git.apache.org>.
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/933
I did not notice any issues, but I'll spin it up again and compare the difference in swap space just so we know what we're getting into.
Thanks for the info @dlyle65535 !
---
[GitHub] metron issue #933: METRON-1452 Rebase Dev Environment on Latest CentOS 6
Posted by nickwallen <gi...@git.apache.org>.
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/933
When creating the Ubuntu environment a while back, I created an Ansible role that enables swap space. (In the base Ubuntu image, swap space is not enabled.) It was easy enough to reuse that in the CentOS environment also.
With the latest commit, the CentOS environment has a larger swap space as before, but without the burden of maintaining an image in Vagrant Cloud/Atlas. I think this is the best of both worlds.
Let me know what you guys think. Would like to get reaffirmation on the +1s before merging this. @mmiklavc @cestella
---
[GitHub] metron issue #933: METRON-1452 Rebase Dev Environment on Latest CentOS 6
Posted by cestella <gi...@git.apache.org>.
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/933
piling on, +1 by inspection
---
[GitHub] metron issue #933: METRON-1452 Rebase Dev Environment on Latest CentOS 6
Posted by mmiklavc <gi...@git.apache.org>.
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/933
Oh, I guess we need to reaffirm. Yes, +1 still stands.
---
[GitHub] metron issue #933: METRON-1452 Rebase Dev Environment on Latest CentOS 6
Posted by mmiklavc <gi...@git.apache.org>.
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/933
This looks good, but before I +1 this, what are we doing in the current special metron cut of centos 6? I'm not familiar enough with why we forked to understand what we're possibly giving up or exchanging by switching to the main centos Vagrant image.
---
[GitHub] metron issue #933: METRON-1452 Rebase Dev Environment on Latest CentOS 6
Posted by justinleet <gi...@git.apache.org>.
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/933
@mmiklavc @cestella Bump
---
[GitHub] metron issue #933: METRON-1452 Rebase Dev Environment on Latest CentOS 6
Posted by mmiklavc <gi...@git.apache.org>.
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/933
Thanks for the info guys. @nickwallen With the reduced swap space, did you notice any issues with performance or services dying? I'm +1 by inspection if you believe we're good.
---
[GitHub] metron issue #933: METRON-1452 Rebase Dev Environment on Latest CentOS 6
Posted by dlyle65535 <gi...@git.apache.org>.
Github user dlyle65535 commented on the issue:
https://github.com/apache/metron/pull/933
@mmiklavc - the special cut has a larger swap volume than the standard image. It also is customized to what Metron required at the time to run. That's pretty much it. If that's still desirable, I'd consider rebuilding the Packer image with a more recent vintage Centos. Otherwise not so much.
---
[GitHub] metron issue #933: METRON-1452 Rebase Dev Environment on Latest CentOS 6
Posted by nickwallen <gi...@git.apache.org>.
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/933
> what are we doing in the current special metron cut of centos 6? I'm not familiar enough with why we forked to understand what we're possibly giving up or exchanging by switching to the main centos Vagrant image.
Sure, I'll try to explain what I remember and justify the change. Better to do our due diligence here.
Back then, we had some issues where the CentOS image would be updated and our Ansible deployment scripts would no longer work. A couple times we'd wake up in the morning with a broken dev environment when we hadn't changed anything in Metron.
As I remember it, this was back when we were just getting started. All of Metron was deployed via Ansible, different Ansible versions would have different behaviors and break things, and it was generally a very painful experience.
Back then we valued a stable dev environment over more rigorous testing. The Ansible scripts themselves have always just been a means to deploy Metron in a dev environment and not necessarily something that we want to support as part of Metron. We didn't care all that much if the Ansible scripts didn't work in all CentOS environments, they are just for our dev environment.
Fast forward to now and most of the deployment process is part of the MPack. The MPack is something that we expect our users to actually use in their own environments. Today, the MPack is a core part of Metron itself.
If a patch in CentOS occurs that breaks our MPack, then I definitely want to know about that. Given that, today I think we want to prioritize rigorous testing over a stable dev environment. And that is why I think we should use the centos/6 image as it stands.
---
[GitHub] metron issue #933: METRON-1452 Rebase Dev Environment on Latest CentOS 6
Posted by nickwallen <gi...@git.apache.org>.
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/933
FYI - After the last commit, I spun-up the CentOS environment again; validated the Alerts UI is receiving data, ran the Metron Service Check successfully. All is well.
---