You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "bmarwell (via GitHub)" <gi...@apache.org> on 2023/10/21 11:41:10 UTC
[PR] [MCOMPILER-550] make outputDirectory writeable [maven-compiler-plugin]
bmarwell opened a new pull request, #202:
URL: https://github.com/apache/maven-compiler-plugin/pull/202
- add more documentation when and how to use it (and when to not use it)
- fixes MCOMPILER-550
Following this checklist to help us incorporate your
contribution quickly and easily:
- [X] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MCOMPILER-550) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [X] Each commit in the pull request should have a meaningful subject line and body.
- [X] Format the pull request title like `[MCOMPILER-550] - Fixes bug in ApproximateQuantiles`,
where you replace `MCOMPILER-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [X] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [X] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [X] You have run the integration tests successfully (`mvn -Prun-its clean verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [X] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [X] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MCOMPILER-550] make outputDirectory writeable [maven-compiler-plugin]
Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet commented on PR #202:
URL: https://github.com/apache/maven-compiler-plugin/pull/202#issuecomment-1774114724
I think the same change should Apple to the test compile mono.
@bmarwell
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MCOMPILER-550] make outputDirectory writable [maven-compiler-plugin]
Posted by "bmarwell (via GitHub)" <gi...@apache.org>.
bmarwell commented on code in PR #202:
URL: https://github.com/apache/maven-compiler-plugin/pull/202#discussion_r1367979119
##########
src/main/java/org/apache/maven/plugin/compiler/TestCompilerMojo.java:
##########
@@ -75,8 +75,11 @@ public class TestCompilerMojo extends AbstractCompilerMojo {
/**
* The directory where compiled test classes go.
+ * <p>
+ * This parameter should only be modified in special cases.
+ * See the {@code compile}-Mojo for more information.
Review Comment:
Yes, that's exactly what I expected. But a link sounds reasonable, although I will want to avoid an import (ie will be qualified) and I doubt it will be used a lot...
Will update tomorrow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MCOMPILER-550] make outputDirectory writable [maven-compiler-plugin]
Posted by "bmarwell (via GitHub)" <gi...@apache.org>.
bmarwell merged PR #202:
URL: https://github.com/apache/maven-compiler-plugin/pull/202
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MCOMPILER-550] make outputDirectory writable [maven-compiler-plugin]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #202:
URL: https://github.com/apache/maven-compiler-plugin/pull/202#discussion_r1367976214
##########
src/main/java/org/apache/maven/plugin/compiler/TestCompilerMojo.java:
##########
@@ -75,8 +75,11 @@ public class TestCompilerMojo extends AbstractCompilerMojo {
/**
* The directory where compiled test classes go.
+ * <p>
+ * This parameter should only be modified in special cases.
+ * See the {@code compile}-Mojo for more information.
Review Comment:
Render as:
It was expected by you
maybe a link to compile-mojo documentation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MCOMPILER-550] make outputDirectory writeable [maven-compiler-plugin]
Posted by "bmarwell (via GitHub)" <gi...@apache.org>.
bmarwell commented on PR #202:
URL: https://github.com/apache/maven-compiler-plugin/pull/202#issuecomment-1774132830
> I think the same change should apply to the test compile mono. @bmarwell
Can do, just left it out because I couldn't think of a use case I could have added to the documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MCOMPILER-550] make outputDirectory writable [maven-compiler-plugin]
Posted by "bmarwell (via GitHub)" <gi...@apache.org>.
bmarwell commented on PR #202:
URL: https://github.com/apache/maven-compiler-plugin/pull/202#issuecomment-1774738258
Suggestion for link:
While the javadoc-link in the text will render as code in the docs, the `@see` link works nicely.
Will render to:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org