You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Pushkar Raste (JIRA)" <ji...@apache.org> on 2016/10/03 15:30:20 UTC
[jira] [Comment Edited] (SOLR-9546) There is a lot of unnecessary
boxing/unboxing going on in {{SolrParams}} class
[ https://issues.apache.org/jira/browse/SOLR-9546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15511196#comment-15511196 ]
Pushkar Raste edited comment on SOLR-9546 at 10/3/16 3:29 PM:
--------------------------------------------------------------
Got you.
I will fix the {{Long getLong(String param, Long def)}} method only. It is not as bad as I initially thought.
I don't even think that method is needed. Calling {{Long getLong(String param)}} would do the same thing, won't it?
was (Author: praste):
Got you.
I will fix the {{Long getLong(String param, Long def)}} method only. It is not as bad as initially thought.
I don't even think that method is needed. Calling {{Long getLong(String param)}} would do the same thing, won't it?
> There is a lot of unnecessary boxing/unboxing going on in {{SolrParams}} class
> ------------------------------------------------------------------------------
>
> Key: SOLR-9546
> URL: https://issues.apache.org/jira/browse/SOLR-9546
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Pushkar Raste
> Priority: Minor
>
> Here is an excerpt
> {code}
> public Long getLong(String param, Long def) {
> String val = get(param);
> try {
> return val== null ? def : Long.parseLong(val);
> }
> catch( Exception ex ) {
> throw new SolrException( SolrException.ErrorCode.BAD_REQUEST, ex.getMessage(), ex );
> }
> }
> {code}
> {{Long.parseLong()}} returns a primitive type but since method expect to return a {{Long}}, it needs to be wrapped. There are many more method like that. We might be creating a lot of unnecessary objects here.
> I am not sure if JVM catches upto it and somehow optimizes it if these methods are called enough times (or may be compiler does some modifications at compile time)
> Let me know if I am thinking of some premature optimization
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org