You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/03/18 10:39:50 UTC
[GitHub] [iceberg] lcspinter opened a new pull request #2350: Fix broken TestHiveClientPool
lcspinter opened a new pull request #2350:
URL: https://github.com/apache/iceberg/pull/2350
#2075 Introduced a new test which broke the master codeline.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] lcspinter commented on pull request #2350: Fix broken TestHiveClientPool
Posted by GitBox <gi...@apache.org>.
lcspinter commented on pull request #2350:
URL: https://github.com/apache/iceberg/pull/2350#issuecomment-801816896
@pvary @dixingxing0 Could you please review this PR? Thank you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] pvary merged pull request #2350: Fix broken TestHiveClientPool
Posted by GitBox <gi...@apache.org>.
pvary merged pull request #2350:
URL: https://github.com/apache/iceberg/pull/2350
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] pvary commented on a change in pull request #2350: Fix broken TestHiveClientPool
Posted by GitBox <gi...@apache.org>.
pvary commented on a change in pull request #2350:
URL: https://github.com/apache/iceberg/pull/2350#discussion_r596738603
##########
File path: hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveClientPool.java
##########
@@ -44,7 +44,7 @@ public void testConf() {
conf.set(HiveConf.ConfVars.METASTOREWAREHOUSE.varname, "file:/mywarehouse/");
conf.setInt("iceberg.hive.client-pool-size", 10);
- HiveClientPool clientPool = new HiveClientPool(conf);
+ HiveClientPool clientPool = new HiveClientPool(10, conf);
Review comment:
Do we need 10? What was the original value?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] lcspinter commented on a change in pull request #2350: Fix broken TestHiveClientPool
Posted by GitBox <gi...@apache.org>.
lcspinter commented on a change in pull request #2350:
URL: https://github.com/apache/iceberg/pull/2350#discussion_r596744374
##########
File path: hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveClientPool.java
##########
@@ -44,7 +44,7 @@ public void testConf() {
conf.set(HiveConf.ConfVars.METASTOREWAREHOUSE.varname, "file:/mywarehouse/");
conf.setInt("iceberg.hive.client-pool-size", 10);
- HiveClientPool clientPool = new HiveClientPool(conf);
+ HiveClientPool clientPool = new HiveClientPool(10, conf);
Review comment:
Previously we had a HiveClientPool constructor, which got the client-pool-size from the hive conf. This was removed, and now it expects the pool-size explicitly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org