You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by sunjincheng121 <gi...@git.apache.org> on 2017/06/19 00:20:14 UTC
[GitHub] flink pull request #4137: [FLINK-6941][table]Add validate that the start and...
GitHub user sunjincheng121 opened a pull request:
https://github.com/apache/flink/pull/4137
[FLINK-6941][table]Add validate that the start and end window propert…
Add validate that the start and end window properties are not accessed on over windows.
- [x] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [x] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sunjincheng121/flink FLINK-6941-PR
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4137.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4137
----
commit 2d5405c684e21cf0a89f390ae9ea9ba762fc2767
Author: sunjincheng121 <su...@gmail.com>
Date: 2017-06-19T00:06:15Z
[FLINK-6941][table]Add validate that the start and end window properties are not accessed on over windows
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4137: [FLINK-6941][table]Add validate that the start and...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/4137#discussion_r122681031
--- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/table.scala ---
@@ -1004,6 +1004,11 @@ class OverWindowedTable(
table.logicalPlan,
table.tableEnv)
+ if(fields.exists(_.isInstanceOf[WindowProperty])){
+ throw ValidationException(
+ "Window start and Window end can not be used on over windowed tables.")
--- End diff --
What do you think about `"Window start and end properties are not available for Over windows."`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4137: [FLINK-6941][table]Add validate that the start and end wi...
Posted by sunjincheng121 <gi...@git.apache.org>.
Github user sunjincheng121 commented on the issue:
https://github.com/apache/flink/pull/4137
Hi @fhueske thanks for your reviewing. I have updated the PR according your suggestion.
Best,
SunJincheng
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4137: [FLINK-6941][table]Add validate that the start and end wi...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/4137
thanks!
+1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4137: [FLINK-6941][table]Add validate that the start and...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4137
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4137: [FLINK-6941][table]Add validate that the start and...
Posted by sunjincheng121 <gi...@git.apache.org>.
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/4137#discussion_r122682340
--- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/table.scala ---
@@ -1004,6 +1004,11 @@ class OverWindowedTable(
table.logicalPlan,
table.tableEnv)
+ if(fields.exists(_.isInstanceOf[WindowProperty])){
+ throw ValidationException(
+ "Window start and Window end can not be used on over windowed tables.")
--- End diff --
Also make sense to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4137: [FLINK-6941][table]Add validate that the start and end wi...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/4137
will merge this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---