You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@arrow.apache.org by "Jonathan Keane (Jira)" <ji...@apache.org> on 2021/07/07 15:03:00 UTC

[jira] [Resolved] (ARROW-13266) [JS] Improve benchmark names & add suite name to json

     [ https://issues.apache.org/jira/browse/ARROW-13266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Keane resolved ARROW-13266.
------------------------------------
    Fix Version/s: 5.0.0
       Resolution: Fixed

Issue resolved by pull request 10665
[https://github.com/apache/arrow/pull/10665]

> [JS] Improve benchmark names & add suite name to json
> -----------------------------------------------------
>
>                 Key: ARROW-13266
>                 URL: https://issues.apache.org/jira/browse/ARROW-13266
>             Project: Apache Arrow
>          Issue Type: Bug
>          Components: JavaScript
>            Reporter: Diana Clarke
>            Assignee: Diana Clarke
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 5.0.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> I propose we make the following changes to the JS benchmark results, so that they are more parsable for Conbench. We'll also need to add suite name to the json results to disambiguate otherwise duplicate benchmark names.
> 1) Rename {{name}} to {{column}}
>     {code}"name": "name: 'lat', length: 1,000,000, type: Float32",{code}
>     
>     vs.
>     
>     {code}"name": "column: 'lat', length: 1,000,000, type: Float32",{code}
> 2) Add the suite name to the json results.
> 2) Remove dataset name from the suite name, move it to the benchmark name. Conbench will split on the colons and store all the parameters (dataset, length, column, etc) as benchmark tags.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)