You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Stefan Küng <to...@gmail.com> on 2008/03/21 16:19:02 UTC

1.5 client can't connect to 1.4 svnserve

Hi,

Using a current build from the 1.5.x branch (built 30 minutes ago), I 
can't connect to svnserve based repositories.
Users on the TSVN list also reported that this happened with the alpha 
build too.

Since I couldn't find an entry in the STATUS file indicating that this 
has already been fixed, here's how to reproduce this:

// with an 1.4.x svn client
cd D:\
svnadmin create testrepo
cd testrepo
svnserve -d -r D:\


// now with an 1.4.x svn client
svn ls svn://localhost/testrepo
// no error, it works

// now with an 1.5 svn client
svn ls svn://localhost/testrepo
svn: Can't connect to host 'localhost': connection refused


Stefan


-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net


Re: 1.5 client can't connect to 1.4 svnserve

Posted by Stefan Küng <to...@gmail.com>.
Mark Phippard wrote:
> On Fri, Mar 21, 2008 at 9:27 AM, Stefan Küng <to...@gmail.com> wrote:
>> Mark Phippard wrote:
>>  > On Fri, Mar 21, 2008 at 9:19 AM, Stefan Küng <to...@gmail.com> wrote:
>>  >
>>  >>  Using a current build from the 1.5.x branch (built 30 minutes ago), I
>>  >>  can't connect to svnserve based repositories.
>>  >>  Users on the TSVN list also reported that this happened with the alpha
>>  >>  build too.
>>  >>
>>  >>  Since I couldn't find an entry in the STATUS file indicating that this
>>  >>  has already been fixed, here's how to reproduce this:
>>  >>
>>  >>  // with an 1.4.x svn client
>>  >>  cd D:\
>>  >>  svnadmin create testrepo
>>  >>  cd testrepo
>>  >>  svnserve -d -r D:\
>>  >>
>>  >>
>>  >>  // now with an 1.4.x svn client
>>  >>  svn ls svn://localhost/testrepo
>>  >>  // no error, it works
>>  >>
>>  >>  // now with an 1.5 svn client
>>  >>  svn ls svn://localhost/testrepo
>>  >>  svn: Can't connect to host 'localhost': connection refused
>>  >
>>  > Can you try it with trunk build?  I seem to recall this being reported
>>  > a while back and it had to do with SASL.  I would have thought it was
>>  > fixed, but perhaps it was and has not been backported yet?
>>
>>  To test this with a trunk build, that will take a while. I don't have a
>>  build ready right now.
>>  If no one else has a trunk build ready to test, I can do this in about
>>  an hour or so.
> 
> I did a little digging and this was the thread I was thinking of:
> 
> http://svn.haxx.se/dev/archive-2008-02/0223.shtml
> 
> Unfortunately, it looks like the thread ended with the conclusion that
> it was a Mac-specific build problem.

The error message which is reported there doesn't match.
I get another error, nothing with SASL. It simply sais that the 
connection was refused, nothing about authenticating.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net


Re: 1.5 client can't connect to 1.4 svnserve

Posted by Mark Phippard <ma...@gmail.com>.
On Fri, Mar 21, 2008 at 9:27 AM, Stefan Küng <to...@gmail.com> wrote:
>
> Mark Phippard wrote:
>  > On Fri, Mar 21, 2008 at 9:19 AM, Stefan Küng <to...@gmail.com> wrote:
>  >
>  >>  Using a current build from the 1.5.x branch (built 30 minutes ago), I
>  >>  can't connect to svnserve based repositories.
>  >>  Users on the TSVN list also reported that this happened with the alpha
>  >>  build too.
>  >>
>  >>  Since I couldn't find an entry in the STATUS file indicating that this
>  >>  has already been fixed, here's how to reproduce this:
>  >>
>  >>  // with an 1.4.x svn client
>  >>  cd D:\
>  >>  svnadmin create testrepo
>  >>  cd testrepo
>  >>  svnserve -d -r D:\
>  >>
>  >>
>  >>  // now with an 1.4.x svn client
>  >>  svn ls svn://localhost/testrepo
>  >>  // no error, it works
>  >>
>  >>  // now with an 1.5 svn client
>  >>  svn ls svn://localhost/testrepo
>  >>  svn: Can't connect to host 'localhost': connection refused
>  >
>  > Can you try it with trunk build?  I seem to recall this being reported
>  > a while back and it had to do with SASL.  I would have thought it was
>  > fixed, but perhaps it was and has not been backported yet?
>
>  To test this with a trunk build, that will take a while. I don't have a
>  build ready right now.
>  If no one else has a trunk build ready to test, I can do this in about
>  an hour or so.

I did a little digging and this was the thread I was thinking of:

http://svn.haxx.se/dev/archive-2008-02/0223.shtml

Unfortunately, it looks like the thread ended with the conclusion that
it was a Mac-specific build problem.


-- 
Thanks

Mark Phippard
http://markphip.blogspot.com/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org


Re: 1.5 client can't connect to 1.4 svnserve

Posted by Stefan Küng <to...@gmail.com>.
Mark Phippard wrote:
> On Fri, Mar 21, 2008 at 9:19 AM, Stefan Küng <to...@gmail.com> wrote:
> 
>>  Using a current build from the 1.5.x branch (built 30 minutes ago), I
>>  can't connect to svnserve based repositories.
>>  Users on the TSVN list also reported that this happened with the alpha
>>  build too.
>>
>>  Since I couldn't find an entry in the STATUS file indicating that this
>>  has already been fixed, here's how to reproduce this:
>>
>>  // with an 1.4.x svn client
>>  cd D:\
>>  svnadmin create testrepo
>>  cd testrepo
>>  svnserve -d -r D:\
>>
>>
>>  // now with an 1.4.x svn client
>>  svn ls svn://localhost/testrepo
>>  // no error, it works
>>
>>  // now with an 1.5 svn client
>>  svn ls svn://localhost/testrepo
>>  svn: Can't connect to host 'localhost': connection refused
> 
> Can you try it with trunk build?  I seem to recall this being reported
> a while back and it had to do with SASL.  I would have thought it was
> fixed, but perhaps it was and has not been backported yet?

To test this with a trunk build, that will take a while. I don't have a 
build ready right now.
If no one else has a trunk build ready to test, I can do this in about 
an hour or so.

Stefan


-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net


Re: 1.5 client can't connect to 1.4 svnserve

Posted by Stefan Küng <to...@gmail.com>.
Karl Fogel wrote:
> Karl Fogel <kf...@red-bean.com> writes:
>> "C. Michael Pilato" <cm...@collab.net> writes:
>>> Karl Fogel wrote:
>>>> Stefan Küng <to...@gmail.com> writes:
>>>>> Tried with a trunk build. The same problem: "can't connect to host
>>>>> localhost': connection refused".
>>>>>
>>>>> So it seems the problem hasn't been fixed on trunk yet.
>>>> Thanks for confirming this, Stefan.  I'm on it (and have filed
>>>> http://subversion.tigris.org/issues/show_bug.cgi?id=3132 as a
>>>> 1.5-blocker to track it).
>>> red-bean is still on 1.4 -- maybe consider running a 1.4 svnserve
>>> daemon there for testing?
>> Thanks, that'll save me some time, good idea.
> 
> Stefan, I cannot reproduce this.
> 
> Here's what I did on the server side:
> 
>    $ hostname -a
>    sanpietro  sp.red-bean.com  sp
>    $ svnadmin --version
>    svnadmin, version 1.4.5 (r25188)
>       compiled Sep 25 2007, 16:58:57
>       [...]
>    $ svnadmin create repos
>    $ svnserve -d -r `pwd`
>    $ 
> 
> Now watch what happens on the client side:
> 
>    $ ./1.4.x/subversion/svn/svn --version
>    svn, version 1.4.7 (dev build)
>       compiled Mar 21 2008, 13:45:07
>       [...]   
>    $ ./1.4.x/subversion/svn/svn ls -v svn://sp.red-bean.com/repos
>    $ ./1.4.x/subversion/svn/svn log -v svn://sp.red-bean.com/repos
>    ------------------------------------------------------------------------
>    $ ./1.4.x/subversion/svn/svn co \
>              svn://sp.red-bean.com/repos wc-via-1.4-client/
>    Checked out revision 0.
>    $ ./subversion/subversion/svn/svn --version
>    svn, version 1.6.0 (dev build)
>       compiled Mar 21 2008, 14:18:07
>       [...]   
>    $ ./subversion/subversion/svn/svn ls -v svn://sp.red-bean.com/repos
>          0  ?                    Mar 21 14:14 ./
>    $ ./subversion/subversion/svn/svn log -v svn://sp.red-bean.com/repos
>    ------------------------------------------------------------------------
>    $ ./subversion/subversion/svn/svn co \
>              svn://sp.red-bean.com/repos wc-via-1.5-client
>    Checked out revision 0.
>    $ 
> 
> So, both clients work.  With the 1.5 client, we see more information in
> the output from 'svn ls -v svn://URL', when URL points to a repository
> that has only r0.  I guess that must be some 1.5 improvement.
> 
> In any case, they are both working for me.
> 
> Can you get a network trace or somehow find out what's causing that
> "Can't connect to host 'localhost': connection refused" error?

I must be losing my mind: I can't get a network trace (using WireShark) 
for connections to localhost. I know I did that once before but now I 
can't seem to get this to work.

Anyway:

Try a non-empty repository.
And I'm doing this on Windows, with svnserve running on the same machine 
as the svn client.

Since I can't get a network trace, I'll try stepping through the code. 
Be right back...

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net


Re: 1.5 client can't connect to 1.4 svnserve

Posted by Karl Fogel <kf...@red-bean.com>.
Karl Fogel <kf...@red-bean.com> writes:
> "C. Michael Pilato" <cm...@collab.net> writes:
>> Karl Fogel wrote:
>>> Stefan Küng <to...@gmail.com> writes:
>>>> Tried with a trunk build. The same problem: "can't connect to host
>>>> localhost': connection refused".
>>>>
>>>> So it seems the problem hasn't been fixed on trunk yet.
>>>
>>> Thanks for confirming this, Stefan.  I'm on it (and have filed
>>> http://subversion.tigris.org/issues/show_bug.cgi?id=3132 as a
>>> 1.5-blocker to track it).
>>
>> red-bean is still on 1.4 -- maybe consider running a 1.4 svnserve
>> daemon there for testing?
>
> Thanks, that'll save me some time, good idea.

Stefan, I cannot reproduce this.

Here's what I did on the server side:

   $ hostname -a
   sanpietro  sp.red-bean.com  sp
   $ svnadmin --version
   svnadmin, version 1.4.5 (r25188)
      compiled Sep 25 2007, 16:58:57
      [...]
   $ svnadmin create repos
   $ svnserve -d -r `pwd`
   $ 

Now watch what happens on the client side:

   $ ./1.4.x/subversion/svn/svn --version
   svn, version 1.4.7 (dev build)
      compiled Mar 21 2008, 13:45:07
      [...]   
   $ ./1.4.x/subversion/svn/svn ls -v svn://sp.red-bean.com/repos
   $ ./1.4.x/subversion/svn/svn log -v svn://sp.red-bean.com/repos
   ------------------------------------------------------------------------
   $ ./1.4.x/subversion/svn/svn co \
             svn://sp.red-bean.com/repos wc-via-1.4-client/
   Checked out revision 0.
   $ ./subversion/subversion/svn/svn --version
   svn, version 1.6.0 (dev build)
      compiled Mar 21 2008, 14:18:07
      [...]   
   $ ./subversion/subversion/svn/svn ls -v svn://sp.red-bean.com/repos
         0  ?                    Mar 21 14:14 ./
   $ ./subversion/subversion/svn/svn log -v svn://sp.red-bean.com/repos
   ------------------------------------------------------------------------
   $ ./subversion/subversion/svn/svn co \
             svn://sp.red-bean.com/repos wc-via-1.5-client
   Checked out revision 0.
   $ 

So, both clients work.  With the 1.5 client, we see more information in
the output from 'svn ls -v svn://URL', when URL points to a repository
that has only r0.  I guess that must be some 1.5 improvement.

In any case, they are both working for me.

Can you get a network trace or somehow find out what's causing that
"Can't connect to host 'localhost': connection refused" error?

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org


Re: 1.5 client can't connect to 1.4 svnserve

Posted by Stefan Sperling <st...@elego.de>.
On Sat, Mar 22, 2008 at 09:20:35AM +0100, Stefan Küng wrote:
>> [[
>> Fix issue #2382, correctly handle dual-stack servers in ra_svn client.
>> 
>> * subversion/libsvn_ra_svn/client.c:
>>   (make_connection): Iterate through the returned list of addresses
>>    until a socket/connect pair succeeds.
>> ]]
> 
> I can confirm that this patch works too.

Stefan, thanks heaps for testing.

Committed in r30004 with a slightly modified log message (issue #2382
is about more than just this client-side fix) with approval by lgo.

I've also nominated this for backport to 1.5.x, if any full committers
want to cast their votes/vetos on this one, please go right ahead.

-- 
Stefan Sperling <st...@elego.de>                 Software Developer
elego Software Solutions GmbH                            HRB 77719
Gustav-Meyer-Allee 25, Gebaeude 12        Tel:  +49 30 23 45 86 96 
13355 Berlin                              Fax:  +49 30 23 45 86 95
http://www.elego.de                 Geschaeftsfuehrer: Olaf Wagner

Re: 1.5 client can't connect to 1.4 svnserve

Posted by Stefan Küng <to...@gmail.com>.
Stefan Sperling wrote:
> On Fri, Mar 21, 2008 at 10:23:39PM +0100, Stefan Sperling wrote:
>> OK, next try.
> 
> Eric Gillespie pointed me to an old patch by Joe Orton
> attached to issue #2382 that implements the very same fix,
> but is a bit cleaner and also closes sockets it cannot connect with:
> 
> http://subversion.tigris.org/nonav/issues/showattachment.cgi/500/svn_rasvnaddr.diff
> 
> Attached is an updated version of it that applies to current trunk.
> 
> Tested again like my previous patch, with 1.5 svnserve and svn client,
> on a fully IPv6-enabled host (running FreeBSD). Connecting works, and
> the client errors out while svnserve is not running, so at least this
> patch does not seem to break anything.
> 
> This is based on Joe Orton's original log message:
> 
> [[
> Fix issue #2382, correctly handle dual-stack servers in ra_svn client.
> 
> * subversion/libsvn_ra_svn/client.c:
>   (make_connection): Iterate through the returned list of addresses
>    until a socket/connect pair succeeds.
> ]]

I can confirm that this patch works too.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net


Re: 1.5 client can't connect to 1.4 svnserve

Posted by Stefan Sperling <st...@elego.de>.
On Fri, Mar 21, 2008 at 10:23:39PM +0100, Stefan Sperling wrote:
> OK, next try.

Eric Gillespie pointed me to an old patch by Joe Orton
attached to issue #2382 that implements the very same fix,
but is a bit cleaner and also closes sockets it cannot connect with:

http://subversion.tigris.org/nonav/issues/showattachment.cgi/500/svn_rasvnaddr.diff

Attached is an updated version of it that applies to current trunk.

Tested again like my previous patch, with 1.5 svnserve and svn client,
on a fully IPv6-enabled host (running FreeBSD). Connecting works, and
the client errors out while svnserve is not running, so at least this
patch does not seem to break anything.

This is based on Joe Orton's original log message:

[[
Fix issue #2382, correctly handle dual-stack servers in ra_svn client.

* subversion/libsvn_ra_svn/client.c:
  (make_connection): Iterate through the returned list of addresses
   until a socket/connect pair succeeds.
]]

-- 
Stefan Sperling <st...@elego.de>                 Software Developer
elego Software Solutions GmbH                            HRB 77719
Gustav-Meyer-Allee 25, Gebaeude 12        Tel:  +49 30 23 45 86 96 
13355 Berlin                              Fax:  +49 30 23 45 86 95
http://www.elego.de                 Geschaeftsfuehrer: Olaf Wagner

Re: 1.5 client can't connect to 1.4 svnserve

Posted by Stefan Sperling <st...@elego.de>.
On Fri, Mar 21, 2008 at 11:06:28PM +0100, Stefan Küng wrote:
> Stefan Sperling wrote:
>> Stefan, does this fix the issue for you?
> 
> Yes, this fixes the problem.

Great. Would you mind also trying the patch I've posted that's
based on the one by Joe Orton attached to issue #2382 ?

-- 
Stefan Sperling <st...@elego.de>                 Software Developer
elego Software Solutions GmbH                            HRB 77719
Gustav-Meyer-Allee 25, Gebaeude 12        Tel:  +49 30 23 45 86 96 
13355 Berlin                              Fax:  +49 30 23 45 86 95
http://www.elego.de                 Geschaeftsfuehrer: Olaf Wagner

Re: 1.5 client can't connect to 1.4 svnserve

Posted by Stefan Küng <to...@gmail.com>.
Stefan Sperling wrote:
> On Fri, Mar 21, 2008 at 09:20:01PM +0100, Stefan Sperling wrote:
>> On Fri, Mar 21, 2008 at 09:10:49PM +0100, Stefan Sperling wrote:
>>> On Fri, Mar 21, 2008 at 08:48:32PM +0100, Stefan Küng wrote:
>>>> file libsvn_ra_svn/client.c, function make_connection():
>>>> if APR_HAVE_IPV6 is defined, then only ipv6 connections are used. If they 
>>>> fail, no ipv4 connection is tried before giving up.
>>> Interesting...
>>>
>>> Reading the docstring for apr_sockaddr_info_get in
>>> /usr/local/include/apr-1/apr_network_io.h
>>> makes me believe this could fix it (not tested though...)
>> It likely won't fix it, sorry for the noise:
>>
>> <Bert> stsp: I don't think that will fix it.. getaddrinfo() returns
>> multiple addresses and only one is tried
>> <stsp> oh, right - I thought it failed at "Unkown hostname" but it fails
>> at "Can't connect to host"
> 
> OK, next try.
> 
> Tested locally with 1.5 svnserve and svn client, on a fully IPv6-enabled
> host (running FreeBSD). Connecting works, and the client errors out
> while svnserve is not running, so at least this patch does not seem
> to break anything.
> 
> Stefan, does this fix the issue for you?

Yes, this fixes the problem.
On little detail about your patch: it doesn't compile as it is.
You have to move the variable decl (apr_sockaddr_t *s;) to the start of 
the function.

Thanks for fixing this!

Stefan


-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net


Re: 1.5 client can't connect to 1.4 svnserve

Posted by Stefan Sperling <st...@elego.de>.
On Fri, Mar 21, 2008 at 09:20:01PM +0100, Stefan Sperling wrote:
> On Fri, Mar 21, 2008 at 09:10:49PM +0100, Stefan Sperling wrote:
> > On Fri, Mar 21, 2008 at 08:48:32PM +0100, Stefan Küng wrote:
> > > file libsvn_ra_svn/client.c, function make_connection():
> > > if APR_HAVE_IPV6 is defined, then only ipv6 connections are used. If they 
> > > fail, no ipv4 connection is tried before giving up.
> > 
> > Interesting...
> > 
> > Reading the docstring for apr_sockaddr_info_get in
> > /usr/local/include/apr-1/apr_network_io.h
> > makes me believe this could fix it (not tested though...)
> 
> It likely won't fix it, sorry for the noise:
> 
> <Bert> stsp: I don't think that will fix it.. getaddrinfo() returns
> multiple addresses and only one is tried
> <stsp> oh, right - I thought it failed at "Unkown hostname" but it fails
> at "Can't connect to host"

OK, next try.

Tested locally with 1.5 svnserve and svn client, on a fully IPv6-enabled
host (running FreeBSD). Connecting works, and the client errors out
while svnserve is not running, so at least this patch does not seem
to break anything.

Stefan, does this fix the issue for you?

[[[

* subversion/libsvn_ra_svn/client.c
  (make_connection): Loop over all available addresses of
   the host to connect to, instead of trying only the first
   and bailing if the host does not accept a connection
   on that address.

]]]

-- 
Stefan Sperling <st...@elego.de>                 Software Developer
elego Software Solutions GmbH                            HRB 77719
Gustav-Meyer-Allee 25, Gebaeude 12        Tel:  +49 30 23 45 86 96 
13355 Berlin                              Fax:  +49 30 23 45 86 95
http://www.elego.de                 Geschaeftsfuehrer: Olaf Wagner

Re: 1.5 client can't connect to 1.4 svnserve

Posted by Stefan Sperling <st...@elego.de>.
On Fri, Mar 21, 2008 at 09:10:49PM +0100, Stefan Sperling wrote:
> On Fri, Mar 21, 2008 at 08:48:32PM +0100, Stefan Küng wrote:
> > Karl Fogel wrote:
> >> Stefan, you probably saw my mail just now saying that I can't reproduce
> >> this.  But in IRC, Eric Gillespie had an interesting thought:
> >> 
> >>    <epg> re: svnserve connection refused: maybe 1.5 is trying ipv6 and
> >>          then giving up?
> > 
> > Yep, seems that way.
> > 
> > file libsvn_ra_svn/client.c, function make_connection():
> > if APR_HAVE_IPV6 is defined, then only ipv6 connections are used. If they 
> > fail, no ipv4 connection is tried before giving up.
> 
> Interesting...
> 
> Reading the docstring for apr_sockaddr_info_get in
> /usr/local/include/apr-1/apr_network_io.h
> makes me believe this could fix it (not tested though...)

It likely won't fix it, sorry for the noise:

<Bert> stsp: I don't think that will fix it.. getaddrinfo() returns
multiple addresses and only one is tried
<stsp> oh, right - I thought it failed at "Unkown hostname" but it fails
at "Can't connect to host"


-- 
Stefan Sperling <st...@elego.de>                 Software Developer
elego Software Solutions GmbH                            HRB 77719
Gustav-Meyer-Allee 25, Gebaeude 12        Tel:  +49 30 23 45 86 96 
13355 Berlin                              Fax:  +49 30 23 45 86 95
http://www.elego.de                 Geschaeftsfuehrer: Olaf Wagner

Re: 1.5 client can't connect to 1.4 svnserve

Posted by Stefan Sperling <st...@elego.de>.
On Fri, Mar 21, 2008 at 08:48:32PM +0100, Stefan Küng wrote:
> Karl Fogel wrote:
>> Stefan, you probably saw my mail just now saying that I can't reproduce
>> this.  But in IRC, Eric Gillespie had an interesting thought:
>> 
>>    <epg> re: svnserve connection refused: maybe 1.5 is trying ipv6 and
>>          then giving up?
> 
> Yep, seems that way.
> 
> file libsvn_ra_svn/client.c, function make_connection():
> if APR_HAVE_IPV6 is defined, then only ipv6 connections are used. If they 
> fail, no ipv4 connection is tried before giving up.

Interesting...

Reading the docstring for apr_sockaddr_info_get in
/usr/local/include/apr-1/apr_network_io.h
makes me believe this could fix it (not tested though...)

Index: subversion/libsvn_ra_svn/client.c
===================================================================
--- subversion/libsvn_ra_svn/client.c	(revision 29983)
+++ subversion/libsvn_ra_svn/client.c	(working copy)
@@ -108,6 +108,7 @@ static svn_error_t *make_connection(cons
   apr_sockaddr_t *sa;
   apr_status_t status;
   int family = APR_INET;
+  int flags = APR_IPV4_ADDR_OK;
 
   /* Make sure we have IPV6 support first before giving apr_sockaddr_info_get
      APR_UNSPEC, because it may give us back an IPV6 address even if we can't
@@ -124,11 +125,12 @@ static svn_error_t *make_connection(cons
     {
       apr_socket_close(*sock);
       family = APR_UNSPEC;
+      flags = APR_IPV6_ADDR_OK; /* prefer IPv6 over IPv4 */
     }
 #endif
 
   /* Resolve the hostname. */
-  status = apr_sockaddr_info_get(&sa, hostname, family, port, 0, pool);
+  status = apr_sockaddr_info_get(&sa, hostname, family, port, flags, pool);
   if (status)
     return svn_error_createf(status, NULL, _("Unknown hostname '%s'"),
                              hostname);

-- 
Stefan Sperling <st...@elego.de>                 Software Developer
elego Software Solutions GmbH                            HRB 77719
Gustav-Meyer-Allee 25, Gebaeude 12        Tel:  +49 30 23 45 86 96 
13355 Berlin                              Fax:  +49 30 23 45 86 95
http://www.elego.de                 Geschaeftsfuehrer: Olaf Wagner

Re: 1.5 client can't connect to 1.4 svnserve

Posted by Stefan Küng <to...@gmail.com>.
Karl Fogel wrote:
> Stefan, you probably saw my mail just now saying that I can't reproduce
> this.  But in IRC, Eric Gillespie had an interesting thought:
> 
>    <epg> re: svnserve connection refused: maybe 1.5 is trying ipv6 and
>          then giving up?

Yep, seems that way.

file libsvn_ra_svn/client.c, function make_connection():
if APR_HAVE_IPV6 is defined, then only ipv6 connections are used. If 
they fail, no ipv4 connection is tried before giving up.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net


Re: 1.5 client can't connect to 1.4 svnserve

Posted by Karl Fogel <kf...@red-bean.com>.
Stefan, you probably saw my mail just now saying that I can't reproduce
this.  But in IRC, Eric Gillespie had an interesting thought:

   <epg> re: svnserve connection refused: maybe 1.5 is trying ipv6 and
         then giving up?

?,
-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: 1.5 client can't connect to 1.4 svnserve

Posted by Karl Fogel <kf...@red-bean.com>.
"C. Michael Pilato" <cm...@collab.net> writes:
> Karl Fogel wrote:
>> Stefan Küng <to...@gmail.com> writes:
>>> Tried with a trunk build. The same problem: "can't connect to host
>>> localhost': connection refused".
>>>
>>> So it seems the problem hasn't been fixed on trunk yet.
>>
>> Thanks for confirming this, Stefan.  I'm on it (and have filed
>> http://subversion.tigris.org/issues/show_bug.cgi?id=3132 as a
>> 1.5-blocker to track it).
>
> red-bean is still on 1.4 -- maybe consider running a 1.4 svnserve
> daemon there for testing?

Thanks, that'll save me some time, good idea.

-K

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org


Re: 1.5 client can't connect to 1.4 svnserve

Posted by "C. Michael Pilato" <cm...@collab.net>.
Karl Fogel wrote:
> Stefan Küng <to...@gmail.com> writes:
>> Tried with a trunk build. The same problem: "can't connect to host
>> localhost': connection refused".
>>
>> So it seems the problem hasn't been fixed on trunk yet.
> 
> Thanks for confirming this, Stefan.  I'm on it (and have filed
> http://subversion.tigris.org/issues/show_bug.cgi?id=3132 as a
> 1.5-blocker to track it).

red-bean is still on 1.4 -- maybe consider running a 1.4 svnserve daemon 
there for testing?

-- 
C. Michael Pilato <cm...@collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand


Re: 1.5 client can't connect to 1.4 svnserve

Posted by Karl Fogel <kf...@red-bean.com>.
Stefan Küng <to...@gmail.com> writes:
> Tried with a trunk build. The same problem: "can't connect to host
> localhost': connection refused".
>
> So it seems the problem hasn't been fixed on trunk yet.

Thanks for confirming this, Stefan.  I'm on it (and have filed
http://subversion.tigris.org/issues/show_bug.cgi?id=3132 as a
1.5-blocker to track it).

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org


Re: 1.5 client can't connect to 1.4 svnserve

Posted by Stefan Küng <to...@gmail.com>.
Mark Phippard wrote:
> On Fri, Mar 21, 2008 at 9:19 AM, Stefan Küng <to...@gmail.com> wrote:
> 
>>  Using a current build from the 1.5.x branch (built 30 minutes ago), I
>>  can't connect to svnserve based repositories.
>>  Users on the TSVN list also reported that this happened with the alpha
>>  build too.
>>
>>  Since I couldn't find an entry in the STATUS file indicating that this
>>  has already been fixed, here's how to reproduce this:
>>
>>  // with an 1.4.x svn client
>>  cd D:\
>>  svnadmin create testrepo
>>  cd testrepo
>>  svnserve -d -r D:\
>>
>>
>>  // now with an 1.4.x svn client
>>  svn ls svn://localhost/testrepo
>>  // no error, it works
>>
>>  // now with an 1.5 svn client
>>  svn ls svn://localhost/testrepo
>>  svn: Can't connect to host 'localhost': connection refused
> 
> Can you try it with trunk build?  I seem to recall this being reported
> a while back and it had to do with SASL.  I would have thought it was
> fixed, but perhaps it was and has not been backported yet?

Tried with a trunk build. The same problem: "can't connect to host 
'localhost': connection refused".

So it seems the problem hasn't been fixed on trunk yet.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net


Re: 1.5 client can't connect to 1.4 svnserve

Posted by Mark Phippard <ma...@gmail.com>.
On Fri, Mar 21, 2008 at 9:19 AM, Stefan Küng <to...@gmail.com> wrote:

>  Using a current build from the 1.5.x branch (built 30 minutes ago), I
>  can't connect to svnserve based repositories.
>  Users on the TSVN list also reported that this happened with the alpha
>  build too.
>
>  Since I couldn't find an entry in the STATUS file indicating that this
>  has already been fixed, here's how to reproduce this:
>
>  // with an 1.4.x svn client
>  cd D:\
>  svnadmin create testrepo
>  cd testrepo
>  svnserve -d -r D:\
>
>
>  // now with an 1.4.x svn client
>  svn ls svn://localhost/testrepo
>  // no error, it works
>
>  // now with an 1.5 svn client
>  svn ls svn://localhost/testrepo
>  svn: Can't connect to host 'localhost': connection refused

Can you try it with trunk build?  I seem to recall this being reported
a while back and it had to do with SASL.  I would have thought it was
fixed, but perhaps it was and has not been backported yet?


-- 
Thanks

Mark Phippard
http://markphip.blogspot.com/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org


Re: 1.5 client can't connect to 1.4 svnserve

Posted by Stefan Küng <to...@gmail.com>.
Stefan Küng wrote:
> Hi,
> 
> Using a current build from the 1.5.x branch (built 30 minutes ago), I 
> can't connect to svnserve based repositories.
> Users on the TSVN list also reported that this happened with the alpha 
> build too.
> 
> Since I couldn't find an entry in the STATUS file indicating that this 
> has already been fixed, here's how to reproduce this:
> 
> // with an 1.4.x svn client
> cd D:\
> svnadmin create testrepo
> cd testrepo
> svnserve -d -r D:\
> 
> 
> // now with an 1.4.x svn client
> svn ls svn://localhost/testrepo
> // no error, it works
> 
> // now with an 1.5 svn client
> svn ls svn://localhost/testrepo
> svn: Can't connect to host 'localhost': connection refused

Additional information:
just built svnserve from the 1.5.x branch, and with that it works.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net