You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "xianjingfeng (via GitHub)" <gi...@apache.org> on 2023/08/25 08:58:06 UTC

[GitHub] [incubator-uniffle] xianjingfeng opened a new pull request, #1174: [#1173] fix: incorrect shuffle server status

xianjingfeng opened a new pull request, #1174:
URL: https://github.com/apache/incubator-uniffle/pull/1174

   <!--
   1. Title: [#<issue>] <type>(<scope>): <subject>
      Examples:
        - "[#123] feat(operator): support xxx"
        - "[#233] fix: check null before access result in xxx"
        - "[MINOR] refactor: fix typo in variable name"
        - "[MINOR] docs: fix typo in README"
        - "[#255] test: fix flaky test NameOfTheTest"
      Reference: https://www.conventionalcommits.org/en/v1.0.0/
   2. Contributor guidelines:
      https://github.com/apache/incubator-uniffle/blob/master/CONTRIBUTING.md
   3. If the PR is unfinished, please mark this PR as draft.
   -->
   
   ### What changes were proposed in this pull request?
   
   Fix incorrect shuffle server status.
   
   ### Why are the changes needed?
   
   Fix: #1173 
   
   ### Does this PR introduce _any_ user-facing change?
   
   No.
   
   ### How was this patch tested?
   
   UT
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


[GitHub] [incubator-uniffle] xianjingfeng merged pull request #1174: [#1173] fix: incorrect shuffle server status

Posted by "xianjingfeng (via GitHub)" <gi...@apache.org>.
xianjingfeng merged PR #1174:
URL: https://github.com/apache/incubator-uniffle/pull/1174


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


[GitHub] [incubator-uniffle] xianjingfeng commented on pull request #1174: [#1173] fix: incorrect shuffle server status

Posted by "xianjingfeng (via GitHub)" <gi...@apache.org>.
xianjingfeng commented on PR #1174:
URL: https://github.com/apache/incubator-uniffle/pull/1174#issuecomment-1693146358

   @yl09099 cc


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


[GitHub] [incubator-uniffle] xianjingfeng commented on pull request #1174: [#1173] fix: incorrect shuffle server status

Posted by "xianjingfeng (via GitHub)" <gi...@apache.org>.
xianjingfeng commented on PR #1174:
URL: https://github.com/apache/incubator-uniffle/pull/1174#issuecomment-1695319934

   Merged. Thanks all.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


[GitHub] [incubator-uniffle] yl09099 commented on pull request #1174: [#1173] fix: incorrect shuffle server status

Posted by "yl09099 (via GitHub)" <gi...@apache.org>.
yl09099 commented on PR #1174:
URL: https://github.com/apache/incubator-uniffle/pull/1174#issuecomment-1694923756

   > @yl09099 cc
   
   ICU
   
   > @yl09099 cc
   
   LGTM~


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


[GitHub] [incubator-uniffle] codecov-commenter commented on pull request #1174: [#1173] fix: incorrect shuffle server status

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #1174:
URL: https://github.com/apache/incubator-uniffle/pull/1174#issuecomment-1693105911

   ## [Codecov](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1174?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   > Merging [#1174](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1174?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (91b5db0) into [master](https://app.codecov.io/gh/apache/incubator-uniffle/commit/9b725f250469798ca603e62a12ec521eb55d9de5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (9b725f2) will **increase** coverage by `1.10%`.
   > The diff coverage is `75.00%`.
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1174      +/-   ##
   ============================================
   + Coverage     53.64%   54.74%   +1.10%     
   + Complexity     2581     2580       -1     
   ============================================
     Files           391      371      -20     
     Lines         22406    20043    -2363     
     Branches       1876     1874       -2     
   ============================================
   - Hits          12019    10972    -1047     
   + Misses         9679     8434    -1245     
   + Partials        708      637      -71     
   ```
   
   
   | [Files Changed](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1174?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...iffle/coordinator/web/resource/ServerResource.java](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1174?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29vcmRpbmF0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3VuaWZmbGUvY29vcmRpbmF0b3Ivd2ViL3Jlc291cmNlL1NlcnZlclJlc291cmNlLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...ache/uniffle/coordinator/SimpleClusterManager.java](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1174?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29vcmRpbmF0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3VuaWZmbGUvY29vcmRpbmF0b3IvU2ltcGxlQ2x1c3Rlck1hbmFnZXIuamF2YQ==) | `77.71% <100.00%> (+0.18%)` | :arrow_up: |
   
   ... and [21 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1174/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org