[GitHub] [logging-log4j2] vy commented on a change in pull request #591: LOG4J2-2829 SocketAppender should propagate failures when reconnection fails.

[GitBox <gi...@apache.org>]

vy commented on a change in pull request #591:
URL: https://github.com/apache/logging-log4j2/pull/591#discussion_r735154155



##########
File path: log4j-core/src/main/java/org/apache/logging/log4j/core/net/TcpSocketManager.java
##########
@@ -238,7 +238,10 @@ protected void write(final byte[] bytes, final int offset, final int length, fin
                                         config),
                                 causeEx);
                     }
+                    return;
                 }
+                final String message = String.format("Error writing to %s for connection %s", getName(), config);

Review comment:
       Maybe it is of personal taste, but I find `var h = h(); var g = g(h); f(g)` more easy to read and debug compared to `f(g(h))`, granted there is no efficiency impact.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org