You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by "xiaobiaozhao (via GitHub)" <gi...@apache.org> on 2023/05/07 02:58:42 UTC
[GitHub] [incubator-kvrocks-website] xiaobiaozhao opened a new pull request, #101: docs: update release doc
xiaobiaozhao opened a new pull request, #101:
URL: https://github.com/apache/incubator-kvrocks-website/pull/101
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks-website] xiaobiaozhao commented on a diff in pull request #101: docs: update release doc
Posted by "xiaobiaozhao (via GitHub)" <gi...@apache.org>.
xiaobiaozhao commented on code in PR #101:
URL: https://github.com/apache/incubator-kvrocks-website/pull/101#discussion_r1186806770
##########
community/create-a-release.md:
##########
@@ -170,7 +170,7 @@ svn ci -m "add gpg key for YOUR_NAME" # Later on, if you are asked to enter a us
## Create source releases and stage
1. Checkout to the RELEASE BRANCH and cherry-pick commits to release
-2. Use `./x.py package source --version ${release_version} -rc ${candidate_number}` to create release tarball
+2. Use `./x.py package source --v ${release_version} -rc ${candidate_number}` to create release tarball
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks-website] PragmaTwice commented on a diff in pull request #101: docs: update release doc
Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice commented on code in PR #101:
URL: https://github.com/apache/incubator-kvrocks-website/pull/101#discussion_r1199680528
##########
community/create-a-release.md:
##########
@@ -212,9 +212,10 @@ Docker and Docker Buildx is required for this step. Docker Buildx should be bund
1. `docker login` to your own DockerHub account.
2. Build and push docker images to your personal repository on DockerHub:
+3. MORE BUILD ARGS can be adjusted according to the performance of your computer
```shell
-docker buildx build --platform linux/amd64,linux/arm64 --tag ${your_dockerhub_username}/kvrocks:${release_version} --tag ${your_dockerhub_username}/kvrocks:latest . --output-type=registry
+docker buildx build --platform linux/amd64,linux/arm64 --tag ${your_dockerhub_username}/kvrocks:${release_version} --tag ${your_dockerhub_username}/kvrocks:latest . --output "type=registry" --build-arg MORE_BUILD_ARGS=-j12
Review Comment:
What is the meaning of `12` here? Why is `12` fit for any CPU settings? We do not need these nonsense numbers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks-website] tisonkun commented on a diff in pull request #101: docs: update release doc
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on code in PR #101:
URL: https://github.com/apache/incubator-kvrocks-website/pull/101#discussion_r1199631462
##########
community/create-a-release.md:
##########
@@ -212,9 +212,10 @@ Docker and Docker Buildx is required for this step. Docker Buildx should be bund
1. `docker login` to your own DockerHub account.
2. Build and push docker images to your personal repository on DockerHub:
+3. MORE BUILD ARGS can be adjusted according to the performance of your computer
```shell
-docker buildx build --platform linux/amd64,linux/arm64 --tag ${your_dockerhub_username}/kvrocks:${release_version} --tag ${your_dockerhub_username}/kvrocks:latest . --output-type=registry
+docker buildx build --platform linux/amd64,linux/arm64 --tag ${your_dockerhub_username}/kvrocks:${release_version} --tag ${your_dockerhub_username}/kvrocks:latest . --output "type=registry" --build-arg MORE_BUILD_ARGS=-j12
Review Comment:
Generally, we don't need to specify `-j12` but let the platform to determinate parallelism.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks-website] git-hulk commented on a diff in pull request #101: docs: update release doc
Posted by "git-hulk (via GitHub)" <gi...@apache.org>.
git-hulk commented on code in PR #101:
URL: https://github.com/apache/incubator-kvrocks-website/pull/101#discussion_r1186776294
##########
community/create-a-release.md:
##########
@@ -170,7 +170,7 @@ svn ci -m "add gpg key for YOUR_NAME" # Later on, if you are asked to enter a us
## Create source releases and stage
1. Checkout to the RELEASE BRANCH and cherry-pick commits to release
-2. Use `./x.py package source --version ${release_version} -rc ${candidate_number}` to create release tarball
+2. Use `./x.py package source --v ${release_version} -rc ${candidate_number}` to create release tarball
Review Comment:
```suggestion
2. Use `./x.py package source -v ${release_version} -rc ${candidate_number}` to create release tarball
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks-website] git-hulk merged pull request #101: docs: update release doc
Posted by "git-hulk (via GitHub)" <gi...@apache.org>.
git-hulk merged PR #101:
URL: https://github.com/apache/incubator-kvrocks-website/pull/101
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org