You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/05/23 06:39:53 UTC

[GitHub] [incubator-kyuubi] link3280 commented on a diff in pull request #2724: [KYUUBI #2238] [WIP] Support Flink 1.15

link3280 commented on code in PR #2724:
URL: https://github.com/apache/incubator-kyuubi/pull/2724#discussion_r879071835


##########
externals/kyuubi-flink-sql-engine/pom.xml:
##########
@@ -61,19 +61,19 @@
 
         <dependency>
             <groupId>org.apache.flink</groupId>
-            <artifactId>flink-streaming-java_${scala.binary.version}</artifactId>
+            <artifactId>flink-streaming-java</artifactId>

Review Comment:
   That's indeed a critical issue. Kyuubi uses some non-public Flink APIs, which have no backward compatibility guarantee. We may need a multi-version solution like FlinkShims in Zeeplin. 
   
   @wolfboys Does StreamX use Flink internal APIs as well? How does it achieve multi-version support? Thanks!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org